From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v5 25/27] NFS: Add fs_context support.
Date: Fri, 22 Nov 2019 11:22:25 +0300 [thread overview]
Message-ID: <20191122082225.GG617@kadam> (raw)
In-Reply-To: <20191120152750.6880-26-smayhew@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3160 bytes --]
Hi Scott,
url: https://github.com/0day-ci/linux/commits/Scott-Mayhew/nfs-Mount-API-conversion/20191121-164447
base: af42d3466bdc8f39806b26f593604fdc54140bcb
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
fs/nfs/nfs4namespace.c:147 nfs4_validate_fspath() error: uninitialized symbol 'len'.
fs/nfs/nfs4namespace.c:149 nfs4_validate_fspath() error: 'fs_path' dereferencing possible ERR_PTR()
# https://github.com/0day-ci/linux/commit/deebb47534c8b45696a02a0d8aff35b232b24e15
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout deebb47534c8b45696a02a0d8aff35b232b24e15
vim +/len +147 fs/nfs/nfs4namespace.c
b514f872f86d4b Al Viro 2011-03-16 129 static int nfs4_validate_fspath(struct dentry *dentry,
54ceac45159860 David Howells 2006-08-22 130 const struct nfs4_fs_locations *locations,
deebb47534c8b4 David Howells 2019-11-20 131 struct nfs_fs_context *ctx)
54ceac45159860 David Howells 2006-08-22 132 {
54ceac45159860 David Howells 2006-08-22 133 const char *path, *fs_path;
deebb47534c8b4 David Howells 2019-11-20 134 char *buf;
deebb47534c8b4 David Howells 2019-11-20 135 unsigned short len;
deebb47534c8b4 David Howells 2019-11-20 136 int n;
54ceac45159860 David Howells 2006-08-22 137
deebb47534c8b4 David Howells 2019-11-20 138 buf = kmalloc(4096, GFP_KERNEL);
deebb47534c8b4 David Howells 2019-11-20 139 path = nfs4_path(dentry, buf, 4096);
deebb47534c8b4 David Howells 2019-11-20 140 if (IS_ERR(path)) {
deebb47534c8b4 David Howells 2019-11-20 141 kfree(buf);
54ceac45159860 David Howells 2006-08-22 142 return PTR_ERR(path);
deebb47534c8b4 David Howells 2019-11-20 143 }
54ceac45159860 David Howells 2006-08-22 144
deebb47534c8b4 David Howells 2019-11-20 145 fs_path = nfs4_pathname_string(&locations->fs_path, &len);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Both warnings are because Smatch thinks nfs4_pathname_string() can
return an error pointer without initializing "len".
54ceac45159860 David Howells 2006-08-22 146
deebb47534c8b4 David Howells 2019-11-20 @147 n = strncmp(path, fs_path, len);
deebb47534c8b4 David Howells 2019-11-20 148 kfree(buf);
deebb47534c8b4 David Howells 2019-11-20 @149 kfree(fs_path);
deebb47534c8b4 David Howells 2019-11-20 150 if (n != 0) {
54ceac45159860 David Howells 2006-08-22 151 dprintk("%s: path %s does not begin with fsroot %s\n",
deebb47534c8b4 David Howells 2019-11-20 152 __func__, path, ctx->nfs_server.export_path);
54ceac45159860 David Howells 2006-08-22 153 return -ENOENT;
54ceac45159860 David Howells 2006-08-22 154 }
54ceac45159860 David Howells 2006-08-22 155
54ceac45159860 David Howells 2006-08-22 156 return 0;
54ceac45159860 David Howells 2006-08-22 157 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v5 25/27] NFS: Add fs_context support.
Date: Fri, 22 Nov 2019 11:22:25 +0300 [thread overview]
Message-ID: <20191122082225.GG617@kadam> (raw)
In-Reply-To: <20191120152750.6880-26-smayhew@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 3160 bytes --]
Hi Scott,
url: https://github.com/0day-ci/linux/commits/Scott-Mayhew/nfs-Mount-API-conversion/20191121-164447
base: af42d3466bdc8f39806b26f593604fdc54140bcb
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
fs/nfs/nfs4namespace.c:147 nfs4_validate_fspath() error: uninitialized symbol 'len'.
fs/nfs/nfs4namespace.c:149 nfs4_validate_fspath() error: 'fs_path' dereferencing possible ERR_PTR()
# https://github.com/0day-ci/linux/commit/deebb47534c8b45696a02a0d8aff35b232b24e15
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout deebb47534c8b45696a02a0d8aff35b232b24e15
vim +/len +147 fs/nfs/nfs4namespace.c
b514f872f86d4b Al Viro 2011-03-16 129 static int nfs4_validate_fspath(struct dentry *dentry,
54ceac45159860 David Howells 2006-08-22 130 const struct nfs4_fs_locations *locations,
deebb47534c8b4 David Howells 2019-11-20 131 struct nfs_fs_context *ctx)
54ceac45159860 David Howells 2006-08-22 132 {
54ceac45159860 David Howells 2006-08-22 133 const char *path, *fs_path;
deebb47534c8b4 David Howells 2019-11-20 134 char *buf;
deebb47534c8b4 David Howells 2019-11-20 135 unsigned short len;
deebb47534c8b4 David Howells 2019-11-20 136 int n;
54ceac45159860 David Howells 2006-08-22 137
deebb47534c8b4 David Howells 2019-11-20 138 buf = kmalloc(4096, GFP_KERNEL);
deebb47534c8b4 David Howells 2019-11-20 139 path = nfs4_path(dentry, buf, 4096);
deebb47534c8b4 David Howells 2019-11-20 140 if (IS_ERR(path)) {
deebb47534c8b4 David Howells 2019-11-20 141 kfree(buf);
54ceac45159860 David Howells 2006-08-22 142 return PTR_ERR(path);
deebb47534c8b4 David Howells 2019-11-20 143 }
54ceac45159860 David Howells 2006-08-22 144
deebb47534c8b4 David Howells 2019-11-20 145 fs_path = nfs4_pathname_string(&locations->fs_path, &len);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Both warnings are because Smatch thinks nfs4_pathname_string() can
return an error pointer without initializing "len".
54ceac45159860 David Howells 2006-08-22 146
deebb47534c8b4 David Howells 2019-11-20 @147 n = strncmp(path, fs_path, len);
deebb47534c8b4 David Howells 2019-11-20 148 kfree(buf);
deebb47534c8b4 David Howells 2019-11-20 @149 kfree(fs_path);
deebb47534c8b4 David Howells 2019-11-20 150 if (n != 0) {
54ceac45159860 David Howells 2006-08-22 151 dprintk("%s: path %s does not begin with fsroot %s\n",
deebb47534c8b4 David Howells 2019-11-20 152 __func__, path, ctx->nfs_server.export_path);
54ceac45159860 David Howells 2006-08-22 153 return -ENOENT;
54ceac45159860 David Howells 2006-08-22 154 }
54ceac45159860 David Howells 2006-08-22 155
54ceac45159860 David Howells 2006-08-22 156 return 0;
54ceac45159860 David Howells 2006-08-22 157 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
next prev parent reply other threads:[~2019-11-22 8:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-20 15:27 [PATCH v5 00/27] nfs: Mount API conversion Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 01/27] saner calling conventions for nfs_fs_mount_common() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 02/27] nfs: stash server into struct nfs_mount_info Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 03/27] nfs: lift setting mount_info from nfs4_remote{,_referral}_mount Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 04/27] nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_type Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 05/27] nfs: don't bother setting/restoring export_path around do_nfs_root_mount() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 06/27] nfs4: fold nfs_do_root_mount/nfs_follow_remote_path Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 07/27] nfs: lift setting mount_info from nfs_xdev_mount() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 08/27] nfs: stash nfs_subversion reference into nfs_mount_info Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 09/27] nfs: don't bother passing nfs_subversion to ->try_mount() and nfs_fs_mount_common() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 10/27] nfs: merge xdev and remote file_system_type Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 11/27] nfs: unexport nfs_fs_mount_common() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 12/27] nfs: don't pass nfs_subversion to ->create_server() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 13/27] nfs: get rid of mount_info ->fill_super() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 14/27] nfs_clone_sb_security(): simplify the check for server bogosity Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 15/27] nfs: get rid of ->set_security() Scott Mayhew
2019-11-21 5:52 ` James Morris
2019-11-20 15:27 ` [PATCH v5 16/27] NFS: Move mount parameterisation bits into their own file Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 17/27] NFS: Constify mount argument match tables Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 18/27] NFS: Rename struct nfs_parsed_mount_data to struct nfs_fs_context Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 19/27] NFS: Split nfs_parse_mount_options() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 20/27] NFS: Deindent nfs_fs_context_parse_option() Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 21/27] NFS: Add a small buffer in nfs_fs_context to avoid string dup Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 22/27] NFS: Do some tidying of the parsing code Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 23/27] NFS: rename nfs_fs_context pointer arg in a few functions Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 24/27] NFS: Convert mount option parsing to use functionality from fs_parser.h Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 25/27] NFS: Add fs_context support Scott Mayhew
2019-11-22 8:22 ` Dan Carpenter [this message]
2019-11-22 8:22 ` Dan Carpenter
2019-11-20 15:27 ` [PATCH v5 26/27] NFS: Additional refactoring for fs_context conversion Scott Mayhew
2019-11-20 15:27 ` [PATCH v5 27/27] NFS: Attach supplementary error information to fs_context Scott Mayhew
2019-12-06 14:39 ` [PATCH v5 00/27] nfs: Mount API conversion Scott Mayhew
2019-12-06 19:58 ` Schumaker, Anna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122082225.GG617@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.