From: "Michael S. Tsirkin" <mst@redhat.com>
To: Julio Faracco <jcfaracco@gmail.com>
Cc: netdev@vger.kernel.org, Daiane Mendes <dnmendes76@gmail.com>,
Jason Wang <jasowang@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler
Date: Sun, 24 Nov 2019 05:52:02 -0500 [thread overview]
Message-ID: <20191124054916-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAENf94L7zU6JoM+19F+__b6W4mpe5Na=ayd+eYe4aZ+EBABmiA@mail.gmail.com>
On Sat, Nov 23, 2019 at 08:33:40PM -0200, Julio Faracco wrote:
> >
> > netdev: pass the stuck queue to the timeout handler
> >
> > This allows incrementing the correct timeout statistic without any mess.
> > Down the road, devices can learn to reset just the specific queue.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> > Warning: untested.
> >
>
> Question...
> Wouldn't be better to create a module parameter instead change the
> function scope?
Passing the value in a global variable? That fails to be reentrant ...
> I'm asking it because how many modules would effectively take advantage of it?
The cost is effectively 0 though.
--
MST
next prev parent reply other threads:[~2019-11-24 10:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-22 1:36 [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler Julio Faracco
2019-11-22 10:31 ` Michael S. Tsirkin
2019-11-22 10:31 ` Michael S. Tsirkin
2019-11-22 12:59 ` Julio Faracco
2019-11-22 13:53 ` Michael S. Tsirkin
2019-11-22 13:53 ` Michael S. Tsirkin
2019-11-23 22:33 ` Julio Faracco
2019-11-23 22:33 ` Julio Faracco
2019-11-24 10:52 ` Michael S. Tsirkin [this message]
2019-11-24 10:52 ` Michael S. Tsirkin
2019-11-24 14:49 ` kbuild test robot
2019-11-24 15:05 ` Michael S. Tsirkin
2019-11-24 15:05 ` Michael S. Tsirkin
2019-11-24 21:48 ` Michael S. Tsirkin
2019-11-24 23:03 ` Jakub Kicinski
2019-11-24 23:03 ` Jakub Kicinski
2019-11-24 23:18 ` Michael S. Tsirkin
2019-11-24 23:18 ` Michael S. Tsirkin
2019-11-24 23:29 ` Michael S. Tsirkin
2019-11-24 23:29 ` Michael S. Tsirkin
2019-11-24 23:37 ` Jakub Kicinski
2019-11-25 8:42 ` Michael S. Tsirkin
2019-11-25 8:42 ` Michael S. Tsirkin
2019-11-28 19:26 ` kbuild test robot
2019-11-24 23:37 ` Jakub Kicinski
2019-11-25 8:20 ` kbuild test robot
2019-11-24 21:48 ` Michael S. Tsirkin
2019-11-24 15:05 ` Michael S. Tsirkin
2019-11-22 12:59 ` Julio Faracco
-- strict thread matches above, loose matches on Subject: below --
2019-11-22 1:36 Julio Faracco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124054916-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=dnmendes76@gmail.com \
--cc=jasowang@redhat.com \
--cc=jcfaracco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.