Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3922 bytes --]

Hi "Michael,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]
[cannot apply to net-next/master v5.4 next-20191122]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Michael-S-Tsirkin/Re-PATCH-net-next-v2-drivers-net-virtio_net-Implement-a-dev_watchdog-handler/20191125-073557
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 312434617cb16be5166316cf9d08ba760b1042a1
config: nds32-allyesconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 8.1.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=8.1.0 make.cross ARCH=nds32 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/8390/ax88796.c:641:21: error: initialization of 'void (*)(struct net_device *, unsigned int)' from incompatible pointer type 'void (*)(struct net_device *)' [-Werror=incompatible-pointer-types]
     .ndo_tx_timeout  = ax_ei_tx_timeout,
                        ^~~~~~~~~~~~~~~~
   drivers/net/ethernet/8390/ax88796.c:641:21: note: (near initialization for 'ax_netdev_ops.ndo_tx_timeout')
   cc1: some warnings being treated as errors

vim +641 drivers/net/ethernet/8390/ax88796.c

89e536a190f90d drivers/net/ax88796.c               Magnus Damm 2007-09-28  634  
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  635  static const struct net_device_ops ax_netdev_ops = {
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  636  	.ndo_open		= ax_open,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  637  	.ndo_stop		= ax_close,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  638  	.ndo_do_ioctl		= ax_ioctl,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  639  
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  640  	.ndo_start_xmit		= ax_ei_start_xmit,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14 @641  	.ndo_tx_timeout		= ax_ei_tx_timeout,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  642  	.ndo_get_stats		= ax_ei_get_stats,
afc4b13df14312 drivers/net/ethernet/8390/ax88796.c Jiri Pirko  2011-08-16  643  	.ndo_set_rx_mode	= ax_ei_set_multicast_list,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  644  	.ndo_validate_addr	= eth_validate_addr,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  645  	.ndo_set_mac_address	= eth_mac_addr,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  646  #ifdef CONFIG_NET_POLL_CONTROLLER
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  647  	.ndo_poll_controller	= ax_ei_poll,
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  648  #endif
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  649  };
d57bc36e7aba9e drivers/net/ax88796.c               Magnus Damm 2009-01-14  650  

:::::: The code at line 641 was first introduced by commit
:::::: d57bc36e7aba9e3a00d154f5eff80ff596146fc4 ax88796: start_xmit fix using net_device_ops

:::::: TO: Magnus Damm <damm@igel.co.jp>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 53259 bytes --]