From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: megous@megous.com, devicetree@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
mripard@kernel.org, kishon@ti.com, paul.kocialkowski@bootlin.com,
linux-sunxi@googlegroups.com, robh+dt@kernel.org,
mark.rutland@arm.com, wens@csie.org, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org, icenowy@aosc.io
Subject: Re: [PATCH v2] phy: allwinner: Fix GENMASK misuse
Date: Sun, 24 Nov 2019 23:10:19 +0100 [thread overview]
Message-ID: <20191124221019.GA1186@rikard> (raw)
In-Reply-To: <20191110124355.1569-1-rikard.falkeborn@gmail.com>
On Sun, Nov 10, 2019 at 01:43:55PM +0100, Rikard Falkeborn wrote:
> Arguments are supposed to be ordered high then low.
>
> Fixes: a228890f9458 ("phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC")
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> Tested-by: Ondrej Jirman <megous@megous.com>
> ---
> v1->v2: Add fixes tax. Add Ondrejs Tested-by. No functional change.
>
> drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
> index 1169f3e83a6f..b1c04f71a31d 100644
> --- a/drivers/phy/allwinner/phy-sun50i-usb3.c
> +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
> @@ -49,7 +49,7 @@
> #define SUNXI_LOS_BIAS(n) ((n) << 3)
> #define SUNXI_LOS_BIAS_MASK GENMASK(5, 3)
> #define SUNXI_TXVBOOSTLVL(n) ((n) << 0)
> -#define SUNXI_TXVBOOSTLVL_MASK GENMASK(0, 2)
> +#define SUNXI_TXVBOOSTLVL_MASK GENMASK(2, 0)
>
> struct sun50i_usb3_phy {
> struct phy *phy;
> --
> 2.24.0
>
Ping
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rikard Falkeborn <rikard.falkeborn@gmail.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: megous@megous.com, arnd@arndb.de, devicetree@vger.kernel.org,
gregkh@linuxfoundation.org, icenowy@aosc.io, kishon@ti.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
mark.rutland@arm.com, mripard@kernel.org,
paul.kocialkowski@bootlin.com, robh+dt@kernel.org,
tglx@linutronix.de, wens@csie.org
Subject: Re: [PATCH v2] phy: allwinner: Fix GENMASK misuse
Date: Sun, 24 Nov 2019 23:10:19 +0100 [thread overview]
Message-ID: <20191124221019.GA1186@rikard> (raw)
In-Reply-To: <20191110124355.1569-1-rikard.falkeborn@gmail.com>
On Sun, Nov 10, 2019 at 01:43:55PM +0100, Rikard Falkeborn wrote:
> Arguments are supposed to be ordered high then low.
>
> Fixes: a228890f9458 ("phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC")
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> Tested-by: Ondrej Jirman <megous@megous.com>
> ---
> v1->v2: Add fixes tax. Add Ondrejs Tested-by. No functional change.
>
> drivers/phy/allwinner/phy-sun50i-usb3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/allwinner/phy-sun50i-usb3.c b/drivers/phy/allwinner/phy-sun50i-usb3.c
> index 1169f3e83a6f..b1c04f71a31d 100644
> --- a/drivers/phy/allwinner/phy-sun50i-usb3.c
> +++ b/drivers/phy/allwinner/phy-sun50i-usb3.c
> @@ -49,7 +49,7 @@
> #define SUNXI_LOS_BIAS(n) ((n) << 3)
> #define SUNXI_LOS_BIAS_MASK GENMASK(5, 3)
> #define SUNXI_TXVBOOSTLVL(n) ((n) << 0)
> -#define SUNXI_TXVBOOSTLVL_MASK GENMASK(0, 2)
> +#define SUNXI_TXVBOOSTLVL_MASK GENMASK(2, 0)
>
> struct sun50i_usb3_phy {
> struct phy *phy;
> --
> 2.24.0
>
Ping
next prev parent reply other threads:[~2019-11-24 22:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 13:42 [PATCH 0/4] Add USB 3 support for H6 and Orange Pi 3 megous
2019-10-20 13:42 ` megous
2019-10-20 13:42 ` [PATCH 1/4] dt-bindings: Add bindings for USB3 phy on Allwinner H6 megous
2019-10-20 13:42 ` megous
2019-10-21 11:06 ` Maxime Ripard
2019-10-21 11:06 ` Maxime Ripard
2019-10-20 13:42 ` [PATCH 2/4] phy: allwinner: add phy driver for USB3 PHY on Allwinner H6 SoC megous
2019-10-20 13:42 ` megous
2019-10-21 11:08 ` Maxime Ripard
2019-10-21 11:08 ` Maxime Ripard
2019-11-07 20:46 ` [PATCH] phy: allwinner: Fix GENMASK misuse Rikard Falkeborn
2019-11-07 20:46 ` Rikard Falkeborn
2019-11-07 21:45 ` Ondřej Jirman
2019-11-07 21:45 ` Ondřej Jirman
2019-11-08 11:29 ` Icenowy Zheng
2019-11-08 11:29 ` Icenowy Zheng
2019-11-08 11:41 ` Ondřej Jirman
2019-11-08 11:41 ` Ondřej Jirman
2019-11-08 11:43 ` Ondřej Jirman
2019-11-08 11:43 ` Ondřej Jirman
2019-11-07 23:39 ` Russell King - ARM Linux admin
2019-11-07 23:39 ` Russell King - ARM Linux admin
2019-11-08 1:46 ` Joe Perches
2019-11-08 1:46 ` Joe Perches
2019-11-08 8:29 ` Paul Kocialkowski
2019-11-08 8:29 ` Paul Kocialkowski
2019-11-10 12:43 ` [PATCH v2] " Rikard Falkeborn
2020-02-22 23:41 ` [PATCH v2 RESEND] " Ondrej Jirman
2019-11-10 12:43 ` [PATCH v2] " Rikard Falkeborn
2019-11-24 22:10 ` Rikard Falkeborn [this message]
2019-11-24 22:10 ` Rikard Falkeborn
2019-12-09 20:18 ` Rikard Falkeborn
2019-12-09 20:18 ` Rikard Falkeborn
2020-02-23 3:23 ` [linux-sunxi] [PATCH v2 RESEND] " Chen-Yu Tsai
2020-02-23 3:23 ` Chen-Yu Tsai
2020-02-24 9:18 ` Maxime Ripard
2020-02-24 9:18 ` Maxime Ripard
2019-10-20 13:42 ` [PATCH 3/4] arm64: dts: allwinner: h6: add USB3 device nodes megous
2019-10-20 13:42 ` megous
2019-10-20 13:42 ` [PATCH 4/4] arm64: dts: allwinner: orange-pi-3: Enable USB 3.0 host support megous
2019-10-20 13:42 ` megous
2019-10-21 11:09 ` Maxime Ripard
2019-10-21 11:09 ` Maxime Ripard
2019-11-04 12:16 ` Ondřej Jirman
2019-11-04 12:16 ` Ondřej Jirman
2019-11-05 10:45 ` Maxime Ripard
2019-11-05 10:45 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191124221019.GA1186@rikard \
--to=rikard.falkeborn@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=icenowy@aosc.io \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.