From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, John Meneghini <johnm@netapp.com>,
Jen Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org
Subject: Re: [PATCH] nvme: Add support for ACRE Command Interrupted status
Date: Tue, 26 Nov 2019 17:24:12 +0100 [thread overview]
Message-ID: <20191126162412.GA7663@lst.de> (raw)
In-Reply-To: <20191126160546.GA2906@redsun51.ssa.fujisawa.hgst.com>
On Wed, Nov 27, 2019 at 01:05:46AM +0900, Keith Busch wrote:
> > +++ b/include/linux/blk_types.h
> > @@ -84,6 +84,7 @@ static inline bool blk_path_error(blk_status_t error)
> > case BLK_STS_NEXUS:
> > case BLK_STS_MEDIUM:
> > case BLK_STS_PROTECTION:
> > + case BLK_STS_RESOURCE:
> > return false;
> > }
>
> I agree we need to make this status a non-path error, but we at least
> need an Ack from Jens or have this patch go through linux-block if we're
> changing BLK_STS_RESOURCE to mean a non-path error.
most resource errors are per-path, so blindly changing this is wrong.
That's why I really just wanted to decode the nvme status codes inside
nvme instead of going through a block layer mapping, as that is just
bound to lose some information.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Jen Axboe <axboe@kernel.dk>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>, Christoph Hellwig <hch@lst.de>,
John Meneghini <johnm@netapp.com>
Subject: Re: [PATCH] nvme: Add support for ACRE Command Interrupted status
Date: Tue, 26 Nov 2019 17:24:12 +0100 [thread overview]
Message-ID: <20191126162412.GA7663@lst.de> (raw)
In-Reply-To: <20191126160546.GA2906@redsun51.ssa.fujisawa.hgst.com>
On Wed, Nov 27, 2019 at 01:05:46AM +0900, Keith Busch wrote:
> > +++ b/include/linux/blk_types.h
> > @@ -84,6 +84,7 @@ static inline bool blk_path_error(blk_status_t error)
> > case BLK_STS_NEXUS:
> > case BLK_STS_MEDIUM:
> > case BLK_STS_PROTECTION:
> > + case BLK_STS_RESOURCE:
> > return false;
> > }
>
> I agree we need to make this status a non-path error, but we at least
> need an Ack from Jens or have this patch go through linux-block if we're
> changing BLK_STS_RESOURCE to mean a non-path error.
most resource errors are per-path, so blindly changing this is wrong.
That's why I really just wanted to decode the nvme status codes inside
nvme instead of going through a block layer mapping, as that is just
bound to lose some information.
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-26 16:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 13:36 [PATCH] nvme: Add support for ACRE Command Interrupted status Hannes Reinecke
2019-11-26 14:48 ` George, Martin
2019-11-26 16:05 ` Keith Busch
2019-11-26 16:05 ` Keith Busch
2019-11-26 16:24 ` Christoph Hellwig [this message]
2019-11-26 16:24 ` Christoph Hellwig
2019-11-27 15:29 ` Meneghini, John
2019-11-27 15:29 ` Meneghini, John
2019-11-27 19:08 ` Keith Busch
2019-11-27 19:08 ` Keith Busch
2019-11-27 19:22 ` Meneghini, John
2019-11-27 19:22 ` Meneghini, John
2019-11-26 16:32 ` Hannes Reinecke
2019-11-26 16:32 ` Hannes Reinecke
2019-11-27 17:17 ` Meneghini, John
2019-11-27 17:17 ` Meneghini, John
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126162412.GA7663@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=johnm@netapp.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.