From: Oliver Graute <oliver.graute@gmail.com>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: DTR <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"netdev@vger.kernel.org Linux ARM"
<linux-arm-kernel@lists.infradead.org>,
"linuxppc-dev@lists.ozlabs.org Pantelis Antoniou"
<pantelis.antoniou@gmail.com>
Subject: Re: [RFC PATCH 1/1] arm64: dts: added basic DTS for qmx8 congatec board
Date: Fri, 29 Nov 2019 08:56:49 +0100 [thread overview]
Message-ID: <20191129075649.GE2460@optiplex> (raw)
In-Reply-To: <ed8b6139-a67d-d5d3-c65b-260d020c95e0@free.fr>
On 28/11/19, Marc Gonzalez wrote:
> On 28/11/2019 10:55, Oliver Graute wrote:
>
> > On 28/11/19, Marc Gonzalez wrote:
> >
> >> On 29/10/2019 13:23, Oliver Graute wrote:
> >>
> >>> +&fec1 {
> >>> + pinctrl-names = "default";
> >>> + pinctrl-0 = <&pinctrl_fec1>;
> >>> + phy-mode = "rgmii";
> >>> + phy-handle = <ðphy0>;
> >>> + fsl,magic-packet;
> >>> + fsl,rgmii_txc_dly;
> >>> + fsl,rgmii_rxc_dly;
> >>> + status = "okay";
> >>
> >> The two fsl,rgmii* properties do not exist in mainline.
> >> I suppose there were copied from downstream?
> >
> > you are right, I'll remove them.
>
> You should first check what the downstream driver does for them.
> And check if there is an equivalent action in mainline.
> These delays tend to be required for the PHY to work at all.
ok as far as I see there is currently no equilant action in mainline.
Downstream linux-imx use rgmii_txc_dly and rgmii_rxc_dly in fec_probe()
and fec_restart() for some imx8qm-fec and imx8mq-fec PHY delay quirks.
Perhaps this missing quirks are related to the random crashes in that
driver I have with imx8qm.
[ 129.211959] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.217300] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.222647] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.227966] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.233282] fec 5b040000.ethernet eth0: rcv is not +last
Best regards,
Oliver
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Graute <oliver.graute@gmail.com>
To: Marc Gonzalez <marc.w.gonzalez@free.fr>
Cc: DTR <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"linuxppc-dev@lists.ozlabs.org Pantelis Antoniou"
<pantelis.antoniou@gmail.com>,
"netdev@vger.kernel.org Linux ARM"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/1] arm64: dts: added basic DTS for qmx8 congatec board
Date: Fri, 29 Nov 2019 08:56:49 +0100 [thread overview]
Message-ID: <20191129075649.GE2460@optiplex> (raw)
In-Reply-To: <ed8b6139-a67d-d5d3-c65b-260d020c95e0@free.fr>
On 28/11/19, Marc Gonzalez wrote:
> On 28/11/2019 10:55, Oliver Graute wrote:
>
> > On 28/11/19, Marc Gonzalez wrote:
> >
> >> On 29/10/2019 13:23, Oliver Graute wrote:
> >>
> >>> +&fec1 {
> >>> + pinctrl-names = "default";
> >>> + pinctrl-0 = <&pinctrl_fec1>;
> >>> + phy-mode = "rgmii";
> >>> + phy-handle = <ðphy0>;
> >>> + fsl,magic-packet;
> >>> + fsl,rgmii_txc_dly;
> >>> + fsl,rgmii_rxc_dly;
> >>> + status = "okay";
> >>
> >> The two fsl,rgmii* properties do not exist in mainline.
> >> I suppose there were copied from downstream?
> >
> > you are right, I'll remove them.
>
> You should first check what the downstream driver does for them.
> And check if there is an equivalent action in mainline.
> These delays tend to be required for the PHY to work at all.
ok as far as I see there is currently no equilant action in mainline.
Downstream linux-imx use rgmii_txc_dly and rgmii_rxc_dly in fec_probe()
and fec_restart() for some imx8qm-fec and imx8mq-fec PHY delay quirks.
Perhaps this missing quirks are related to the random crashes in that
driver I have with imx8qm.
[ 129.211959] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.217300] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.222647] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.227966] fec 5b040000.ethernet eth0: rcv is not +last
[ 129.233282] fec 5b040000.ethernet eth0: rcv is not +last
Best regards,
Oliver
next prev parent reply other threads:[~2019-11-29 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 12:22 [RFC PATCH 0/1] arm64: dts: added basic DTS for qmx8 congatec board Oliver Graute
2019-10-29 12:22 ` Oliver Graute
2019-10-29 12:23 ` [RFC PATCH 1/1] " Oliver Graute
2019-10-29 12:23 ` Oliver Graute
2019-11-14 10:48 ` oliver.graute
2019-11-14 10:48 ` oliver.graute
2019-11-28 9:29 ` Marc Gonzalez
2019-11-28 9:29 ` Marc Gonzalez
2019-11-28 9:55 ` Oliver Graute
2019-11-28 9:55 ` Oliver Graute
2019-11-28 10:31 ` Marc Gonzalez
2019-11-28 10:31 ` Marc Gonzalez
2019-11-29 7:56 ` Oliver Graute [this message]
2019-11-29 7:56 ` Oliver Graute
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191129075649.GE2460@optiplex \
--to=oliver.graute@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.w.gonzalez@free.fr \
--cc=pantelis.antoniou@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.