All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Durrant, Paul" <pdurrant@amazon.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
	Jens Axboe <axboe@kernel.dk>, Juergen Gross <jgross@suse.com>,
	<boris.ostrovsky@oracle.com>
Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded
Date: Fri, 29 Nov 2019 16:07:57 +0100	[thread overview]
Message-ID: <20191129150757.GA980@Air-de-Roger> (raw)
In-Reply-To: <f06bf1967bdf43ca9b218f9b5c5202a6@EX13D32EUC003.ant.amazon.com>

On Fri, Nov 29, 2019 at 03:02:37PM +0000, Durrant, Paul wrote:
> > -----Original Message-----
> > From: Roger Pau Monné <roger.pau@citrix.com>
> > Sent: 29 November 2019 15:00
> > To: Durrant, Paul <pdurrant@amazon.com>
> > Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; xen-
> > devel@lists.xenproject.org; Konrad Rzeszutek Wilk
> > <konrad.wilk@oracle.com>; Jens Axboe <axboe@kernel.dk>
> > Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly
> > unloaded
> > 
> > On Fri, Nov 29, 2019 at 01:43:06PM +0000, Paul Durrant wrote:
> > > Add a module_exit() to perform the necessary clean-up.
> > >
> > > Signed-off-by: Paul Durrant <pdurrant@amazon.com>
> > 
> > LGTM:
> > 
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> > 
> 
> Thanks.
> 
> > AFAICT we should make sure this is not committed before patch 1, or
> > else you could unload a blkback module that's still in use?
> > 
> 
> Yes, that's correct.

Given this is a very small change, and not really block related I
think it would be better for both patches to be committed from the Xen
tree, if Jens, Juergen and Boris agree.

Thanks, Roger.

WARNING: multiple messages have this Message-ID (diff)
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: "Durrant, Paul" <pdurrant@amazon.com>
Cc: Juergen Gross <jgross@suse.com>, Jens Axboe <axboe@kernel.dk>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	boris.ostrovsky@oracle.com
Subject: Re: [Xen-devel] [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded
Date: Fri, 29 Nov 2019 16:07:57 +0100	[thread overview]
Message-ID: <20191129150757.GA980@Air-de-Roger> (raw)
In-Reply-To: <f06bf1967bdf43ca9b218f9b5c5202a6@EX13D32EUC003.ant.amazon.com>

On Fri, Nov 29, 2019 at 03:02:37PM +0000, Durrant, Paul wrote:
> > -----Original Message-----
> > From: Roger Pau Monné <roger.pau@citrix.com>
> > Sent: 29 November 2019 15:00
> > To: Durrant, Paul <pdurrant@amazon.com>
> > Cc: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; xen-
> > devel@lists.xenproject.org; Konrad Rzeszutek Wilk
> > <konrad.wilk@oracle.com>; Jens Axboe <axboe@kernel.dk>
> > Subject: Re: [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly
> > unloaded
> > 
> > On Fri, Nov 29, 2019 at 01:43:06PM +0000, Paul Durrant wrote:
> > > Add a module_exit() to perform the necessary clean-up.
> > >
> > > Signed-off-by: Paul Durrant <pdurrant@amazon.com>
> > 
> > LGTM:
> > 
> > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
> > 
> 
> Thanks.
> 
> > AFAICT we should make sure this is not committed before patch 1, or
> > else you could unload a blkback module that's still in use?
> > 
> 
> Yes, that's correct.

Given this is a very small change, and not really block related I
think it would be better for both patches to be committed from the Xen
tree, if Jens, Juergen and Boris agree.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-11-29 15:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-29 13:43 [PATCH v2 0/2] allow xen-blkback to be cleanly unloaded Paul Durrant
2019-11-29 13:43 ` [Xen-devel] " Paul Durrant
2019-11-29 13:43 ` [PATCH v2 1/2] xen/xenbus: reference count registered modules Paul Durrant
2019-11-29 13:43   ` [Xen-devel] " Paul Durrant
2019-11-29 15:46   ` Jürgen Groß
2019-11-29 15:46     ` [Xen-devel] " Jürgen Groß
2019-11-29 16:00   ` Jan Beulich
2019-11-29 16:00     ` [Xen-devel] " Jan Beulich
2019-11-29 16:08     ` Durrant, Paul
2019-11-29 16:08       ` [Xen-devel] " Durrant, Paul
2019-11-29 13:43 ` [PATCH v2 2/2] block/xen-blkback: allow module to be cleanly unloaded Paul Durrant
2019-11-29 13:43   ` [Xen-devel] " Paul Durrant
2019-11-29 15:00   ` Roger Pau Monné
2019-11-29 15:00     ` [Xen-devel] " Roger Pau Monné
2019-11-29 15:02     ` Durrant, Paul
2019-11-29 15:02       ` [Xen-devel] " Durrant, Paul
2019-11-29 15:07       ` Roger Pau Monné [this message]
2019-11-29 15:07         ` Roger Pau Monné
2019-11-29 15:45         ` Jürgen Groß
2019-11-29 15:45           ` [Xen-devel] " Jürgen Groß

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191129150757.GA980@Air-de-Roger \
    --to=roger.pau@citrix.com \
    --cc=axboe@kernel.dk \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pdurrant@amazon.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.