From: Jonathan Cameron <jic23@kernel.org>
To: <tomislav.denis@avl.com>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] Add support for DLH pressure sensors
Date: Sun, 1 Dec 2019 10:27:11 +0000 [thread overview]
Message-ID: <20191201102711.641e3f6f@archlinux> (raw)
In-Reply-To: <20191129073420.9800-1-tomislav.denis@avl.com>
On Fri, 29 Nov 2019 08:34:17 +0100
<tomislav.denis@avl.com> wrote:
> From: Tomislav Denis <tomislav.denis@avl.com>
>
> This patchset adds support for All Sensors DLH series low
> voltage digital pressure sensors.
>
> Datasheet: https://www.allsensors.com/cad/DS-0355_Rev_B.PDF
One generic comment before I look at the code.
Mostly (there may be exceptions) it is better to post a new version
as a separate email thread. This avoid deep and extremely confusing
threads when we run into many versions. Also, a lot of maintainers
have limited time so start at their most recent emails on the basis
that earlier discussions have often already been resolved by other
reviewers / contributors. If you send in a reply to an older thread
you reduce the chance of anyone looking at it ;)
Thanks,
Jonathan
>
> Changes in v2:
> - web page link in the MAINTAINERS file fixed
> - adjust the units of the output to the IIO ABI
> - unneceseary default case removed
> - define the channel member of the iio_chan_spec
> struct for channels specification
> - remove explicit cast for pointers of type void *
> - add support for the EOC(data ready) pin
> - drop the unneceseary return ret;
> - rename dlh-i2c.yaml to asc,dlh-i2c.yaml
> - change the bindings copyright to GPL-2.0-only OR BSD-2-Clause
> - document EOC(data ready) pin
>
> Tomislav Denis (3):
> iio: pressure: Add driver for DLH pressure sensors
> dt-bindings: Add asc vendor
> bindings: iio: pressure: Add dlh-i2c documentation
>
> .../bindings/iio/pressure/asc,dlh-i2c.yaml | 51 +++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> MAINTAINERS | 8 +
> drivers/iio/pressure/Kconfig | 12 +
> drivers/iio/pressure/Makefile | 1 +
> drivers/iio/pressure/dlh-i2c.c | 429 +++++++++++++++++++++
> 6 files changed, 503 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/pressure/asc,dlh-i2c.yaml
> create mode 100644 drivers/iio/pressure/dlh-i2c.c
>
prev parent reply other threads:[~2019-12-01 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 10:09 [PATCH 0/3] Add support for DLH pressure sensors tomislav.denis
2019-11-14 10:09 ` [PATCH 1/3] iio: pressure: Add driver " tomislav.denis
2019-11-14 14:35 ` Jonathan Cameron
2019-11-15 7:09 ` Denis, Tomislav AVL DiTEST
2019-11-14 10:09 ` [PATCH 2/3] dt-bindings: Add asc vendor tomislav.denis
2019-11-18 22:16 ` Rob Herring
2019-11-14 10:09 ` [PATCH 3/3] bindings: iio: pressure: Add dlh-i2c documentation tomislav.denis
2019-11-14 14:12 ` Jonathan Cameron
2019-11-29 7:34 ` [PATCH v2 0/3] Add support for DLH pressure sensors tomislav.denis
2019-11-29 7:34 ` [PATCH v2 1/3] iio: pressure: Add driver " tomislav.denis
2019-12-01 10:57 ` Jonathan Cameron
2019-11-29 7:34 ` [PATCH v2 2/3] dt-bindings: Add asc vendor tomislav.denis
2019-12-01 10:58 ` Jonathan Cameron
2019-11-29 7:34 ` [PATCH v2 3/3] bindings: iio: pressure: Add dlh-i2c documentation tomislav.denis
2019-12-01 10:58 ` Jonathan Cameron
2019-12-01 10:27 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191201102711.641e3f6f@archlinux \
--to=jic23@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=tomislav.denis@avl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.