All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>,
	linux-clk <linux-clk@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v1] clk: Convert managed get functions to devm_add_action API
Date: Sun, 1 Dec 2019 17:42:37 -0800	[thread overview]
Message-ID: <20191202014237.GR248138@dtor-ws> (raw)
In-Reply-To: <20191128185630.GK82109@yoga>

On Thu, Nov 28, 2019 at 10:56:30AM -0800, Bjorn Andersson wrote:
> On Tue 26 Nov 08:13 PST 2019, Marc Gonzalez wrote:
> 
> > Date: Tue, 26 Nov 2019 13:56:53 +0100
> > 
> > Using devm_add_action_or_reset() produces simpler code and smaller
> > object size:
> > 
> > 1 file changed, 16 insertions(+), 46 deletions(-)
> > 
> >     text	   data	    bss	    dec	    hex	filename
> > -   1797	     80	      0	   1877	    755	drivers/clk/clk-devres.o
> > +   1499	     56	      0	   1555	    613	drivers/clk/clk-devres.o
> > 
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> 
> Looks neat
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

This however increases the runtime costs as each custom action cost us
an extra pointer. Given that in a system we likely have many clocks
managed by devres, I am not sure that this code savings is actually
gives us overall win. It might still, I just want to understand how we
are allocating/packing devres structures.

Thanks.

-- 
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>,
	Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-clk <linux-clk@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v1] clk: Convert managed get functions to devm_add_action API
Date: Sun, 1 Dec 2019 17:42:37 -0800	[thread overview]
Message-ID: <20191202014237.GR248138@dtor-ws> (raw)
In-Reply-To: <20191128185630.GK82109@yoga>

On Thu, Nov 28, 2019 at 10:56:30AM -0800, Bjorn Andersson wrote:
> On Tue 26 Nov 08:13 PST 2019, Marc Gonzalez wrote:
> 
> > Date: Tue, 26 Nov 2019 13:56:53 +0100
> > 
> > Using devm_add_action_or_reset() produces simpler code and smaller
> > object size:
> > 
> > 1 file changed, 16 insertions(+), 46 deletions(-)
> > 
> >     text	   data	    bss	    dec	    hex	filename
> > -   1797	     80	      0	   1877	    755	drivers/clk/clk-devres.o
> > +   1499	     56	      0	   1555	    613	drivers/clk/clk-devres.o
> > 
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@free.fr>
> 
> Looks neat
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

This however increases the runtime costs as each custom action cost us
an extra pointer. Given that in a system we likely have many clocks
managed by devres, I am not sure that this code savings is actually
gives us overall win. It might still, I just want to understand how we
are allocating/packing devres structures.

Thanks.

-- 
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-02  1:42 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 16:13 [PATCH v1] clk: Convert managed get functions to devm_add_action API Marc Gonzalez
2019-11-26 16:13 ` Marc Gonzalez
2019-11-28 18:56 ` Bjorn Andersson
2019-11-28 18:56   ` Bjorn Andersson
2019-12-02  1:42   ` Dmitry Torokhov [this message]
2019-12-02  1:42     ` Dmitry Torokhov
2019-12-02  9:25     ` Marc Gonzalez
2019-12-02  9:25       ` Marc Gonzalez
2019-12-02 13:51       ` Robin Murphy
2019-12-02 13:51         ` Robin Murphy
2019-12-11 16:17         ` Marc Gonzalez
2019-12-11 16:17           ` Marc Gonzalez
2019-12-11 22:28           ` Dmitry Torokhov
2019-12-11 22:28             ` Dmitry Torokhov
2019-12-12 13:53             ` Marc Gonzalez
2019-12-12 13:53               ` Marc Gonzalez
2019-12-12 14:17               ` Russell King - ARM Linux admin
2019-12-12 14:17                 ` Russell King - ARM Linux admin
2019-12-12 14:41                 ` Marc Gonzalez
2019-12-12 14:41                   ` Marc Gonzalez
2019-12-12 14:46                   ` Russell King - ARM Linux admin
2019-12-12 14:46                     ` Russell King - ARM Linux admin
2019-12-12 15:51                     ` Marc Gonzalez
2019-12-12 15:51                       ` Marc Gonzalez
2019-12-12 16:13                       ` Russell King - ARM Linux admin
2019-12-12 16:13                         ` Russell King - ARM Linux admin
2019-12-12 14:47               ` Robin Murphy
2019-12-12 14:47                 ` Robin Murphy
2019-12-12 16:59                 ` Marc Gonzalez
2019-12-12 16:59                   ` Marc Gonzalez
2019-12-12 17:05                   ` Russell King - ARM Linux admin
2019-12-12 17:05                     ` Russell King - ARM Linux admin
2019-12-12 18:15                   ` Robin Murphy
2019-12-12 18:15                     ` Robin Murphy
2019-12-12 19:10                     ` Dmitry Torokhov
2019-12-12 19:10                       ` Dmitry Torokhov
2019-12-12 21:08                       ` Robin Murphy
2019-12-12 21:08                         ` Robin Murphy
2019-12-13  0:16                         ` Dmitry Torokhov
2019-12-13  0:16                           ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191202014237.GR248138@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marc.w.gonzalez@free.fr \
    --cc=mturquette@baylibre.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sboyd@kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.