All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: devicetree@vger.kernel.org, tony@atomide.com,
	dri-devel@lists.freedesktop.org, peter.ujfalusi@ti.com,
	tomi.valkeinen@ti.com, bcousson@baylibre.com,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel
Date: Tue, 3 Dec 2019 09:29:32 +0200	[thread overview]
Message-ID: <20191203072932.GL4730@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20191202185729.12921-1-jsarha@ti.com>

Hi Jyri,

Thank you for the patch.

On Mon, Dec 02, 2019 at 08:57:29PM +0200, Jyri Sarha wrote:
> Move to use the new drm panel support in tilcdc together with added
> "tfc,s9700rtwv43tr-01b"-panel support in drm panel-simple.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> "tfc,s9700rtwv43tr-01b" in panel-simple has been in for some time now
> so it is about time to get this in too.
> 
>  arch/arm/boot/dts/am335x-evm.dts | 44 +++++++++++++-------------------
>  1 file changed, 18 insertions(+), 26 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index a00145705c9b..0e286a1c9cc5 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -113,7 +113,7 @@
>  		};
>  	};
>  
> -	backlight {
> +	backlight: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&ecap0 0 50000 0>;
>  		brightness-levels = <0 51 53 56 62 75 101 152 255>;
> @@ -121,35 +121,19 @@
>  	};
>  
>  	panel {
> -		compatible = "ti,tilcdc,panel";
> +		compatible = "tfc,s9700rtwv43tr-01b";
> +
>  		status = "okay";

I think this can be dropped as it's implicit.

> +
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&lcd_pins_s0>;
> -		panel-info {
> -			ac-bias           = <255>;
> -			ac-bias-intrpt    = <0>;
> -			dma-burst-sz      = <16>;
> -			bpp               = <32>;
> -			fdd               = <0x80>;
> -			sync-edge         = <0>;
> -			sync-ctrl         = <1>;
> -			raster-order      = <0>;
> -			fifo-th           = <0>;
> -		};
>  
> -		display-timings {
> -			800x480p62 {
> -				clock-frequency = <30000000>;
> -				hactive = <800>;
> -				vactive = <480>;
> -				hfront-porch = <39>;
> -				hback-porch = <39>;
> -				hsync-len = <47>;
> -				vback-porch = <29>;
> -				vfront-porch = <13>;
> -				vsync-len = <2>;
> -				hsync-active = <1>;
> -				vsync-active = <1>;
> +		backlight = <&backlight>;

I would add a blank line here.

> +		ports {
> +			port {
> +				panel_0: endpoint@0 {
> +					remote-endpoint = <&lcdc_0>;
> +				};
>  			};
>  		};

The outter ports node isn't required if there's a single port, up to
you.

>  	};
> @@ -525,6 +509,14 @@
>  	status = "okay";
>  
>  	blue-and-red-wiring = "crossed";
> +
> +	ports {
> +		port {
> +			lcdc_0: endpoint@0 {
> +				remote-endpoint = <&panel_0>;
> +			};
> +		};
> +	};

Same here.

With the above issues addressed as applicable,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  };
>  
>  &elm {

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jyri Sarha <jsarha@ti.com>
Cc: dri-devel@lists.freedesktop.org, tony@atomide.com,
	bcousson@baylibre.com, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, tomi.valkeinen@ti.com,
	peter.ujfalusi@ti.com, bparrot@ti.com
Subject: Re: [PATCH] ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel
Date: Tue, 3 Dec 2019 09:29:32 +0200	[thread overview]
Message-ID: <20191203072932.GL4730@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20191202185729.12921-1-jsarha@ti.com>

Hi Jyri,

Thank you for the patch.

On Mon, Dec 02, 2019 at 08:57:29PM +0200, Jyri Sarha wrote:
> Move to use the new drm panel support in tilcdc together with added
> "tfc,s9700rtwv43tr-01b"-panel support in drm panel-simple.
> 
> Signed-off-by: Jyri Sarha <jsarha@ti.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> "tfc,s9700rtwv43tr-01b" in panel-simple has been in for some time now
> so it is about time to get this in too.
> 
>  arch/arm/boot/dts/am335x-evm.dts | 44 +++++++++++++-------------------
>  1 file changed, 18 insertions(+), 26 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
> index a00145705c9b..0e286a1c9cc5 100644
> --- a/arch/arm/boot/dts/am335x-evm.dts
> +++ b/arch/arm/boot/dts/am335x-evm.dts
> @@ -113,7 +113,7 @@
>  		};
>  	};
>  
> -	backlight {
> +	backlight: backlight {
>  		compatible = "pwm-backlight";
>  		pwms = <&ecap0 0 50000 0>;
>  		brightness-levels = <0 51 53 56 62 75 101 152 255>;
> @@ -121,35 +121,19 @@
>  	};
>  
>  	panel {
> -		compatible = "ti,tilcdc,panel";
> +		compatible = "tfc,s9700rtwv43tr-01b";
> +
>  		status = "okay";

I think this can be dropped as it's implicit.

> +
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&lcd_pins_s0>;
> -		panel-info {
> -			ac-bias           = <255>;
> -			ac-bias-intrpt    = <0>;
> -			dma-burst-sz      = <16>;
> -			bpp               = <32>;
> -			fdd               = <0x80>;
> -			sync-edge         = <0>;
> -			sync-ctrl         = <1>;
> -			raster-order      = <0>;
> -			fifo-th           = <0>;
> -		};
>  
> -		display-timings {
> -			800x480p62 {
> -				clock-frequency = <30000000>;
> -				hactive = <800>;
> -				vactive = <480>;
> -				hfront-porch = <39>;
> -				hback-porch = <39>;
> -				hsync-len = <47>;
> -				vback-porch = <29>;
> -				vfront-porch = <13>;
> -				vsync-len = <2>;
> -				hsync-active = <1>;
> -				vsync-active = <1>;
> +		backlight = <&backlight>;

I would add a blank line here.

> +		ports {
> +			port {
> +				panel_0: endpoint@0 {
> +					remote-endpoint = <&lcdc_0>;
> +				};
>  			};
>  		};

The outter ports node isn't required if there's a single port, up to
you.

>  	};
> @@ -525,6 +509,14 @@
>  	status = "okay";
>  
>  	blue-and-red-wiring = "crossed";
> +
> +	ports {
> +		port {
> +			lcdc_0: endpoint@0 {
> +				remote-endpoint = <&panel_0>;
> +			};
> +		};
> +	};

Same here.

With the above issues addressed as applicable,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  };
>  
>  &elm {

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2019-12-03  7:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 18:57 [PATCH] ARM: dts: am335x-evm: Use drm simple-panel instead of tilcdc-panel Jyri Sarha
2019-12-02 18:57 ` Jyri Sarha
2019-12-02 18:57 ` Jyri Sarha
2019-12-03  7:29 ` Laurent Pinchart [this message]
2019-12-03  7:29   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203072932.GL4730@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.