From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: sagi@grimberg.me,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-nvme@lists.infradead.org, ming.lei@redhat.com,
helgaas@kernel.org, tglx@linutronix.de,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 0/4] nvme: Threaded interrupt handling improvements
Date: Tue, 3 Dec 2019 08:40:55 +0100 [thread overview]
Message-ID: <20191203074055.GC23881@lst.de> (raw)
In-Reply-To: <20191202180659.GB21650@redsun51.ssa.fujisawa.hgst.com>
On Tue, Dec 03, 2019 at 03:06:59AM +0900, Keith Busch wrote:
> On Mon, Dec 02, 2019 at 06:12:39PM +0100, Christoph Hellwig wrote:
> > That's why I had the previous idea of one irq thread per cpu that
> > is assigned to the irq. We'd have to encode a relative index into
> > the hardirq handler return value which we get from bits encoded in
> > the NVMe command ID, but that should be doable. At that point we
> > shouldn't need the cond_resched. I can try to hack that up, but
> > I'm not an expert on the irq thread code.
>
> I'm curious how you intend to implement this. We can't have two threads
> operating on the same CQ at the same time since they have to reap the
> CQ sequentially, so the threads can't selectively choose which entries it
> handles in a queue with mixed encoded CPUs.
True.
> Perhaps we can have just one completion thread call
> smp_call_function_single_async() with the encoded CPU?
Well, blk-mq can do just that for us from blk_mq_complete_request.
> But sadly, I recall we've observed broken controllers break when a
> command id exceeds the queue-depth, and encoding CPUs in the command id
> would do that. Hardware ruins our purity...
Sigh..
_______________________________________________
linux-nvme mailing list
linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-12-03 7:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 17:58 [PATCH 0/4] nvme: Threaded interrupt handling improvements Keith Busch
2019-11-27 17:58 ` [PATCH 1/4] PCI/MSI: Export __pci_msix_desc_mask_irq Keith Busch
2019-11-28 2:42 ` Sagi Grimberg
2019-11-28 3:41 ` Keith Busch
2019-11-28 7:17 ` Christoph Hellwig
2019-11-27 17:58 ` [PATCH 2/4] nvme/pci: Mask legacy and MSI in threaded handler Keith Busch
2019-11-28 3:39 ` Ming Lei
2019-11-28 3:48 ` Keith Busch
2019-11-28 3:58 ` Ming Lei
2019-11-28 4:14 ` Keith Busch
2019-11-28 8:41 ` Ming Lei
2019-11-27 17:58 ` [PATCH 3/4] nvme/pci: Mask MSIx interrupts for threaded handling Keith Busch
2019-11-28 7:19 ` Christoph Hellwig
2019-11-27 17:58 ` [PATCH 4/4] nvme/pci: Spin threaded interrupt completions Keith Busch
2019-11-28 2:46 ` Sagi Grimberg
2019-11-28 3:28 ` Keith Busch
2019-11-28 3:51 ` Ming Lei
2019-11-28 3:58 ` Keith Busch
2019-11-28 7:22 ` Christoph Hellwig
2019-11-29 9:13 ` Sebastian Andrzej Siewior
2019-11-30 18:10 ` Keith Busch
2019-12-02 1:10 ` Ming Lei
2019-12-02 1:30 ` Keith Busch
2019-12-02 16:51 ` Sebastian Andrzej Siewior
2019-11-28 7:50 ` [PATCH 0/4] nvme: Threaded interrupt handling improvements Christoph Hellwig
2019-11-28 17:59 ` Keith Busch
2019-11-29 8:30 ` Christoph Hellwig
2019-11-29 9:46 ` Sebastian Andrzej Siewior
2019-11-29 16:27 ` Keith Busch
2019-11-29 17:05 ` Sebastian Andrzej Siewior
2019-11-30 17:02 ` Keith Busch
2019-12-02 17:05 ` Sebastian Andrzej Siewior
2019-12-02 17:12 ` Christoph Hellwig
2019-12-02 18:06 ` Keith Busch
2019-12-03 7:40 ` Christoph Hellwig [this message]
2019-12-02 19:57 ` Sebastian Andrzej Siewior
2019-12-03 7:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203074055.GC23881@lst.de \
--to=hch@lst.de \
--cc=bigeasy@linutronix.de \
--cc=helgaas@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=ming.lei@redhat.com \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.