From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] power: supply: ab8500: Drop pointless static qualifier in ab8500_btemp_batctrl_vol
Date: Wed, 04 Dec 2019 06:32:40 +0000 [thread overview]
Message-ID: <20191204063240.GJ1787@kadam> (raw)
In-Reply-To: <20191204063058.GE1765@kadam>
On Wed, Dec 04, 2019 at 09:30:58AM +0300, Dan Carpenter wrote:
> On Wed, Dec 04, 2019 at 09:05:06AM +0800, Mao Wenan wrote:
> > There is no need to have the 'T *v' variable static
> > since new value always be assigned before use it.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Mao Wenan <maowenan@huawei.com>
> > ---
> > drivers/power/supply/ab8500_btemp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c
> > index 909f0242bacb..d3d4f7327d1b 100644
> > --- a/drivers/power/supply/ab8500_btemp.c
> > +++ b/drivers/power/supply/ab8500_btemp.c
> > @@ -180,7 +180,7 @@ static int ab8500_btemp_batctrl_volt_to_res(struct ab8500_btemp *di,
> > static int ab8500_btemp_read_batctrl_voltage(struct ab8500_btemp *di)
> > {
> > int vbtemp, ret;
> > - static int prev;
> > + int prev;
>
> No. We use it first on linux-next (yesterday). It needs to be static.
>
It's surprising that your patch didn't cause an uninitialized variable
compile warning for you.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: sre@kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] power: supply: ab8500: Drop pointless static qualifier in ab8500_btemp_batctrl_volt_to_res()
Date: Wed, 4 Dec 2019 09:32:40 +0300 [thread overview]
Message-ID: <20191204063240.GJ1787@kadam> (raw)
In-Reply-To: <20191204063058.GE1765@kadam>
On Wed, Dec 04, 2019 at 09:30:58AM +0300, Dan Carpenter wrote:
> On Wed, Dec 04, 2019 at 09:05:06AM +0800, Mao Wenan wrote:
> > There is no need to have the 'T *v' variable static
> > since new value always be assigned before use it.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Mao Wenan <maowenan@huawei.com>
> > ---
> > drivers/power/supply/ab8500_btemp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/ab8500_btemp.c b/drivers/power/supply/ab8500_btemp.c
> > index 909f0242bacb..d3d4f7327d1b 100644
> > --- a/drivers/power/supply/ab8500_btemp.c
> > +++ b/drivers/power/supply/ab8500_btemp.c
> > @@ -180,7 +180,7 @@ static int ab8500_btemp_batctrl_volt_to_res(struct ab8500_btemp *di,
> > static int ab8500_btemp_read_batctrl_voltage(struct ab8500_btemp *di)
> > {
> > int vbtemp, ret;
> > - static int prev;
> > + int prev;
>
> No. We use it first on linux-next (yesterday). It needs to be static.
>
It's surprising that your patch didn't cause an uninitialized variable
compile warning for you.
regards,
dan carpenter
next prev parent reply other threads:[~2019-12-04 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 1:05 [PATCH -next] power: supply: ab8500: Drop pointless static qualifier in ab8500_btemp_batctrl_volt_to Mao Wenan
2019-12-04 1:05 ` [PATCH -next] power: supply: ab8500: Drop pointless static qualifier in ab8500_btemp_batctrl_volt_to_res() Mao Wenan
2019-12-04 6:30 ` [PATCH -next] power: supply: ab8500: Drop pointless static qualifier in ab8500_btemp_batctrl_vol Dan Carpenter
2019-12-04 6:30 ` [PATCH -next] power: supply: ab8500: Drop pointless static qualifier in ab8500_btemp_batctrl_volt_to_res() Dan Carpenter
2019-12-04 6:32 ` Dan Carpenter [this message]
2019-12-04 6:32 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204063240.GJ1787@kadam \
--to=dan.carpenter@oracle.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.