From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, sean.wang@mediatek.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
Date: Wed, 04 Dec 2019 06:35:28 +0000 [thread overview]
Message-ID: <20191204063444.GF1765@kadam> (raw)
In-Reply-To: <20191204020209.10363-1-maowenan@huawei.com>
On Wed, Dec 04, 2019 at 10:02:09AM +0800, Mao Wenan wrote:
> rtc->irq is requested by devm_request_threaded_irq,
> and request_threaded_irq. IRQs requested with this
> function will be automatically freed on driver detach.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/rtc/rtc-mt6397.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 5249fc99fd5f..d6a10111137a 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
> return 0;
>
> out_free_irq:
> - free_irq(rtc->irq, rtc);
> return ret;
Please get rid of the error label as well.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, sean.wang@mediatek.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
Date: Wed, 4 Dec 2019 09:35:28 +0300 [thread overview]
Message-ID: <20191204063444.GF1765@kadam> (raw)
In-Reply-To: <20191204020209.10363-1-maowenan@huawei.com>
On Wed, Dec 04, 2019 at 10:02:09AM +0800, Mao Wenan wrote:
> rtc->irq is requested by devm_request_threaded_irq,
> and request_threaded_irq. IRQs requested with this
> function will be automatically freed on driver detach.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/rtc/rtc-mt6397.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 5249fc99fd5f..d6a10111137a 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
> return 0;
>
> out_free_irq:
> - free_irq(rtc->irq, rtc);
> return ret;
Please get rid of the error label as well.
regards,
dan carpenter
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: eddie.huang@mediatek.com, sean.wang@mediatek.com,
a.zummo@towertech.it, alexandre.belloni@bootlin.com,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
Date: Wed, 4 Dec 2019 09:35:28 +0300 [thread overview]
Message-ID: <20191204063444.GF1765@kadam> (raw)
In-Reply-To: <20191204020209.10363-1-maowenan@huawei.com>
On Wed, Dec 04, 2019 at 10:02:09AM +0800, Mao Wenan wrote:
> rtc->irq is requested by devm_request_threaded_irq,
> and request_threaded_irq. IRQs requested with this
> function will be automatically freed on driver detach.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/rtc/rtc-mt6397.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 5249fc99fd5f..d6a10111137a 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
> return 0;
>
> out_free_irq:
> - free_irq(rtc->irq, rtc);
> return ret;
Please get rid of the error label as well.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: linux-rtc@vger.kernel.org, a.zummo@towertech.it,
alexandre.belloni@bootlin.com, sean.wang@mediatek.com,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>,
linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com,
eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] rtc: mt6397: drop free_irq of devm_xx allocated irq
Date: Wed, 4 Dec 2019 09:35:28 +0300 [thread overview]
Message-ID: <20191204063444.GF1765@kadam> (raw)
In-Reply-To: <20191204020209.10363-1-maowenan@huawei.com>
On Wed, Dec 04, 2019 at 10:02:09AM +0800, Mao Wenan wrote:
> rtc->irq is requested by devm_request_threaded_irq,
> and request_threaded_irq. IRQs requested with this
> function will be automatically freed on driver detach.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> drivers/rtc/rtc-mt6397.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 5249fc99fd5f..d6a10111137a 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -293,7 +293,6 @@ static int mtk_rtc_probe(struct platform_device *pdev)
> return 0;
>
> out_free_irq:
> - free_irq(rtc->irq, rtc);
> return ret;
Please get rid of the error label as well.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-04 6:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 2:17 [PATCH -next] rtc: mt6397: drop free_irq of devm_ allocated irq Wei Yongjun
2019-11-13 2:17 ` Wei Yongjun
2019-11-13 2:17 ` Wei Yongjun
2019-11-13 2:17 ` Wei Yongjun
2019-12-04 2:02 ` [PATCH -next] rtc: mt6397: drop free_irq of devm_xx " Mao Wenan
2019-12-04 2:02 ` Mao Wenan
2019-12-04 2:02 ` Mao Wenan
2019-12-04 2:02 ` Mao Wenan
2019-12-04 6:35 ` Dan Carpenter [this message]
2019-12-04 6:35 ` Dan Carpenter
2019-12-04 6:35 ` Dan Carpenter
2019-12-04 6:35 ` Dan Carpenter
2019-12-04 7:28 ` [PATCH v2 " Mao Wenan
2019-12-04 7:28 ` Mao Wenan
2019-12-04 7:28 ` Mao Wenan
2019-12-04 7:28 ` Mao Wenan
2019-12-04 8:40 ` Alexandre Belloni
2019-12-04 8:40 ` Alexandre Belloni
2019-12-04 8:40 ` Alexandre Belloni
2019-12-04 8:40 ` Alexandre Belloni
2019-12-04 8:42 ` Alexandre Belloni
2019-12-04 8:42 ` Alexandre Belloni
2019-12-04 8:42 ` Alexandre Belloni
2019-12-04 8:42 ` Alexandre Belloni
2019-12-10 15:44 ` [PATCH -next] rtc: mt6397: drop free_irq of devm_ " Alexandre Belloni
2019-12-10 15:44 ` Alexandre Belloni
2019-12-10 15:44 ` Alexandre Belloni
2019-12-10 15:44 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204063444.GF1765@kadam \
--to=dan.carpenter@oracle.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=eddie.huang@mediatek.com \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=maowenan@huawei.com \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.