* [Linux-kernel-mentees] [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers @ 2019-12-04 12:03 ` madhuparnabhowmik04 0 siblings, 0 replies; 9+ messages in thread From: madhuparnabhowmik04 @ 2019-12-04 12:03 UTC (permalink / raw) To: paulmck, joel; +Cc: rcu, linux-kernel-mentees, linux-kernel From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> This patch adds docbook comment headers for hlist_nulls_first_rcu and hlist_nulls_next_rcu in rculist_nulls.h. Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> --- include/linux/rculist_nulls.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h index 517a06f36c7a..d796ef18ec52 100644 --- a/include/linux/rculist_nulls.h +++ b/include/linux/rculist_nulls.h @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct hlist_nulls_node *n) } } +/** + * hlist_nulls_first_rcu - returns the first element of the hash list. + * @head: the head for your list. + */ #define hlist_nulls_first_rcu(head) \ (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) +/** + * hlist_nulls_next_rcu - returns the element of the list next to @node. + * @node: Element of the list. + */ #define hlist_nulls_next_rcu(node) \ (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) -- 2.17.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers @ 2019-12-04 12:03 ` madhuparnabhowmik04 0 siblings, 0 replies; 9+ messages in thread From: madhuparnabhowmik04 @ 2019-12-04 12:03 UTC (permalink / raw) To: paulmck, joel; +Cc: rcu, linux-kernel, linux-kernel-mentees, Madhuparna Bhowmik From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> This patch adds docbook comment headers for hlist_nulls_first_rcu and hlist_nulls_next_rcu in rculist_nulls.h. Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> --- include/linux/rculist_nulls.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h index 517a06f36c7a..d796ef18ec52 100644 --- a/include/linux/rculist_nulls.h +++ b/include/linux/rculist_nulls.h @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct hlist_nulls_node *n) } } +/** + * hlist_nulls_first_rcu - returns the first element of the hash list. + * @head: the head for your list. + */ #define hlist_nulls_first_rcu(head) \ (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) +/** + * hlist_nulls_next_rcu - returns the element of the list next to @node. + * @node: Element of the list. + */ #define hlist_nulls_next_rcu(node) \ (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) -- 2.17.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers 2019-12-04 12:03 ` madhuparnabhowmik04 @ 2019-12-04 17:44 ` Joel Fernandes -1 siblings, 0 replies; 9+ messages in thread From: Joel Fernandes @ 2019-12-04 17:44 UTC (permalink / raw) To: madhuparnabhowmik04; +Cc: rcu, linux-kernel-mentees, linux-kernel, paulmck On Wed, Dec 04, 2019 at 05:33:57PM +0530, madhuparnabhowmik04@gmail.com wrote: > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > This patch adds docbook comment headers for hlist_nulls_first_rcu > and hlist_nulls_next_rcu in rculist_nulls.h. > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> Thanks. Could you send this to the list? I'd like Paul to review or apply this one. - Joel > --- > include/linux/rculist_nulls.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h > index 517a06f36c7a..d796ef18ec52 100644 > --- a/include/linux/rculist_nulls.h > +++ b/include/linux/rculist_nulls.h > @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct hlist_nulls_node *n) > } > } > > +/** > + * hlist_nulls_first_rcu - returns the first element of the hash list. > + * @head: the head for your list. > + */ > #define hlist_nulls_first_rcu(head) \ > (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > +/** > + * hlist_nulls_next_rcu - returns the element of the list next to @node. > + * @node: Element of the list. > + */ > #define hlist_nulls_next_rcu(node) \ > (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) > > -- > 2.17.1 > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers @ 2019-12-04 17:44 ` Joel Fernandes 0 siblings, 0 replies; 9+ messages in thread From: Joel Fernandes @ 2019-12-04 17:44 UTC (permalink / raw) To: madhuparnabhowmik04; +Cc: paulmck, rcu, linux-kernel, linux-kernel-mentees On Wed, Dec 04, 2019 at 05:33:57PM +0530, madhuparnabhowmik04@gmail.com wrote: > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > This patch adds docbook comment headers for hlist_nulls_first_rcu > and hlist_nulls_next_rcu in rculist_nulls.h. > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> Thanks. Could you send this to the list? I'd like Paul to review or apply this one. - Joel > --- > include/linux/rculist_nulls.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h > index 517a06f36c7a..d796ef18ec52 100644 > --- a/include/linux/rculist_nulls.h > +++ b/include/linux/rculist_nulls.h > @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct hlist_nulls_node *n) > } > } > > +/** > + * hlist_nulls_first_rcu - returns the first element of the hash list. > + * @head: the head for your list. > + */ > #define hlist_nulls_first_rcu(head) \ > (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > +/** > + * hlist_nulls_next_rcu - returns the element of the list next to @node. > + * @node: Element of the list. > + */ > #define hlist_nulls_next_rcu(node) \ > (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) > > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers 2019-12-04 12:03 ` madhuparnabhowmik04 @ 2019-12-05 0:25 ` Paul E. McKenney -1 siblings, 0 replies; 9+ messages in thread From: Paul E. McKenney @ 2019-12-05 0:25 UTC (permalink / raw) To: madhuparnabhowmik04; +Cc: joel, rcu, linux-kernel-mentees, linux-kernel On Wed, Dec 04, 2019 at 05:33:57PM +0530, madhuparnabhowmik04@gmail.com wrote: > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > This patch adds docbook comment headers for hlist_nulls_first_rcu > and hlist_nulls_next_rcu in rculist_nulls.h. > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > --- Good to see, thank you! A few grammar nits below -- could you please update and re-send? Thanx, Paul > include/linux/rculist_nulls.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h > index 517a06f36c7a..d796ef18ec52 100644 > --- a/include/linux/rculist_nulls.h > +++ b/include/linux/rculist_nulls.h > @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct hlist_nulls_node *n) > } > } > > +/** > + * hlist_nulls_first_rcu - returns the first element of the hash list. > + * @head: the head for your list. Could you please say something like "The head of the list."? Just to keep point of view more consistent through the documentation. > + */ > #define hlist_nulls_first_rcu(head) \ > (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > +/** > + * hlist_nulls_next_rcu - returns the element of the list next to @node. Here, could you please change "next to" to "after"? This removes the ambiguity where both the prior and the subsequent elements might be thought of as "next to". > + * @node: Element of the list. > + */ > #define hlist_nulls_next_rcu(node) \ > (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) > > -- > 2.17.1 > _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers @ 2019-12-05 0:25 ` Paul E. McKenney 0 siblings, 0 replies; 9+ messages in thread From: Paul E. McKenney @ 2019-12-05 0:25 UTC (permalink / raw) To: madhuparnabhowmik04; +Cc: joel, rcu, linux-kernel, linux-kernel-mentees On Wed, Dec 04, 2019 at 05:33:57PM +0530, madhuparnabhowmik04@gmail.com wrote: > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > This patch adds docbook comment headers for hlist_nulls_first_rcu > and hlist_nulls_next_rcu in rculist_nulls.h. > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > --- Good to see, thank you! A few grammar nits below -- could you please update and re-send? Thanx, Paul > include/linux/rculist_nulls.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h > index 517a06f36c7a..d796ef18ec52 100644 > --- a/include/linux/rculist_nulls.h > +++ b/include/linux/rculist_nulls.h > @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct hlist_nulls_node *n) > } > } > > +/** > + * hlist_nulls_first_rcu - returns the first element of the hash list. > + * @head: the head for your list. Could you please say something like "The head of the list."? Just to keep point of view more consistent through the documentation. > + */ > #define hlist_nulls_first_rcu(head) \ > (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > +/** > + * hlist_nulls_next_rcu - returns the element of the list next to @node. Here, could you please change "next to" to "after"? This removes the ambiguity where both the prior and the subsequent elements might be thought of as "next to". > + * @node: Element of the list. > + */ > #define hlist_nulls_next_rcu(node) \ > (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) > > -- > 2.17.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers 2019-12-05 0:25 ` Paul E. McKenney (?) @ 2019-12-05 5:55 ` Madhuparna Bhowmik 2019-12-05 14:42 ` Paul E. McKenney -1 siblings, 1 reply; 9+ messages in thread From: Madhuparna Bhowmik @ 2019-12-05 5:55 UTC (permalink / raw) To: paulmck; +Cc: Joel Fernandes, rcu, linux-kernel-mentees, linux-kernel [-- Attachment #1.1: Type: text/plain, Size: 2315 bytes --] On Thu, Dec 5, 2019 at 5:55 AM Paul E. McKenney <paulmck@kernel.org> wrote: > On Wed, Dec 04, 2019 at 05:33:57PM +0530, madhuparnabhowmik04@gmail.com > wrote: > > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > > > This patch adds docbook comment headers for hlist_nulls_first_rcu > > and hlist_nulls_next_rcu in rculist_nulls.h. > > > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > --- > > Good to see, thank you! A few grammar nits below -- could you please > update and re-send? > > Thank you, I will send the updated patch soon. > Thanx, Paul > > > include/linux/rculist_nulls.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/include/linux/rculist_nulls.h > b/include/linux/rculist_nulls.h > > index 517a06f36c7a..d796ef18ec52 100644 > > --- a/include/linux/rculist_nulls.h > > +++ b/include/linux/rculist_nulls.h > > @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct > hlist_nulls_node *n) > > } > > } > > > > +/** > > + * hlist_nulls_first_rcu - returns the first element of the hash list. > > + * @head: the head for your list. > > Could you please say something like "The head of the list."? > Just to keep point of view more consistent through the documentation. > > Sure, I will change it to "head of the list". Moreover, in the rest of the docbook comments in the same file (rculist_nulls.h), "head for your list" is used. So, should I change that as well in a separate patch, such that it is consistent throughout the file? > > + */ > > #define hlist_nulls_first_rcu(head) \ > > (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > > > +/** > > + * hlist_nulls_next_rcu - returns the element of the list next to @node. > > Here, could you please change "next to" to "after"? This removes the > ambiguity where both the prior and the subsequent elements might be > thought of as "next to". > > Sure, I will do it. Thank you for pointing out. Regards, Madhuparna > > + * @node: Element of the list. > > + */ > > #define hlist_nulls_next_rcu(node) \ > > (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) > > > > -- > > 2.17.1 > > > ᐧ [-- Attachment #1.2: Type: text/html, Size: 3990 bytes --] [-- Attachment #2: Type: text/plain, Size: 201 bytes --] _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers 2019-12-05 5:55 ` [Linux-kernel-mentees] " Madhuparna Bhowmik @ 2019-12-05 14:42 ` Paul E. McKenney 0 siblings, 0 replies; 9+ messages in thread From: Paul E. McKenney @ 2019-12-05 14:42 UTC (permalink / raw) To: Madhuparna Bhowmik Cc: Joel Fernandes, rcu, linux-kernel-mentees, linux-kernel On Thu, Dec 05, 2019 at 11:25:39AM +0530, Madhuparna Bhowmik wrote: > On Thu, Dec 5, 2019 at 5:55 AM Paul E. McKenney <paulmck@kernel.org> wrote: > > > On Wed, Dec 04, 2019 at 05:33:57PM +0530, madhuparnabhowmik04@gmail.com > > wrote: > > > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > > > > > This patch adds docbook comment headers for hlist_nulls_first_rcu > > > and hlist_nulls_next_rcu in rculist_nulls.h. > > > > > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > > --- > > > > Good to see, thank you! A few grammar nits below -- could you please > > update and re-send? > > > > Thank you, I will send the updated patch soon. > > > > Thanx, Paul > > > > > include/linux/rculist_nulls.h | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/include/linux/rculist_nulls.h > > b/include/linux/rculist_nulls.h > > > index 517a06f36c7a..d796ef18ec52 100644 > > > --- a/include/linux/rculist_nulls.h > > > +++ b/include/linux/rculist_nulls.h > > > @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct > > hlist_nulls_node *n) > > > } > > > } > > > > > > +/** > > > + * hlist_nulls_first_rcu - returns the first element of the hash list. > > > + * @head: the head for your list. > > > > Could you please say something like "The head of the list."? > > Just to keep point of view more consistent through the documentation. > > > > Sure, I will change it to "head of the list". > Moreover, in the rest of the docbook comments in the same file > (rculist_nulls.h), "head for your list" is used. > So, should I change that as well in a separate patch, such that it is > consistent throughout the file? Please do! Thanx, Paul > > > + */ > > > #define hlist_nulls_first_rcu(head) \ > > > (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > > > > > +/** > > > + * hlist_nulls_next_rcu - returns the element of the list next to @node. > > > > Here, could you please change "next to" to "after"? This removes the > > ambiguity where both the prior and the subsequent elements might be > > thought of as "next to". > > > > Sure, I will do it. Thank you for pointing out. > > Regards, > Madhuparna > > > > > + * @node: Element of the list. > > > + */ > > > #define hlist_nulls_next_rcu(node) \ > > > (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) > > > > > > -- > > > 2.17.1 > > > > > > ᐧ _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers @ 2019-12-05 14:42 ` Paul E. McKenney 0 siblings, 0 replies; 9+ messages in thread From: Paul E. McKenney @ 2019-12-05 14:42 UTC (permalink / raw) To: Madhuparna Bhowmik Cc: Joel Fernandes, rcu, linux-kernel, linux-kernel-mentees On Thu, Dec 05, 2019 at 11:25:39AM +0530, Madhuparna Bhowmik wrote: > On Thu, Dec 5, 2019 at 5:55 AM Paul E. McKenney <paulmck@kernel.org> wrote: > > > On Wed, Dec 04, 2019 at 05:33:57PM +0530, madhuparnabhowmik04@gmail.com > > wrote: > > > From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > > > > > This patch adds docbook comment headers for hlist_nulls_first_rcu > > > and hlist_nulls_next_rcu in rculist_nulls.h. > > > > > > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com> > > > --- > > > > Good to see, thank you! A few grammar nits below -- could you please > > update and re-send? > > > > Thank you, I will send the updated patch soon. > > > > Thanx, Paul > > > > > include/linux/rculist_nulls.h | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/include/linux/rculist_nulls.h > > b/include/linux/rculist_nulls.h > > > index 517a06f36c7a..d796ef18ec52 100644 > > > --- a/include/linux/rculist_nulls.h > > > +++ b/include/linux/rculist_nulls.h > > > @@ -38,9 +38,17 @@ static inline void hlist_nulls_del_init_rcu(struct > > hlist_nulls_node *n) > > > } > > > } > > > > > > +/** > > > + * hlist_nulls_first_rcu - returns the first element of the hash list. > > > + * @head: the head for your list. > > > > Could you please say something like "The head of the list."? > > Just to keep point of view more consistent through the documentation. > > > > Sure, I will change it to "head of the list". > Moreover, in the rest of the docbook comments in the same file > (rculist_nulls.h), "head for your list" is used. > So, should I change that as well in a separate patch, such that it is > consistent throughout the file? Please do! Thanx, Paul > > > + */ > > > #define hlist_nulls_first_rcu(head) \ > > > (*((struct hlist_nulls_node __rcu __force **)&(head)->first)) > > > > > > +/** > > > + * hlist_nulls_next_rcu - returns the element of the list next to @node. > > > > Here, could you please change "next to" to "after"? This removes the > > ambiguity where both the prior and the subsequent elements might be > > thought of as "next to". > > > > Sure, I will do it. Thank you for pointing out. > > Regards, > Madhuparna > > > > > + * @node: Element of the list. > > > + */ > > > #define hlist_nulls_next_rcu(node) \ > > > (*((struct hlist_nulls_node __rcu __force **)&(node)->next)) > > > > > > -- > > > 2.17.1 > > > > > > ᐧ ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-12-05 14:42 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-12-04 12:03 [Linux-kernel-mentees] [PATCH] Include: Linux: rculist_nulls: Add docbook comment headers madhuparnabhowmik04 2019-12-04 12:03 ` madhuparnabhowmik04 2019-12-04 17:44 ` [Linux-kernel-mentees] " Joel Fernandes 2019-12-04 17:44 ` Joel Fernandes 2019-12-05 0:25 ` [Linux-kernel-mentees] " Paul E. McKenney 2019-12-05 0:25 ` Paul E. McKenney 2019-12-05 5:55 ` [Linux-kernel-mentees] " Madhuparna Bhowmik 2019-12-05 14:42 ` Paul E. McKenney 2019-12-05 14:42 ` Paul E. McKenney
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.