* Re: [efi:urgent 6/6] drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int'
[not found] <201912060234.8XYvgYSn%lkp@intel.com>
@ 2019-12-05 19:12 ` Nick Desaulniers
2019-12-05 19:50 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Nick Desaulniers @ 2019-12-05 19:12 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2833 bytes --]
+ Andy, looks legit. should be `return 0`.
On Thu, Dec 5, 2019 at 10:39 AM kbuild test robot <lkp@intel.com> wrote:
>
> CC: kbuild-all(a)lists.01.org
> CC: linux-efi(a)vger.kernel.org
> TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> CC: Ard Biesheuvel <ardb@kernel.org>
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git urgent
> head: 93afe6258b5ae6bd32981f5249f7b0c1a32cde01
> commit: 93afe6258b5ae6bd32981f5249f7b0c1a32cde01 [6/6] efi/earlycon: Remap entire framebuffer after page initialization
> config: arm64-defconfig (attached as .config)
> compiler: clang version 10.0.0 (git://gitmirror/llvm_project d6cbc9528d46d30416a6f9cd6c8570b704a0bd33)
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 93afe6258b5ae6bd32981f5249f7b0c1a32cde01
> # save the attached .config to linux build tree
> make.cross ARCH=arm64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
> return NULL;
> ^~~~
> include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> #define NULL ((void *)0)
> ^~~~~~~~~~~
> 1 warning generated.
>
> vim +33 drivers/firmware/efi/earlycon.c
>
> 22
> 23 /*
> 24 * efi earlycon needs to use early_memremap() to map the framebuffer.
> 25 * But early_memremap() is not usable for 'earlycon=efifb keep_bootcon',
> 26 * memremap() should be used instead. memremap() will be available after
> 27 * paging_init() which is earlier than initcall callbacks. Thus adding this
> 28 * early initcall function early_efi_map_fb() to map the whole efi framebuffer.
> 29 */
> 30 static int __init early_efi_map_fb(void)
> 31 {
> 32 if (!fb_base || !fb_size)
> > 33 return NULL;
> 34
> 35 if (pgprot_val(fb_prot) == pgprot_val(PAGE_KERNEL))
> 36 efi_fb = memremap(fb_base, fb_size, MEMREMAP_WB);
> 37 else
> 38 efi_fb = memremap(fb_base, fb_size, MEMREMAP_WC);
> 39
> 40 return efi_fb ? 0 : -ENOMEM;
> 41 }
> 42 early_initcall(early_efi_map_fb);
> 43
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [efi:urgent 6/6] drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int'
2019-12-05 19:12 ` [efi:urgent 6/6] drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' Nick Desaulniers
@ 2019-12-05 19:50 ` Andy Shevchenko
2019-12-05 19:56 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2019-12-05 19:50 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3144 bytes --]
On Thu, Dec 05, 2019 at 11:12:34AM -0800, Nick Desaulniers wrote:
> + Andy, looks legit. should be `return 0`.
Thanks, Ard promised to fix this.
Dunno what happen here.
> On Thu, Dec 5, 2019 at 10:39 AM kbuild test robot <lkp@intel.com> wrote:
> >
> > CC: kbuild-all(a)lists.01.org
> > CC: linux-efi(a)vger.kernel.org
> > TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > CC: Ard Biesheuvel <ardb@kernel.org>
> >
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git urgent
> > head: 93afe6258b5ae6bd32981f5249f7b0c1a32cde01
> > commit: 93afe6258b5ae6bd32981f5249f7b0c1a32cde01 [6/6] efi/earlycon: Remap entire framebuffer after page initialization
> > config: arm64-defconfig (attached as .config)
> > compiler: clang version 10.0.0 (git://gitmirror/llvm_project d6cbc9528d46d30416a6f9cd6c8570b704a0bd33)
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > git checkout 93afe6258b5ae6bd32981f5249f7b0c1a32cde01
> > # save the attached .config to linux build tree
> > make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
> > return NULL;
> > ^~~~
> > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> > #define NULL ((void *)0)
> > ^~~~~~~~~~~
> > 1 warning generated.
> >
> > vim +33 drivers/firmware/efi/earlycon.c
> >
> > 22
> > 23 /*
> > 24 * efi earlycon needs to use early_memremap() to map the framebuffer.
> > 25 * But early_memremap() is not usable for 'earlycon=efifb keep_bootcon',
> > 26 * memremap() should be used instead. memremap() will be available after
> > 27 * paging_init() which is earlier than initcall callbacks. Thus adding this
> > 28 * early initcall function early_efi_map_fb() to map the whole efi framebuffer.
> > 29 */
> > 30 static int __init early_efi_map_fb(void)
> > 31 {
> > 32 if (!fb_base || !fb_size)
> > > 33 return NULL;
> > 34
> > 35 if (pgprot_val(fb_prot) == pgprot_val(PAGE_KERNEL))
> > 36 efi_fb = memremap(fb_base, fb_size, MEMREMAP_WB);
> > 37 else
> > 38 efi_fb = memremap(fb_base, fb_size, MEMREMAP_WC);
> > 39
> > 40 return efi_fb ? 0 : -ENOMEM;
> > 41 }
> > 42 early_initcall(early_efi_map_fb);
> > 43
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source Technology Center
> > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
>
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [efi:urgent 6/6] drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int'
2019-12-05 19:50 ` Andy Shevchenko
@ 2019-12-05 19:56 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2019-12-05 19:56 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3455 bytes --]
On Thu, 5 Dec 2019 at 19:51, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Thu, Dec 05, 2019 at 11:12:34AM -0800, Nick Desaulniers wrote:
> > + Andy, looks legit. should be `return 0`.
>
> Thanks, Ard promised to fix this.
> Dunno what happen here.
>
Yeah, this is outdated already, and fixed in the latest version.
> > On Thu, Dec 5, 2019 at 10:39 AM kbuild test robot <lkp@intel.com> wrote:
> > >
> > > CC: kbuild-all(a)lists.01.org
> > > CC: linux-efi(a)vger.kernel.org
> > > TO: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > CC: Ard Biesheuvel <ardb@kernel.org>
> > >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/efi/efi.git urgent
> > > head: 93afe6258b5ae6bd32981f5249f7b0c1a32cde01
> > > commit: 93afe6258b5ae6bd32981f5249f7b0c1a32cde01 [6/6] efi/earlycon: Remap entire framebuffer after page initialization
> > > config: arm64-defconfig (attached as .config)
> > > compiler: clang version 10.0.0 (git://gitmirror/llvm_project d6cbc9528d46d30416a6f9cd6c8570b704a0bd33)
> > > reproduce:
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > git checkout 93afe6258b5ae6bd32981f5249f7b0c1a32cde01
> > > # save the attached .config to linux build tree
> > > make.cross ARCH=arm64
> > >
> > > If you fix the issue, kindly add following tag
> > > Reported-by: kbuild test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' [-Wint-conversion]
> > > return NULL;
> > > ^~~~
> > > include/linux/stddef.h:8:14: note: expanded from macro 'NULL'
> > > #define NULL ((void *)0)
> > > ^~~~~~~~~~~
> > > 1 warning generated.
> > >
> > > vim +33 drivers/firmware/efi/earlycon.c
> > >
> > > 22
> > > 23 /*
> > > 24 * efi earlycon needs to use early_memremap() to map the framebuffer.
> > > 25 * But early_memremap() is not usable for 'earlycon=efifb keep_bootcon',
> > > 26 * memremap() should be used instead. memremap() will be available after
> > > 27 * paging_init() which is earlier than initcall callbacks. Thus adding this
> > > 28 * early initcall function early_efi_map_fb() to map the whole efi framebuffer.
> > > 29 */
> > > 30 static int __init early_efi_map_fb(void)
> > > 31 {
> > > 32 if (!fb_base || !fb_size)
> > > > 33 return NULL;
> > > 34
> > > 35 if (pgprot_val(fb_prot) == pgprot_val(PAGE_KERNEL))
> > > 36 efi_fb = memremap(fb_base, fb_size, MEMREMAP_WB);
> > > 37 else
> > > 38 efi_fb = memremap(fb_base, fb_size, MEMREMAP_WC);
> > > 39
> > > 40 return efi_fb ? 0 : -ENOMEM;
> > > 41 }
> > > 42 early_initcall(early_efi_map_fb);
> > > 43
> > >
> > > ---
> > > 0-DAY kernel test infrastructure Open Source Technology Center
> > > https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
> >
> >
> >
> > --
> > Thanks,
> > ~Nick Desaulniers
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-05 19:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201912060234.8XYvgYSn%lkp@intel.com>
2019-12-05 19:12 ` [efi:urgent 6/6] drivers/firmware/efi/earlycon.c:33:10: warning: incompatible pointer to integer conversion returning 'void *' from a function with result type 'int' Nick Desaulniers
2019-12-05 19:50 ` Andy Shevchenko
2019-12-05 19:56 ` Ard Biesheuvel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.