From: Michael Weiser <michael@weiser.dinsnail.net>
To: Dave Young <dyoung@redhat.com>
Cc: linux-efi@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] x86/efi: update e820 about reserved EFI boot services data to fix kexec breakage
Date: Thu, 5 Dec 2019 22:15:32 +0100 [thread overview]
Message-ID: <20191205211532.GA10177@weiser.dinsnail.net> (raw)
In-Reply-To: <20191205105545.GA6710@dhcp-128-65.nay.redhat.com>
On Thu, Dec 05, 2019 at 06:55:45PM +0800, Dave Young wrote:
> > esrt: Unsupported ESRT version 2904149718861218184.
> >
> > The ESRT memory stays in EFI boot services data, and it was reserved
> > in kernel via efi_mem_reserve(). The initial purpose of the reservation
> > is to reuse the EFI boot services data across kexec reboot. For example
> > the BGRT image data and some ESRT memory like Michael reported.
> >
> > But although the memory is reserved it is not updated in the X86 E820 table,
> > and kexec_file_load() iterates system RAM in the IO resource list to find places
> > for kernel, initramfs and other stuff. In Michael's case the kexec loaded
> > initramfs overwrote the ESRT memory and then the failure happened.
> >
> > Since kexec_file_load() depends on the E820 table being updated, just fix this
> > by updating the reserved EFI boot services memory as reserved type in E820.
> Thanks for the amending, also thank all for the review and test.
Same from me, particularly everyone's patience with my haphazard
guesswork around an area I clearly know nothing about. :)
--
Thanks,
Michael
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Michael Weiser <michael@weiser.dinsnail.net>
To: Dave Young <dyoung@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-efi@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
kexec@lists.infradead.org, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86/efi: update e820 about reserved EFI boot services data to fix kexec breakage
Date: Thu, 5 Dec 2019 22:15:32 +0100 [thread overview]
Message-ID: <20191205211532.GA10177@weiser.dinsnail.net> (raw)
In-Reply-To: <20191205105545.GA6710@dhcp-128-65.nay.redhat.com>
On Thu, Dec 05, 2019 at 06:55:45PM +0800, Dave Young wrote:
> > esrt: Unsupported ESRT version 2904149718861218184.
> >
> > The ESRT memory stays in EFI boot services data, and it was reserved
> > in kernel via efi_mem_reserve(). The initial purpose of the reservation
> > is to reuse the EFI boot services data across kexec reboot. For example
> > the BGRT image data and some ESRT memory like Michael reported.
> >
> > But although the memory is reserved it is not updated in the X86 E820 table,
> > and kexec_file_load() iterates system RAM in the IO resource list to find places
> > for kernel, initramfs and other stuff. In Michael's case the kexec loaded
> > initramfs overwrote the ESRT memory and then the failure happened.
> >
> > Since kexec_file_load() depends on the E820 table being updated, just fix this
> > by updating the reserved EFI boot services memory as reserved type in E820.
> Thanks for the amending, also thank all for the review and test.
Same from me, particularly everyone's patience with my haphazard
guesswork around an area I clearly know nothing about. :)
--
Thanks,
Michael
next prev parent reply other threads:[~2019-12-05 21:30 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 7:52 [PATCH] x86/efi: update e820 about reserved EFI boot services data to fix kexec breakage Dave Young
2019-12-04 7:52 ` Dave Young
2019-12-04 7:59 ` Dave Young
2019-12-04 7:59 ` Dave Young
2019-12-04 10:09 ` Ingo Molnar
2019-12-04 10:09 ` Ingo Molnar
2019-12-04 10:14 ` Ingo Molnar
2019-12-04 10:14 ` Ingo Molnar
2019-12-04 10:24 ` Ard Biesheuvel
2019-12-04 10:24 ` Ard Biesheuvel
2019-12-05 10:55 ` Dave Young
2019-12-05 10:55 ` Dave Young
2019-12-05 21:15 ` Michael Weiser [this message]
2019-12-05 21:15 ` Michael Weiser
2019-12-04 11:31 ` Michael Weiser
2019-12-04 11:31 ` Michael Weiser
2019-12-04 10:21 ` [tip: x86/urgent] x86/efi: Update e820 with " tip-bot2 for Dave Young
2019-12-04 10:21 ` tip-bot2 for Dave Young
2019-12-28 20:54 ` [PATCH] x86/efi: update e820 about " Dan Williams
2019-12-28 20:54 ` Dan Williams
2019-12-29 6:13 ` Dan Williams
2019-12-29 6:13 ` Dan Williams
2019-12-29 14:24 ` Dave Young
2019-12-29 14:24 ` Dave Young
2019-12-30 3:32 ` Dave Young
2019-12-30 3:32 ` Dave Young
2019-12-30 5:55 ` Dave Young
2019-12-30 5:55 ` Dave Young
2019-12-30 9:42 ` Dan Williams
2019-12-30 9:42 ` Dan Williams
2019-12-30 10:49 ` Dave Young
2019-12-30 10:49 ` Dave Young
2019-12-30 20:16 ` Dan Williams
2019-12-30 20:16 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205211532.GA10177@weiser.dinsnail.net \
--to=michael@weiser.dinsnail.net \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.