All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bruce Ashfield" <bruce.ashfield@gmail.com>
To: Hongxu Jia <hongxu.jia@windriver.com>
Cc: meta-virtualization@lists.yoctoproject.org
Subject: Re: [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13
Date: Fri, 6 Dec 2019 14:07:05 -0500	[thread overview]
Message-ID: <20191206190701.GA37280@gmail.com> (raw)
In-Reply-To: <20191202084949.21918-1-hongxu.jia@windriver.com>

In message: [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13
on 02/12/2019 Hongxu Jia wrote:

> Since go was upgraded to 1.13, it support for Go modules by default [1],
> but for cni recipe, it uses GOPATH mode which supports offline build

This patch doesn't look like it is against meta-virt master .. we don't
have a cni.inc file.

Can you refresh the patch and resend ?

Bruce

> 
> [1] https://golang.org/cmd/go/#hdr-Module_support
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  recipes-networking/cni/cni.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/recipes-networking/cni/cni.inc b/recipes-networking/cni/cni.inc
> index 6590b27..7e5af04 100644
> --- a/recipes-networking/cni/cni.inc
> +++ b/recipes-networking/cni/cni.inc
> @@ -45,6 +45,7 @@ do_compile() {
>  	ln -sf ../../../../cnitool ${S}/src/import/vendor/github.com/containernetworking/cni/cnitool
>  	ln -sf ${WORKDIR}/plugins ${S}/src/import/vendor/github.com/containernetworking/plugins
>  
> +	export GO111MODULE="off"
>  	export GOPATH="${S}/src/import/.gopath:${S}/src/import/vendor:${STAGING_DIR_TARGET}/${prefix}/local/go"
>  	export CGO_ENABLED="1"
>  
> -- 
> 2.21.0
> 

      reply	other threads:[~2019-12-06 19:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02  8:49 [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13 hongxu
2019-12-06 19:07 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191206190701.GA37280@gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=hongxu.jia@windriver.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.