[meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13

[meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13

[hongxu]

Since go was upgraded to 1.13, it support for Go modules by default [1],
but for cni recipe, it uses GOPATH mode which supports offline build

[1] https://golang.org/cmd/go/#hdr-Module_support

Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
 recipes-networking/cni/cni.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-networking/cni/cni.inc b/recipes-networking/cni/cni.inc
index 6590b27..7e5af04 100644
--- a/recipes-networking/cni/cni.inc
+++ b/recipes-networking/cni/cni.inc
@@ -45,6 +45,7 @@ do_compile() {
 	ln -sf ../../../../cnitool ${S}/src/import/vendor/github.com/containernetworking/cni/cnitool
 	ln -sf ${WORKDIR}/plugins ${S}/src/import/vendor/github.com/containernetworking/plugins
 
+	export GO111MODULE="off"
 	export GOPATH="${S}/src/import/.gopath:${S}/src/import/vendor:${STAGING_DIR_TARGET}/${prefix}/local/go"
 	export CGO_ENABLED="1"
 
-- 
2.21.0

Re: [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13

[Bruce Ashfield]

In message: [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13
on 02/12/2019 Hongxu Jia wrote:

> Since go was upgraded to 1.13, it support for Go modules by default [1],
> but for cni recipe, it uses GOPATH mode which supports offline build

This patch doesn't look like it is against meta-virt master .. we don't
have a cni.inc file.

Can you refresh the patch and resend ?

Bruce

> 
> [1] https://golang.org/cmd/go/#hdr-Module_support
> 
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>  recipes-networking/cni/cni.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/recipes-networking/cni/cni.inc b/recipes-networking/cni/cni.inc
> index 6590b27..7e5af04 100644
> --- a/recipes-networking/cni/cni.inc
> +++ b/recipes-networking/cni/cni.inc
> @@ -45,6 +45,7 @@ do_compile() {
>  	ln -sf ../../../../cnitool ${S}/src/import/vendor/github.com/containernetworking/cni/cnitool
>  	ln -sf ${WORKDIR}/plugins ${S}/src/import/vendor/github.com/containernetworking/plugins
>  
> +	export GO111MODULE="off"
>  	export GOPATH="${S}/src/import/.gopath:${S}/src/import/vendor:${STAGING_DIR_TARGET}/${prefix}/local/go"
>  	export CGO_ENABLED="1"
>  
> -- 
> 2.21.0
>