All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <simon.horman@netronome.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: mark.rutland@arm.com, andrew@lunn.ch, grygorii.strashko@ti.com,
	Scott Branden <sbranden@broadcom.com>,
	devicetree@vger.kernel.org, netdev@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	Eric Anholt <eric@anholt.net>,
	robh+dt@kernel.org, bcm-kernel-feedback-list@broadcom.com,
	Ray Jui <rjui@broadcom.com>,
	rafal@milecki.pl, davem@davemloft.net,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells
Date: Sat, 7 Dec 2019 18:13:34 +0100	[thread overview]
Message-ID: <20191207171333.GD26173@netronome.com> (raw)
In-Reply-To: <20191206181909.10962-1-f.fainelli@gmail.com>

On Fri, Dec 06, 2019 at 10:19:09AM -0800, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
>  #size-cells properties, correct those.
> 
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks Florian,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@netronome.com>

> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
>  		mdio: mdio@18002000 {
>  			compatible = "brcm,iproc-mdio";
>  			reg = <0x18002000 0x8>;
> -			#size-cells = <1>;
> -			#address-cells = <0>;
> +			#size-cells = <0>;
> +			#address-cells = <1>;
>  			status = "disabled";
>  
>  			gphy0: ethernet-phy@0 {
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <simon.horman@netronome.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, grygorii.strashko@ti.com,
	robh+dt@kernel.org, rafal@milecki.pl, davem@davemloft.net,
	andrew@lunn.ch, mark.rutland@arm.com, devicetree@vger.kernel.org,
	netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Eric Anholt <eric@anholt.net>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells
Date: Sat, 7 Dec 2019 18:13:34 +0100	[thread overview]
Message-ID: <20191207171333.GD26173@netronome.com> (raw)
In-Reply-To: <20191206181909.10962-1-f.fainelli@gmail.com>

On Fri, Dec 06, 2019 at 10:19:09AM -0800, Florian Fainelli wrote:
> The MDIO node on Cygnus had an reversed #address-cells and
>  #size-cells properties, correct those.
> 
> Fixes: 40c26d3af60a ("ARM: dts: Cygnus: Add the ethernet switch and ethernet PHY")
> Reported-by: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>

Thanks Florian,

this looks good to me.

Reviewed-by: Simon Horman <simon.horman@netronome.com>

> ---
>  arch/arm/boot/dts/bcm-cygnus.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm-cygnus.dtsi b/arch/arm/boot/dts/bcm-cygnus.dtsi
> index 2dac3efc7640..1bc45cfd5453 100644
> --- a/arch/arm/boot/dts/bcm-cygnus.dtsi
> +++ b/arch/arm/boot/dts/bcm-cygnus.dtsi
> @@ -174,8 +174,8 @@
>  		mdio: mdio@18002000 {
>  			compatible = "brcm,iproc-mdio";
>  			reg = <0x18002000 0x8>;
> -			#size-cells = <1>;
> -			#address-cells = <0>;
> +			#size-cells = <0>;
> +			#address-cells = <1>;
>  			status = "disabled";
>  
>  			gphy0: ethernet-phy@0 {
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2019-12-07 17:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06 18:19 [PATCH] ARM: dts: Cygnus: Fix MDIO node address/size cells Florian Fainelli
2019-12-06 18:19 ` Florian Fainelli
2019-12-07  0:54 ` Ray Jui
2019-12-07  0:54   ` Ray Jui
2019-12-07 17:13 ` Simon Horman [this message]
2019-12-07 17:13   ` Simon Horman
2019-12-09 18:14 ` Florian Fainelli
2019-12-09 18:14   ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191207171333.GD26173@netronome.com \
    --to=simon.horman@netronome.com \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=netdev@vger.kernel.org \
    --cc=rafal@milecki.pl \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.