From: Shawn Guo <shawnguo@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "Stephen Boyd" <sboyd@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Jacky Bai" <ping.bai@nxp.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Abel Vesa" <abel.vesa@nxp.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Peng Fan" <peng.fan@nxp.com>,
linux-clk@vger.kernel.org, kernel@pengutronix.de,
linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] clk: imx8m: Suppress bind attrs
Date: Mon, 9 Dec 2019 10:36:54 +0800 [thread overview]
Message-ID: <20191209023653.GV3365@dragon> (raw)
In-Reply-To: <ce34606bb3876f7506f483db7623fcba6da04810.1574344160.git.leonard.crestez@nxp.com>
On Thu, Nov 21, 2019 at 03:52:17PM +0200, Leonard Crestez wrote:
> The clock drivers on imx8m series are registered as platform devices and
> this opens the possibility of reloading the driver at runtime.
>
> This doesn't actually work: clocks are never removed and attempting to
> bind again results in registration errors and a crash. Almost all
> devices depend on clocks anyway so rebinding is unlikely to ever be
> useful
>
> Fix this by explicitly suppressing bind attrs like several other
> clock drivers.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Leonard Crestez <leonard.crestez@nxp.com>
Cc: "Dong Aisheng" <aisheng.dong@nxp.com>,
"Peng Fan" <peng.fan@nxp.com>, "Abel Vesa" <abel.vesa@nxp.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
linux-imx@nxp.com, kernel@pengutronix.de,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Jacky Bai" <ping.bai@nxp.com>
Subject: Re: [PATCH] clk: imx8m: Suppress bind attrs
Date: Mon, 9 Dec 2019 10:36:54 +0800 [thread overview]
Message-ID: <20191209023653.GV3365@dragon> (raw)
In-Reply-To: <ce34606bb3876f7506f483db7623fcba6da04810.1574344160.git.leonard.crestez@nxp.com>
On Thu, Nov 21, 2019 at 03:52:17PM +0200, Leonard Crestez wrote:
> The clock drivers on imx8m series are registered as platform devices and
> this opens the possibility of reloading the driver at runtime.
>
> This doesn't actually work: clocks are never removed and attempting to
> bind again results in registration errors and a crash. Almost all
> devices depend on clocks anyway so rebinding is unlikely to ever be
> useful
>
> Fix this by explicitly suppressing bind attrs like several other
> clock drivers.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied, thanks.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-09 2:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 13:52 [PATCH] clk: imx8m: Suppress bind attrs Leonard Crestez
2019-11-21 13:52 ` Leonard Crestez
2019-12-09 2:36 ` Shawn Guo [this message]
2019-12-09 2:36 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2019-11-18 22:28 Leonard Crestez
2019-11-18 22:28 ` Leonard Crestez
2019-11-19 7:09 ` Uwe Kleine-König
2019-11-19 7:09 ` Uwe Kleine-König
2019-11-19 14:23 ` Leonard Crestez
2019-11-19 14:23 ` Leonard Crestez
2019-11-19 15:06 ` Uwe Kleine-König
2019-11-19 15:06 ` Uwe Kleine-König
2019-11-19 9:11 ` Peng Fan
2019-11-19 9:11 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209023653.GV3365@dragon \
--to=shawnguo@kernel.org \
--cc=Anson.Huang@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=sboyd@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.