From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
Rajan Vaja <rajan.vaja@xilinx.com>,
qemu-devel@nongnu.org, Michal Simek <michal.simek@xilinx.com>,
Michael Tretter <m.tretter@pengutronix.de>,
Edgar Iglesias <edgari@xilinx.com>,
robh+dt@kernel.org, Rajan Vaja <rajanv@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] arm64: zynqmp: Add firmware DT node
Date: Mon, 9 Dec 2019 08:48:40 +0100 [thread overview]
Message-ID: <20191209074840.GP32392@toto> (raw)
In-Reply-To: <4821742f-2d60-b722-b954-263de975bf2e@roeck-us.net>
On Sun, Dec 08, 2019 at 11:19:33PM -0800, Guenter Roeck wrote:
> On 12/8/19 10:42 PM, Michal Simek wrote:
> > Hi, +Edgar
> >
> >
> > On 08. 12. 19 23:38, Guenter Roeck wrote:
> > > On Fri, Oct 18, 2019 at 06:07:31PM +0200, Michael Tretter wrote:
> > > > From: Rajan Vaja <rajan.vaja@xilinx.com>
> > > >
> > > > Add firmware DT node in ZynqMP device tree. This node
> > > > uses bindings as per new firmware interface driver.
> > > >
> > > > Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > >
> > > With this patch applied in the mainline kernel, the qemu xlnx-zcu102
> > > emulation crashes (see below). Any idea what it might take to get
> > > qemu back to working ?
> >
> > Driver talks through ATF to PMU unit(microblaze). I don't think A53+MB
> > concept is working with mainline qemu. But crash is too hard. It should
Yes, QEMU doesn't support the Cortex-A53s along with the PMU MicroBlaze.
My workaround when using upstream QEMU is a modified DT without the PMU firmware
and with fixed-clock nodes.
> > be no response from PMU and then this panic.
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.5-rc1#n728
> >
>
> Isn't that a bit harsh too ? Normally one would print an error message
> and abort driver instantiation.
I agree, it would be nice if ATF & kernel drivers would somehow handle
this more gracefully.
Cheers,
Edgar
>
> It sounds like you are saying that qemu's xlnx-zcu102 emulation is
> no longer supported and expected to crash the kernel. Is this a
> correct assumption ? If so, I'll drop it from my list of tests.
>
> Thanks,
> Guenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Michal Simek <michal.simek@xilinx.com>,
Michael Tretter <m.tretter@pengutronix.de>,
Edgar Iglesias <edgari@xilinx.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, Rajan Vaja <rajanv@xilinx.com>,
Rajan Vaja <rajan.vaja@xilinx.com>,
linux-arm-kernel@lists.infradead.org, qemu-devel@nongnu.org
Subject: Re: [PATCH 1/5] arm64: zynqmp: Add firmware DT node
Date: Mon, 9 Dec 2019 08:48:40 +0100 [thread overview]
Message-ID: <20191209074840.GP32392@toto> (raw)
In-Reply-To: <4821742f-2d60-b722-b954-263de975bf2e@roeck-us.net>
On Sun, Dec 08, 2019 at 11:19:33PM -0800, Guenter Roeck wrote:
> On 12/8/19 10:42 PM, Michal Simek wrote:
> > Hi, +Edgar
> >
> >
> > On 08. 12. 19 23:38, Guenter Roeck wrote:
> > > On Fri, Oct 18, 2019 at 06:07:31PM +0200, Michael Tretter wrote:
> > > > From: Rajan Vaja <rajan.vaja@xilinx.com>
> > > >
> > > > Add firmware DT node in ZynqMP device tree. This node
> > > > uses bindings as per new firmware interface driver.
> > > >
> > > > Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > >
> > > With this patch applied in the mainline kernel, the qemu xlnx-zcu102
> > > emulation crashes (see below). Any idea what it might take to get
> > > qemu back to working ?
> >
> > Driver talks through ATF to PMU unit(microblaze). I don't think A53+MB
> > concept is working with mainline qemu. But crash is too hard. It should
Yes, QEMU doesn't support the Cortex-A53s along with the PMU MicroBlaze.
My workaround when using upstream QEMU is a modified DT without the PMU firmware
and with fixed-clock nodes.
> > be no response from PMU and then this panic.
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.5-rc1#n728
> >
>
> Isn't that a bit harsh too ? Normally one would print an error message
> and abort driver instantiation.
I agree, it would be nice if ATF & kernel drivers would somehow handle
this more gracefully.
Cheers,
Edgar
>
> It sounds like you are saying that qemu's xlnx-zcu102 emulation is
> no longer supported and expected to crash the kernel. Is this a
> correct assumption ? If so, I'll drop it from my list of tests.
>
> Thanks,
> Guenter
WARNING: multiple messages have this Message-ID (diff)
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
Rajan Vaja <rajan.vaja@xilinx.com>,
qemu-devel@nongnu.org, Michal Simek <michal.simek@xilinx.com>,
Michael Tretter <m.tretter@pengutronix.de>,
Edgar Iglesias <edgari@xilinx.com>,
robh+dt@kernel.org, Rajan Vaja <rajanv@xilinx.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] arm64: zynqmp: Add firmware DT node
Date: Mon, 9 Dec 2019 08:48:40 +0100 [thread overview]
Message-ID: <20191209074840.GP32392@toto> (raw)
In-Reply-To: <4821742f-2d60-b722-b954-263de975bf2e@roeck-us.net>
On Sun, Dec 08, 2019 at 11:19:33PM -0800, Guenter Roeck wrote:
> On 12/8/19 10:42 PM, Michal Simek wrote:
> > Hi, +Edgar
> >
> >
> > On 08. 12. 19 23:38, Guenter Roeck wrote:
> > > On Fri, Oct 18, 2019 at 06:07:31PM +0200, Michael Tretter wrote:
> > > > From: Rajan Vaja <rajan.vaja@xilinx.com>
> > > >
> > > > Add firmware DT node in ZynqMP device tree. This node
> > > > uses bindings as per new firmware interface driver.
> > > >
> > > > Signed-off-by: Rajan Vaja <rajanv@xilinx.com>
> > > > Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> > > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > >
> > > With this patch applied in the mainline kernel, the qemu xlnx-zcu102
> > > emulation crashes (see below). Any idea what it might take to get
> > > qemu back to working ?
> >
> > Driver talks through ATF to PMU unit(microblaze). I don't think A53+MB
> > concept is working with mainline qemu. But crash is too hard. It should
Yes, QEMU doesn't support the Cortex-A53s along with the PMU MicroBlaze.
My workaround when using upstream QEMU is a modified DT without the PMU firmware
and with fixed-clock nodes.
> > be no response from PMU and then this panic.
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/xilinx/zynqmp.c?h=v5.5-rc1#n728
> >
>
> Isn't that a bit harsh too ? Normally one would print an error message
> and abort driver instantiation.
I agree, it would be nice if ATF & kernel drivers would somehow handle
this more gracefully.
Cheers,
Edgar
>
> It sounds like you are saying that qemu's xlnx-zcu102 emulation is
> no longer supported and expected to crash the kernel. Is this a
> correct assumption ? If so, I'll drop it from my list of tests.
>
> Thanks,
> Guenter
next prev parent reply other threads:[~2019-12-09 8:04 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 16:07 [PATCH 0/5] arm64: zynqmp: add firmware device tree node Michael Tretter
2019-10-18 16:07 ` Michael Tretter
2019-10-18 16:07 ` [PATCH 1/5] arm64: zynqmp: Add firmware DT node Michael Tretter
2019-10-18 16:07 ` Michael Tretter
2019-12-08 22:38 ` Guenter Roeck
2019-12-08 22:38 ` Guenter Roeck
2019-12-08 22:38 ` Guenter Roeck
2019-12-09 6:42 ` Michal Simek
2019-12-09 6:42 ` Michal Simek
2019-12-09 6:42 ` Michal Simek
2019-12-09 7:19 ` Guenter Roeck
2019-12-09 7:19 ` Guenter Roeck
2019-12-09 7:19 ` Guenter Roeck
2019-12-09 7:48 ` Edgar E. Iglesias [this message]
2019-12-09 7:48 ` Edgar E. Iglesias
2019-12-09 7:48 ` Edgar E. Iglesias
2019-12-09 8:33 ` Michal Simek
2019-12-09 8:33 ` Michal Simek
2019-12-09 8:33 ` Michal Simek
2019-12-09 14:32 ` Guenter Roeck
2019-12-09 14:32 ` Guenter Roeck
2019-12-09 14:32 ` Guenter Roeck
2019-12-09 15:02 ` Michal Simek
2019-12-09 15:02 ` Michal Simek
2019-12-09 15:02 ` Michal Simek
2019-12-15 5:28 ` Guenter Roeck
2019-12-15 5:28 ` Guenter Roeck
2019-12-15 5:28 ` Guenter Roeck
2019-12-16 6:28 ` Michal Simek
2019-12-16 6:28 ` Michal Simek
2019-12-16 6:28 ` Michal Simek
2019-12-09 8:36 ` Michal Simek
2019-12-09 8:36 ` Michal Simek
2019-12-09 8:36 ` Michal Simek
2019-10-18 16:07 ` [PATCH 2/5] arm64: zynqmp: Add support for zynqmp fpga manager Michael Tretter
2019-10-18 16:07 ` Michael Tretter
2019-10-18 16:07 ` [PATCH 3/5] arm64: zynqmp: Label whole PL part as fpga_full region Michael Tretter
2019-10-18 16:07 ` Michael Tretter
2019-10-18 16:07 ` [PATCH 4/5] arm64: zynqmp: Add support for zynqmp nvmem firmware driver Michael Tretter
2019-10-18 16:07 ` Michael Tretter
2019-10-18 16:07 ` [PATCH 5/5] arm64: zynqmp: Add data cells to access efuse Michael Tretter
2019-10-18 16:07 ` Michael Tretter
2019-10-23 12:30 ` Michal Simek
2019-10-23 12:30 ` Michal Simek
2019-10-23 12:30 ` [PATCH 0/5] arm64: zynqmp: add firmware device tree node Michal Simek
2019-10-23 12:30 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209074840.GP32392@toto \
--to=edgar.iglesias@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=edgari@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=m.tretter@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=rajan.vaja@xilinx.com \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.