[meta-oe][PATCH] librsync: new package

[meta-oe][PATCH] librsync: new package

[Bartosz Golaszewski]

From: Bartosz Golaszewski <bgolaszewski@baylibre.com>

rdiff is a popular tool for calculating binary delta patches. It's
provided by the librsync package (unrelated to rsync already available
in poky).

This recipe adds new packages for librsync and rdiff.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
 .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb

diff --git a/meta-oe/recipes-support/librsync/librsync_2.2.1.bb b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
new file mode 100644
index 000000000..9d224767c
--- /dev/null
+++ b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
@@ -0,0 +1,18 @@
+SUMMARY = "Remote delta-compression library."
+AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
+
+LICENSE = "LGPLv2.1+"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
+
+SRC_URI = "git://github.com/librsync/librsync.git"
+SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
+S = "${WORKDIR}/git"
+
+DEPENDS = "popt"
+
+inherit cmake
+
+BBCLASSEXTEND = "native nativesdk"
+
+PACKAGES =+ "rdiff"
+FILES_rdiff = "/usr/bin/rdiff"
-- 
2.23.0

Re: [meta-oe][PATCH] librsync: new package

[Stefano Babic]

Hi Bartosz,

On 09/12/19 15:46, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> rdiff is a popular tool for calculating binary delta patches. It's
> provided by the librsync package (unrelated to rsync already available
> in poky).
> 

Nice, I added it (really, 2.1) to my public layer, but this definetely
belongs to OE:

https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb


> This recipe adds new packages for librsync and rdiff.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
>  .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>  create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
> 
> diff --git a/meta-oe/recipes-support/librsync/librsync_2.2.1.bb b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
> new file mode 100644
> index 000000000..9d224767c
> --- /dev/null
> +++ b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "Remote delta-compression library."
> +AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
> +
> +LICENSE = "LGPLv2.1+"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
> +
> +SRC_URI = "git://github.com/librsync/librsync.git"
> +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
> +S = "${WORKDIR}/git"
> +
> +DEPENDS = "popt"

Don't you have any depends from zlib / bzip ? cmake tests it, if you do
not add it, build will be fine but without support.

> +
> +inherit cmake
> +
> +BBCLASSEXTEND = "native nativesdk"
> +
> +PACKAGES =+ "rdiff"
> +FILES_rdiff = "/usr/bin/rdiff"
> 

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [meta-oe][PATCH] librsync: new package

[Bartosz Golaszewski]

pon., 9 gru 2019 o 15:53 Stefano Babic <sbabic@denx.de> napisał(a):
>
> Hi Bartosz,
>
> On 09/12/19 15:46, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > rdiff is a popular tool for calculating binary delta patches. It's
> > provided by the librsync package (unrelated to rsync already available
> > in poky).
> >
>
> Nice, I added it (really, 2.1) to my public layer, but this definetely
> belongs to OE:
>
> https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
>

Ha! Somehow it didn't pop up in google search. If you want you can
send your own patch instead of this one.

We probably have the same idea for updates - I'm using it in my
binary-delta update module for mender.

>
> > This recipe adds new packages for librsync and rdiff.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > ---
> >  .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
> >
> > diff --git a/meta-oe/recipes-support/librsync/librsync_2.2.1.bb b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
> > new file mode 100644
> > index 000000000..9d224767c
> > --- /dev/null
> > +++ b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
> > @@ -0,0 +1,18 @@
> > +SUMMARY = "Remote delta-compression library."
> > +AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
> > +
> > +LICENSE = "LGPLv2.1+"
> > +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
> > +
> > +SRC_URI = "git://github.com/librsync/librsync.git"
> > +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
> > +S = "${WORKDIR}/git"
> > +
> > +DEPENDS = "popt"
>
> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
> not add it, build will be fine but without support.
>

Sure - it probably should become a PACKAGECONFIG option.

Bartosz

> > +
> > +inherit cmake
> > +
> > +BBCLASSEXTEND = "native nativesdk"
> > +
> > +PACKAGES =+ "rdiff"
> > +FILES_rdiff = "/usr/bin/rdiff"
> >
>
> Best regards,
> Stefano
>
> --
> =====================================================================
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> =====================================================================

Re: [meta-oe][PATCH] librsync: new package

[Adrian Bunk]

On Mon, Dec 09, 2019 at 04:00:49PM +0100, Bartosz Golaszewski wrote:
> pon., 9 gru 2019 o 15:53 Stefano Babic <sbabic@denx.de> napisał(a):
> >
> > Hi Bartosz,
> >
> > On 09/12/19 15:46, Bartosz Golaszewski wrote:
> > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >
> > > rdiff is a popular tool for calculating binary delta patches. It's
> > > provided by the librsync package (unrelated to rsync already available
> > > in poky).
> > >
> >
> > Nice, I added it (really, 2.1) to my public layer, but this definetely
> > belongs to OE:
> >
> > https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
> 
> Ha! Somehow it didn't pop up in google search.
>...

Better than Google is
http://layers.openembedded.org/layerindex/branch/master/recipes/?q=librsync

cu
Adrian

Re: [meta-oe][PATCH] librsync: new package

[Stefano Babic]

Hi Bartosz,

On 09/12/19 15:56, Bartosz Golaszewski wrote:
> pon., 9 gru 2019 o 15:53 Stefano Babic <sbabic@denx.de> napisał(a):
>>
>> Hi Bartosz,
>>
>> On 09/12/19 15:46, Bartosz Golaszewski wrote:
>>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>>
>>> rdiff is a popular tool for calculating binary delta patches. It's
>>> provided by the librsync package (unrelated to rsync already available
>>> in poky).
>>>
>>
>> Nice, I added it (really, 2.1) to my public layer, but this definetely
>> belongs to OE:
>>
>> https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/librsync/librsync_2.1.0.bb
>>
> 
> Ha! Somehow it didn't pop up in google search. If you want you can
> send your own patch instead of this one.

I am fine with yours, too ;-)

> 
> We probably have the same idea for updates - I'm using it in my
> binary-delta update module for mender.

Exactly the same idea: I am using it for binary-delta update in SWUpdate ;-)

> 
>>
>>> This recipe adds new packages for librsync and rdiff.
>>>
>>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>>> ---
>>>  .../recipes-support/librsync/librsync_2.2.1.bb | 18 ++++++++++++++++++
>>>  1 file changed, 18 insertions(+)
>>>  create mode 100644 meta-oe/recipes-support/librsync/librsync_2.2.1.bb
>>>
>>> diff --git a/meta-oe/recipes-support/librsync/librsync_2.2.1.bb b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
>>> new file mode 100644
>>> index 000000000..9d224767c
>>> --- /dev/null
>>> +++ b/meta-oe/recipes-support/librsync/librsync_2.2.1.bb
>>> @@ -0,0 +1,18 @@
>>> +SUMMARY = "Remote delta-compression library."
>>> +AUTHOR = "Martin Pool, Andrew Tridgell, Donovan Baarda, Adam Schubert"
>>> +
>>> +LICENSE = "LGPLv2.1+"
>>> +LIC_FILES_CHKSUM = "file://COPYING;md5=d8045f3b8f929c1cb29a1e3fd737b499"
>>> +
>>> +SRC_URI = "git://github.com/librsync/librsync.git"
>>> +SRCREV = "5917692418657dc78c9cbde3a8db4c85f25b9c8d"
>>> +S = "${WORKDIR}/git"
>>> +
>>> +DEPENDS = "popt"
>>
>> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
>> not add it, build will be fine but without support.
>>
> 
> Sure - it probably should become a PACKAGECONFIG option.

Well, anyway the library without compression support loses most of its
meaning... But a PACKAGECONFIG with default as on for both compression
libraries is fine.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [meta-oe][PATCH] librsync: new package

[Adrian Bunk]

On Mon, Dec 09, 2019 at 03:53:33PM +0100, Stefano Babic wrote:
>...
> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
> not add it, build will be fine but without support.
>...

Is it also working for you?
https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
https://github.com/librsync/librsync/issues/8

cu
Adrian

Re: [meta-oe][PATCH] librsync: new package

[Stefano Babic]

On 09/12/19 16:14, Adrian Bunk wrote:
> On Mon, Dec 09, 2019 at 03:53:33PM +0100, Stefano Babic wrote:
>> ...
>> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
>> not add it, build will be fine but without support.
>> ...
> 
> Is it also working for you?
> https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
> https://github.com/librsync/librsync/issues/8

Oh, good catch, I was not aware of it. I guess not, because I saw the
dependencies when I wrote the recipe, but I *never* set ENABLE_COMPRESSION..

Stefano


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [meta-oe][PATCH] librsync: new package

[Bartosz Golaszewski]

pon., 9 gru 2019 o 16:22 Stefano Babic <sbabic@denx.de> napisał(a):
>
> On 09/12/19 16:14, Adrian Bunk wrote:
> > On Mon, Dec 09, 2019 at 03:53:33PM +0100, Stefano Babic wrote:
> >> ...
> >> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
> >> not add it, build will be fine but without support.
> >> ...
> >
> > Is it also working for you?
> > https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
> > https://github.com/librsync/librsync/issues/8
>
> Oh, good catch, I was not aware of it. I guess not, because I saw the
> dependencies when I wrote the recipe, but I *never* set ENABLE_COMPRESSION..
>

Is this really something that needs to be provided by rdiff? We can
just pipe the output to a compressor of your choice.

Bart

> Stefano
>
>
> --
> =====================================================================
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> =====================================================================

Re: [meta-oe][PATCH] librsync: new package

[Stefano Babic]

On 09/12/19 16:33, Bartosz Golaszewski wrote:
> pon., 9 gru 2019 o 16:22 Stefano Babic <sbabic@denx.de> napisał(a):
>>
>> On 09/12/19 16:14, Adrian Bunk wrote:
>>> On Mon, Dec 09, 2019 at 03:53:33PM +0100, Stefano Babic wrote:
>>>> ...
>>>> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
>>>> not add it, build will be fine but without support.
>>>> ...
>>>
>>> Is it also working for you?
>>> https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
>>> https://github.com/librsync/librsync/issues/8
>>
>> Oh, good catch, I was not aware of it. I guess not, because I saw the
>> dependencies when I wrote the recipe, but I *never* set ENABLE_COMPRESSION..
>>
> 
> Is this really something that needs to be provided by rdiff? We can
> just pipe the output to a compressor of your choice.

Yes, I realized that it is not required by librsync - I already compress
the output of rdiff to generate the delta, no need to integrate it.
Sorry for noise.

What about to put the binary "rdiff" into a separate "bin" package ? I
have rescue system where footprint is an issue, and rdiff is not
required on target.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

Re: [meta-oe][PATCH] librsync: new package

[Bartosz Golaszewski]

pon., 9 gru 2019 o 17:23 Stefano Babic <sbabic@denx.de> napisał(a):
>
> On 09/12/19 16:33, Bartosz Golaszewski wrote:
> > pon., 9 gru 2019 o 16:22 Stefano Babic <sbabic@denx.de> napisał(a):
> >>
> >> On 09/12/19 16:14, Adrian Bunk wrote:
> >>> On Mon, Dec 09, 2019 at 03:53:33PM +0100, Stefano Babic wrote:
> >>>> ...
> >>>> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
> >>>> not add it, build will be fine but without support.
> >>>> ...
> >>>
> >>> Is it also working for you?
> >>> https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
> >>> https://github.com/librsync/librsync/issues/8
> >>
> >> Oh, good catch, I was not aware of it. I guess not, because I saw the
> >> dependencies when I wrote the recipe, but I *never* set ENABLE_COMPRESSION..
> >>
> >
> > Is this really something that needs to be provided by rdiff? We can
> > just pipe the output to a compressor of your choice.
>
> Yes, I realized that it is not required by librsync - I already compress
> the output of rdiff to generate the delta, no need to integrate it.
> Sorry for noise.
>
> What about to put the binary "rdiff" into a separate "bin" package ? I
> have rescue system where footprint is an issue, and rdiff is not
> required on target.
>

But this is what I did in my patch.

Bart

> Regards,
> Stefano
>
> --
> =====================================================================
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> =====================================================================

Re: [meta-oe][PATCH] librsync: new package

[Stefano Babic]

On 09/12/19 17:30, Bartosz Golaszewski wrote:
> pon., 9 gru 2019 o 17:23 Stefano Babic <sbabic@denx.de> napisał(a):
>>
>> On 09/12/19 16:33, Bartosz Golaszewski wrote:
>>> pon., 9 gru 2019 o 16:22 Stefano Babic <sbabic@denx.de> napisał(a):
>>>>
>>>> On 09/12/19 16:14, Adrian Bunk wrote:
>>>>> On Mon, Dec 09, 2019 at 03:53:33PM +0100, Stefano Babic wrote:
>>>>>> ...
>>>>>> Don't you have any depends from zlib / bzip ? cmake tests it, if you do
>>>>>> not add it, build will be fine but without support.
>>>>>> ...
>>>>>
>>>>> Is it also working for you?
>>>>> https://github.com/librsync/librsync/blob/master/CMakeLists.txt#L53-L57
>>>>> https://github.com/librsync/librsync/issues/8
>>>>
>>>> Oh, good catch, I was not aware of it. I guess not, because I saw the
>>>> dependencies when I wrote the recipe, but I *never* set ENABLE_COMPRESSION..
>>>>
>>>
>>> Is this really something that needs to be provided by rdiff? We can
>>> just pipe the output to a compressor of your choice.
>>
>> Yes, I realized that it is not required by librsync - I already compress
>> the output of rdiff to generate the delta, no need to integrate it.
>> Sorry for noise.
>>
>> What about to put the binary "rdiff" into a separate "bin" package ? I
>> have rescue system where footprint is an issue, and rdiff is not
>> required on target.
>>
> 
> But this is what I did in my patch.

Sorry, you're right, you have already done it !

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================