All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will@kernel.org>,
	linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, linux-mm@kvack.org,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Lutomirski <luto@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Borislav Petkov <bp@alien8.de>,
	Dan Williams <dan.j.williams@intel.com>,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/6] Allow setting caching mode in arch_add_memory() for P2PDMA
Date: Mon, 09 Dec 2019 20:43:45 +0000	[thread overview]
Message-ID: <20191209204345.GA29265@lst.de> (raw)
In-Reply-To: <20191209191346.5197-1-logang@deltatee.com>

On Mon, Dec 09, 2019 at 12:13:40PM -0700, Logan Gunthorpe wrote:
> This changes is pretty routine for most of the arches: x86_64, s390, arm64
> and powerpc simply need to thread the pgprot through to where the page tables
> are setup. x86_32 unfortunately sets up the page tables at boot so
> must use _set_memory_prot() to change their caching mode. ia64 and sh
> don't appear to have an easy way to change the page tables so, for now
> at least, we just return -EINVAL on such mappings and thus they will
> not support P2PDMA memory until the work for this is done.

ia64 and sh don't support ZONE_DEVICE mappings anyway as far as I know.

This generally looks fine to me.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
	linux-sh@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-mm@kvack.org, Christoph Hellwig <hch@lst.de>,
	Dan Williams <dan.j.williams@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH 0/6] Allow setting caching mode in arch_add_memory() for P2PDMA
Date: Mon, 9 Dec 2019 21:43:45 +0100	[thread overview]
Message-ID: <20191209204345.GA29265@lst.de> (raw)
In-Reply-To: <20191209191346.5197-1-logang@deltatee.com>

On Mon, Dec 09, 2019 at 12:13:40PM -0700, Logan Gunthorpe wrote:
> This changes is pretty routine for most of the arches: x86_64, s390, arm64
> and powerpc simply need to thread the pgprot through to where the page tables
> are setup. x86_32 unfortunately sets up the page tables at boot so
> must use _set_memory_prot() to change their caching mode. ia64 and sh
> don't appear to have an easy way to change the page tables so, for now
> at least, we just return -EINVAL on such mappings and thus they will
> not support P2PDMA memory until the work for this is done.

ia64 and sh don't support ZONE_DEVICE mappings anyway as far as I know.

This generally looks fine to me.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will@kernel.org>,
	linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, linux-mm@kvack.org,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Dan Williams <dan.j.williams@intel.com>,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/6] Allow setting caching mode in arch_add_memory() for P2PDMA
Date: Mon, 9 Dec 2019 21:43:45 +0100	[thread overview]
Message-ID: <20191209204345.GA29265@lst.de> (raw)
In-Reply-To: <20191209191346.5197-1-logang@deltatee.com>

On Mon, Dec 09, 2019 at 12:13:40PM -0700, Logan Gunthorpe wrote:
> This changes is pretty routine for most of the arches: x86_64, s390, arm64
> and powerpc simply need to thread the pgprot through to where the page tables
> are setup. x86_32 unfortunately sets up the page tables at boot so
> must use _set_memory_prot() to change their caching mode. ia64 and sh
> don't appear to have an easy way to change the page tables so, for now
> at least, we just return -EINVAL on such mappings and thus they will
> not support P2PDMA memory until the work for this is done.

ia64 and sh don't support ZONE_DEVICE mappings anyway as far as I know.

This generally looks fine to me.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Logan Gunthorpe <logang@deltatee.com>
Cc: linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Will Deacon <will@kernel.org>,
	linux-sh@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, linux-mm@kvack.org,
	Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Lutomirski <luto@kernel.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Borislav Petkov <bp@alien8.de>,
	Dan Williams <dan.j.williams@intel.com>,
	linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/6] Allow setting caching mode in arch_add_memory() for P2PDMA
Date: Mon, 9 Dec 2019 21:43:45 +0100	[thread overview]
Message-ID: <20191209204345.GA29265@lst.de> (raw)
In-Reply-To: <20191209191346.5197-1-logang@deltatee.com>

On Mon, Dec 09, 2019 at 12:13:40PM -0700, Logan Gunthorpe wrote:
> This changes is pretty routine for most of the arches: x86_64, s390, arm64
> and powerpc simply need to thread the pgprot through to where the page tables
> are setup. x86_32 unfortunately sets up the page tables at boot so
> must use _set_memory_prot() to change their caching mode. ia64 and sh
> don't appear to have an easy way to change the page tables so, for now
> at least, we just return -EINVAL on such mappings and thus they will
> not support P2PDMA memory until the work for this is done.

ia64 and sh don't support ZONE_DEVICE mappings anyway as far as I know.

This generally looks fine to me.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2019-12-09 20:43 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 19:13 [PATCH 0/6] Allow setting caching mode in arch_add_memory() for P2PDMA Logan Gunthorpe
2019-12-09 19:13 ` Logan Gunthorpe
2019-12-09 19:13 ` Logan Gunthorpe
2019-12-09 19:13 ` Logan Gunthorpe
2019-12-09 19:13 ` [PATCH 1/6] x86/mm: Thread pgprot_t through init_memory_mapping() Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13 ` [PATCH 2/6] x86/mm: Introduce _set_memory_prot() Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13 ` [PATCH 3/6] powerpc/mm: Thread pgprot_t through create_section_mapping() Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13 ` [PATCH 4/6] s390/mm: Thread pgprot_t through vmem_add_mapping() Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13 ` [PATCH 5/6] mm, memory_hotplug: Provide argument for the pgprot_t in arch_add_memory() Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:23   ` David Hildenbrand
2019-12-09 19:23     ` David Hildenbrand
2019-12-09 19:23     ` David Hildenbrand
2019-12-09 19:23     ` David Hildenbrand
2019-12-09 20:24     ` Logan Gunthorpe
2019-12-09 20:24       ` Logan Gunthorpe
2019-12-09 20:24       ` Logan Gunthorpe
2019-12-09 20:24       ` Logan Gunthorpe
2019-12-09 20:41       ` Michal Hocko
2019-12-09 20:41         ` Michal Hocko
2019-12-09 20:41         ` Michal Hocko
2019-12-09 20:41         ` Michal Hocko
2019-12-09 21:00         ` Dan Williams
2019-12-09 21:00           ` Dan Williams
2019-12-09 21:00           ` Dan Williams
2019-12-09 21:00           ` Dan Williams
2019-12-09 21:00           ` Dan Williams
2019-12-09 21:27           ` Logan Gunthorpe
2019-12-09 21:27             ` Logan Gunthorpe
2019-12-09 21:27             ` Logan Gunthorpe
2019-12-09 21:27             ` Logan Gunthorpe
2019-12-09 21:27             ` Logan Gunthorpe
2019-12-09 21:24         ` Logan Gunthorpe
2019-12-09 21:24           ` Logan Gunthorpe
2019-12-09 21:24           ` Logan Gunthorpe
2019-12-09 21:24           ` Logan Gunthorpe
2019-12-10  9:56           ` Michal Hocko
2019-12-10  9:56             ` Michal Hocko
2019-12-10  9:56             ` Michal Hocko
2019-12-10  9:56             ` Michal Hocko
2019-12-09 20:43       ` Dan Williams
2019-12-09 20:43         ` Dan Williams
2019-12-09 20:43         ` Dan Williams
2019-12-09 20:43         ` Dan Williams
2019-12-09 20:43         ` Dan Williams
2019-12-09 20:52         ` David Hildenbrand
2019-12-09 20:52           ` David Hildenbrand
2019-12-09 20:52           ` David Hildenbrand
2019-12-09 20:52           ` David Hildenbrand
2019-12-09 20:52           ` David Hildenbrand
2019-12-10 10:04         ` Michal Hocko
2019-12-10 10:04           ` Michal Hocko
2019-12-10 10:04           ` Michal Hocko
2019-12-10 10:04           ` Michal Hocko
2019-12-10 10:04           ` Michal Hocko
2019-12-10 10:09           ` David Hildenbrand
2019-12-10 10:09             ` David Hildenbrand
2019-12-10 10:09             ` David Hildenbrand
2019-12-10 10:09             ` David Hildenbrand
2019-12-10 10:09             ` David Hildenbrand
2019-12-10 10:34             ` Michal Hocko
2019-12-10 10:34               ` Michal Hocko
2019-12-10 10:34               ` Michal Hocko
2019-12-10 10:34               ` Michal Hocko
2019-12-10 10:34               ` Michal Hocko
2019-12-10 11:25               ` David Hildenbrand
2019-12-10 11:25                 ` David Hildenbrand
2019-12-10 11:25                 ` David Hildenbrand
2019-12-10 11:25                 ` David Hildenbrand
2019-12-10 11:25                 ` David Hildenbrand
2019-12-10 23:52                 ` Logan Gunthorpe
2019-12-10 23:52                   ` Logan Gunthorpe
2019-12-10 23:52                   ` Logan Gunthorpe
2019-12-10 23:52                   ` Logan Gunthorpe
2019-12-10 23:52                   ` Logan Gunthorpe
2019-12-11  8:37                   ` Michal Hocko
2019-12-11  8:37                     ` Michal Hocko
2019-12-11  8:37                     ` Michal Hocko
2019-12-11  8:37                     ` Michal Hocko
2019-12-11  8:37                     ` Michal Hocko
2019-12-09 19:13 ` [PATCH 6/6] mm/memremap: Set caching mode for PCI P2PDMA memory to WC Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 19:13   ` Logan Gunthorpe
2019-12-09 20:43 ` Christoph Hellwig [this message]
2019-12-09 20:43   ` [PATCH 0/6] Allow setting caching mode in arch_add_memory() for P2PDMA Christoph Hellwig
2019-12-09 20:43   ` Christoph Hellwig
2019-12-09 20:43   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209204345.GA29265@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=benh@kernel.crashing.org \
    --cc=bp@alien8.de \
    --cc=catalin.marinas@arm.com \
    --cc=dan.j.williams@intel.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=logang@deltatee.com \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.