From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [f2fs-dev] [PATCH 5/6] f2fs: set GFP_NOFS when moving inline dentries
Date: Mon, 9 Dec 2019 14:23:44 -0800 [thread overview]
Message-ID: <20191209222345.1078-5-jaegeuk@kernel.org> (raw)
In-Reply-To: <20191209222345.1078-1-jaegeuk@kernel.org>
Otherwise, it can cause circular locking dependency reported by mm.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/inline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 896db0416f0e..52f85ed07a15 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -368,7 +368,7 @@ static int f2fs_move_inline_dirents(struct inode *dir, struct page *ipage,
struct f2fs_dentry_ptr src, dst;
int err;
- page = f2fs_grab_cache_page(dir->i_mapping, 0, false);
+ page = f2fs_grab_cache_page(dir->i_mapping, 0, true);
if (!page) {
f2fs_put_page(ipage, 1);
return -ENOMEM;
--
2.19.0.605.g01d371f741-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 5/6] f2fs: set GFP_NOFS when moving inline dentries
Date: Mon, 9 Dec 2019 14:23:44 -0800 [thread overview]
Message-ID: <20191209222345.1078-5-jaegeuk@kernel.org> (raw)
In-Reply-To: <20191209222345.1078-1-jaegeuk@kernel.org>
Otherwise, it can cause circular locking dependency reported by mm.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/inline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/inline.c b/fs/f2fs/inline.c
index 896db0416f0e..52f85ed07a15 100644
--- a/fs/f2fs/inline.c
+++ b/fs/f2fs/inline.c
@@ -368,7 +368,7 @@ static int f2fs_move_inline_dirents(struct inode *dir, struct page *ipage,
struct f2fs_dentry_ptr src, dst;
int err;
- page = f2fs_grab_cache_page(dir->i_mapping, 0, false);
+ page = f2fs_grab_cache_page(dir->i_mapping, 0, true);
if (!page) {
f2fs_put_page(ipage, 1);
return -ENOMEM;
--
2.19.0.605.g01d371f741-goog
next prev parent reply other threads:[~2019-12-09 22:24 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 22:23 [f2fs-dev] [PATCH 1/6] f2fs: call f2fs_balance_fs outside of locked page Jaegeuk Kim
2019-12-09 22:23 ` Jaegeuk Kim
2019-12-09 22:23 ` [f2fs-dev] [PATCH 2/6] f2fs: declare nested quota_sem and remove unnecessary sems Jaegeuk Kim
2019-12-09 22:23 ` Jaegeuk Kim
2019-12-10 6:20 ` [f2fs-dev] " Chao Yu
2019-12-10 6:20 ` Chao Yu
2019-12-09 22:23 ` [f2fs-dev] [PATCH 3/6] f2fs: keep quota data on write_begin failure Jaegeuk Kim
2019-12-09 22:23 ` Jaegeuk Kim
2019-12-10 6:22 ` [f2fs-dev] " Chao Yu
2019-12-10 6:22 ` Chao Yu
2019-12-09 22:23 ` [f2fs-dev] [PATCH 4/6] f2fs: should avoid recursive filesystem ops Jaegeuk Kim
2019-12-09 22:23 ` Jaegeuk Kim
2019-12-10 6:22 ` [f2fs-dev] " Chao Yu
2019-12-10 6:22 ` Chao Yu
2019-12-09 22:23 ` Jaegeuk Kim [this message]
2019-12-09 22:23 ` [PATCH 5/6] f2fs: set GFP_NOFS when moving inline dentries Jaegeuk Kim
2019-12-10 6:22 ` [f2fs-dev] " Chao Yu
2019-12-10 6:22 ` Chao Yu
2019-12-09 22:23 ` [f2fs-dev] [PATCH 6/6] f2fs: set I_LINKABLE early to avoid wrong access by vfs Jaegeuk Kim
2019-12-09 22:23 ` Jaegeuk Kim
2019-12-10 6:37 ` [f2fs-dev] " Chao Yu
2019-12-10 6:37 ` Chao Yu
2019-12-11 1:21 ` Jaegeuk Kim
2019-12-11 1:21 ` Jaegeuk Kim
2019-12-11 1:23 ` Chao Yu
2019-12-11 1:23 ` Chao Yu
2019-12-11 1:31 ` Jaegeuk Kim
2019-12-11 1:31 ` Jaegeuk Kim
2019-12-11 1:42 ` Chao Yu
2019-12-11 1:42 ` Chao Yu
2019-12-12 16:55 ` Jaegeuk Kim
2019-12-12 16:55 ` Jaegeuk Kim
2019-12-10 2:09 ` [f2fs-dev] [PATCH 1/6] f2fs: call f2fs_balance_fs outside of locked page Chao Yu
2019-12-10 2:09 ` Chao Yu
2020-02-22 4:46 ` Ondřej Jirman
2020-02-22 4:46 ` Ondřej Jirman
2020-02-22 18:17 ` [f2fs-dev] Writes stoped working on f2fs after the compression support was added Ondřej Jirman
2020-02-22 18:17 ` Ondřej Jirman
2020-02-24 10:37 ` [f2fs-dev] " Chao Yu
2020-02-24 10:37 ` Chao Yu
2020-02-24 10:41 ` [f2fs-dev] " Chao Yu
2020-02-24 10:41 ` Chao Yu
2020-02-24 13:58 ` Ondřej Jirman
2020-02-24 13:58 ` Ondřej Jirman
2020-02-24 14:03 ` Ondřej Jirman
2020-02-24 14:03 ` Ondřej Jirman
2020-02-24 14:31 ` Ondřej Jirman
2020-02-24 14:31 ` Ondřej Jirman
2020-02-25 11:24 ` Chao Yu
2020-02-25 11:24 ` Chao Yu
2020-02-25 11:32 ` Chao Yu
2020-02-25 11:32 ` Chao Yu
2020-02-25 12:08 ` Ondřej Jirman
2020-02-25 12:08 ` Ondřej Jirman
2020-02-25 12:27 ` Ondřej Jirman
2020-02-25 12:27 ` Ondřej Jirman
2020-02-26 1:58 ` Chao Yu
2020-02-26 1:58 ` Chao Yu
2020-02-26 12:11 ` Ondřej Jirman
2020-02-26 12:11 ` Ondřej Jirman
2020-02-26 18:05 ` Ondřej Jirman
2020-02-26 18:05 ` Ondřej Jirman
2020-02-27 2:01 ` Chao Yu
2020-02-27 2:01 ` Chao Yu
2020-03-06 12:02 ` Ondřej Jirman
2020-03-06 12:02 ` Ondřej Jirman
2020-03-06 12:43 ` Ondřej Jirman
2020-03-06 12:43 ` Ondřej Jirman
2020-03-11 9:02 ` Chao Yu
2020-03-11 9:02 ` Chao Yu
2020-03-11 10:33 ` Ondřej Jirman
2020-03-11 10:33 ` Ondřej Jirman
2020-03-11 10:51 ` Chao Yu
2020-03-11 10:51 ` Chao Yu
2020-03-11 11:01 ` Ondřej Jirman
2020-03-11 11:01 ` Ondřej Jirman
2020-03-11 12:13 ` Chao Yu
2020-03-11 17:01 ` Jaegeuk Kim
2020-03-11 17:01 ` Jaegeuk Kim
2020-03-22 10:15 ` Chao Yu
2020-03-22 10:15 ` Chao Yu
2020-02-24 14:20 ` Ondřej Jirman
2020-02-24 14:20 ` Ondřej Jirman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209222345.1078-5-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.