All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: baolin.wang@linaro.org, airlied@linux.ie, zhang.lyra@gmail.com,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	orsonzhai@gmail.com
Subject: Re: [PATCH RFC 0/8] Add Unisoc's drm kms module
Date: Tue, 10 Dec 2019 19:54:38 +0100	[thread overview]
Message-ID: <20191210185438.GA13884@ravnborg.org> (raw)
In-Reply-To: <1575966995-13757-1-git-send-email-kevin3.tang@gmail.com>

Hi Kevin.

Thanks for this new driver.
A few somments triggered alone from the diffstat.
> Kevin Tang (8):
>   dt-bindings: display: add Unisoc's drm master bindings
>   drm/sprd: add Unisoc's drm kms master
>   dt-bindings: display: add Unisoc's dpu bindings
>   drm/sprd: add Unisoc's drm display controller driver
>   dt-bindings: display: add Unisoc's mipi dsi&dphy bindings
>   drm/sprd: add Unisoc's drm mipi dsi&dphy driver
>   dt-bindings: display: add Unisoc's generic mipi panel bindings
>   drm/sprd: add Unisoc's drm generic mipi panel driver
> 
>  .../devicetree/bindings/display/sprd/dphy.txt      |   49 +
>  .../devicetree/bindings/display/sprd/dpu.txt       |   55 +
>  .../devicetree/bindings/display/sprd/drm.txt       |   18 +
>  .../devicetree/bindings/display/sprd/dsi.txt       |   68 +
>  .../devicetree/bindings/display/sprd/panel.txt     |  110 ++

New bindings in metaschema format (.yaml).
And panel bindings in display/panel/

>  drivers/gpu/drm/Kconfig                            |    2 +
>  drivers/gpu/drm/Makefile                           |    1 +
>  drivers/gpu/drm/sprd/Kconfig                       |   14 +
>  drivers/gpu/drm/sprd/Makefile                      |   17 +
>  drivers/gpu/drm/sprd/disp_lib.c                    |  290 ++++
>  drivers/gpu/drm/sprd/disp_lib.h                    |   40 +
>  drivers/gpu/drm/sprd/dphy/Makefile                 |    7 +
>  drivers/gpu/drm/sprd/dphy/pll/Makefile             |    3 +
>  drivers/gpu/drm/sprd/dphy/pll/megacores_sharkle.c  |  640 +++++++++
>  drivers/gpu/drm/sprd/dphy/sprd_dphy_api.c          |  254 ++++
>  drivers/gpu/drm/sprd/dphy/sprd_dphy_hal.h          |  329 +++++
>  drivers/gpu/drm/sprd/dpu/Makefile                  |    8 +
>  drivers/gpu/drm/sprd/dpu/dpu_r2p0.c                | 1464 ++++++++++++++++++++
>  drivers/gpu/drm/sprd/dsi/Makefile                  |    7 +
>  drivers/gpu/drm/sprd/dsi/core/Makefile             |    3 +
>  drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0.c      | 1186 ++++++++++++++++
>  drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0.h      | 1417 +++++++++++++++++++
>  drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0_ppi.c  |  392 ++++++
>  drivers/gpu/drm/sprd/dsi/sprd_dsi_api.c            |  544 ++++++++
>  drivers/gpu/drm/sprd/dsi/sprd_dsi_api.h            |   28 +
>  drivers/gpu/drm/sprd/dsi/sprd_dsi_hal.h            | 1102 +++++++++++++++
>  drivers/gpu/drm/sprd/sprd_dphy.c                   |  235 ++++
>  drivers/gpu/drm/sprd/sprd_dphy.h                   |  121 ++
>  drivers/gpu/drm/sprd/sprd_dpu.c                    | 1152 +++++++++++++++
>  drivers/gpu/drm/sprd/sprd_dpu.h                    |  217 +++
>  drivers/gpu/drm/sprd/sprd_drm.c                    |  287 ++++
>  drivers/gpu/drm/sprd/sprd_drm.h                    |   19 +
>  drivers/gpu/drm/sprd/sprd_dsi.c                    |  722 ++++++++++
>  drivers/gpu/drm/sprd/sprd_dsi.h                    |  210 +++
>  drivers/gpu/drm/sprd/sprd_gem.c                    |  178 +++
>  drivers/gpu/drm/sprd/sprd_gem.h                    |   30 +

>  drivers/gpu/drm/sprd/sprd_panel.c                  |  778 +++++++++++
>  drivers/gpu/drm/sprd/sprd_panel.h                  |  114 ++
Please move panels to drivers/gpu/drm/panel/ and make sure to utilize
the drm_panel infrastructure.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Kevin Tang <kevin3.tang@gmail.com>
Cc: airlied@linux.ie, daniel@ffwll.ch, orsonzhai@gmail.com,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	zhang.lyra@gmail.com, baolin.wang@linaro.org
Subject: Re: [PATCH RFC 0/8] Add Unisoc's drm kms module
Date: Tue, 10 Dec 2019 19:54:38 +0100	[thread overview]
Message-ID: <20191210185438.GA13884@ravnborg.org> (raw)
In-Reply-To: <1575966995-13757-1-git-send-email-kevin3.tang@gmail.com>

Hi Kevin.

Thanks for this new driver.
A few somments triggered alone from the diffstat.
> Kevin Tang (8):
>   dt-bindings: display: add Unisoc's drm master bindings
>   drm/sprd: add Unisoc's drm kms master
>   dt-bindings: display: add Unisoc's dpu bindings
>   drm/sprd: add Unisoc's drm display controller driver
>   dt-bindings: display: add Unisoc's mipi dsi&dphy bindings
>   drm/sprd: add Unisoc's drm mipi dsi&dphy driver
>   dt-bindings: display: add Unisoc's generic mipi panel bindings
>   drm/sprd: add Unisoc's drm generic mipi panel driver
> 
>  .../devicetree/bindings/display/sprd/dphy.txt      |   49 +
>  .../devicetree/bindings/display/sprd/dpu.txt       |   55 +
>  .../devicetree/bindings/display/sprd/drm.txt       |   18 +
>  .../devicetree/bindings/display/sprd/dsi.txt       |   68 +
>  .../devicetree/bindings/display/sprd/panel.txt     |  110 ++

New bindings in metaschema format (.yaml).
And panel bindings in display/panel/

>  drivers/gpu/drm/Kconfig                            |    2 +
>  drivers/gpu/drm/Makefile                           |    1 +
>  drivers/gpu/drm/sprd/Kconfig                       |   14 +
>  drivers/gpu/drm/sprd/Makefile                      |   17 +
>  drivers/gpu/drm/sprd/disp_lib.c                    |  290 ++++
>  drivers/gpu/drm/sprd/disp_lib.h                    |   40 +
>  drivers/gpu/drm/sprd/dphy/Makefile                 |    7 +
>  drivers/gpu/drm/sprd/dphy/pll/Makefile             |    3 +
>  drivers/gpu/drm/sprd/dphy/pll/megacores_sharkle.c  |  640 +++++++++
>  drivers/gpu/drm/sprd/dphy/sprd_dphy_api.c          |  254 ++++
>  drivers/gpu/drm/sprd/dphy/sprd_dphy_hal.h          |  329 +++++
>  drivers/gpu/drm/sprd/dpu/Makefile                  |    8 +
>  drivers/gpu/drm/sprd/dpu/dpu_r2p0.c                | 1464 ++++++++++++++++++++
>  drivers/gpu/drm/sprd/dsi/Makefile                  |    7 +
>  drivers/gpu/drm/sprd/dsi/core/Makefile             |    3 +
>  drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0.c      | 1186 ++++++++++++++++
>  drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0.h      | 1417 +++++++++++++++++++
>  drivers/gpu/drm/sprd/dsi/core/dsi_ctrl_r1p0_ppi.c  |  392 ++++++
>  drivers/gpu/drm/sprd/dsi/sprd_dsi_api.c            |  544 ++++++++
>  drivers/gpu/drm/sprd/dsi/sprd_dsi_api.h            |   28 +
>  drivers/gpu/drm/sprd/dsi/sprd_dsi_hal.h            | 1102 +++++++++++++++
>  drivers/gpu/drm/sprd/sprd_dphy.c                   |  235 ++++
>  drivers/gpu/drm/sprd/sprd_dphy.h                   |  121 ++
>  drivers/gpu/drm/sprd/sprd_dpu.c                    | 1152 +++++++++++++++
>  drivers/gpu/drm/sprd/sprd_dpu.h                    |  217 +++
>  drivers/gpu/drm/sprd/sprd_drm.c                    |  287 ++++
>  drivers/gpu/drm/sprd/sprd_drm.h                    |   19 +
>  drivers/gpu/drm/sprd/sprd_dsi.c                    |  722 ++++++++++
>  drivers/gpu/drm/sprd/sprd_dsi.h                    |  210 +++
>  drivers/gpu/drm/sprd/sprd_gem.c                    |  178 +++
>  drivers/gpu/drm/sprd/sprd_gem.h                    |   30 +

>  drivers/gpu/drm/sprd/sprd_panel.c                  |  778 +++++++++++
>  drivers/gpu/drm/sprd/sprd_panel.h                  |  114 ++
Please move panels to drivers/gpu/drm/panel/ and make sure to utilize
the drm_panel infrastructure.

	Sam

  parent reply	other threads:[~2019-12-10 18:54 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10  8:36 [PATCH RFC 0/8] Add Unisoc's drm kms module Kevin Tang
2019-12-10  8:36 ` Kevin Tang
2019-12-10  8:36 ` [PATCH RFC 1/8] dt-bindings: display: add Unisoc's drm master bindings Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-13  9:42   ` Maxime Ripard
2019-12-13  9:42     ` Maxime Ripard
2019-12-10  8:36 ` [PATCH RFC 2/8] drm/sprd: add Unisoc's drm kms master Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-10 10:32   ` Thomas Zimmermann
2019-12-10 10:32     ` Thomas Zimmermann
2019-12-10 12:38     ` tang pengchuan
2019-12-10 12:47       ` Thomas Zimmermann
2019-12-10 12:47         ` Thomas Zimmermann
2019-12-10 13:42         ` tang pengchuan
2019-12-11  3:00         ` tang pengchuan
2019-12-10 10:41   ` Daniel Vetter
2019-12-10 10:41     ` Daniel Vetter
2019-12-10 11:40     ` tang pengchuan
2019-12-10 16:06   ` Emil Velikov
2019-12-10 16:06     ` Emil Velikov
2019-12-10 22:01     ` Daniel Vetter
2019-12-10 22:01       ` Daniel Vetter
2019-12-10  8:36 ` [PATCH RFC 3/8] dt-bindings: display: add Unisoc's dpu bindings Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-13  9:44   ` Maxime Ripard
2019-12-13  9:44     ` Maxime Ripard
2019-12-10  8:36 ` [PATCH RFC 4/8] drm/sprd: add Unisoc's drm display controller driver Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-10 10:44   ` Thomas Zimmermann
2019-12-10 10:44     ` Thomas Zimmermann
2019-12-10 11:29     ` tang pengchuan
2019-12-10 11:32     ` tang pengchuan
2019-12-10 17:13   ` Emil Velikov
2019-12-10 17:13     ` Emil Velikov
2019-12-11  1:18     ` tang pengchuan
2019-12-11 11:46       ` Emil Velikov
2019-12-11 11:46         ` Emil Velikov
2019-12-10  8:36 ` [PATCH RFC 5/8] dt-bindings: display: add Unisoc's mipi dsi&dphy bindings Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-13  9:46   ` Maxime Ripard
2019-12-13  9:46     ` Maxime Ripard
2019-12-10  8:36 ` [PATCH RFC 6/8] drm/sprd: add Unisoc's drm mipi dsi&dphy driver Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-10  8:36 ` [PATCH RFC 7/8] dt-bindings: display: add Unisoc's generic mipi panel bindings Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-13  9:48   ` Maxime Ripard
2019-12-13  9:48     ` Maxime Ripard
2019-12-10  8:36 ` [PATCH RFC 8/8] drm/sprd: add Unisoc's drm generic mipi panel driver Kevin Tang
2019-12-10  8:36   ` Kevin Tang
2019-12-10 18:54 ` Sam Ravnborg [this message]
2019-12-10 18:54   ` [PATCH RFC 0/8] Add Unisoc's drm kms module Sam Ravnborg
2019-12-12 14:29   ` tang pengchuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191210185438.GA13884@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=airlied@linux.ie \
    --cc=baolin.wang@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kevin3.tang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.