From: Greg KH <gregkh@linuxfoundation.org>
To: Jack Ping CHNG <jack.ping.chng@intel.com>
Cc: devel@driverdev.osuosl.org, cheol.yong.kim@intel.com,
andriy.shevchenko@intel.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Amireddy Mallikarjuna reddy
<mallikarjunax.reddy@linux.intel.com>,
davem@davemloft.net
Subject: Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver
Date: Wed, 11 Dec 2019 10:29:44 +0100 [thread overview]
Message-ID: <20191211092944.GB505511@kroah.com> (raw)
In-Reply-To: <5f85180573a3fb20238d6a340cdd990f140ed6f0.1576054234.git.jack.ping.chng@intel.com>
On Wed, Dec 11, 2019 at 04:57:28PM +0800, Jack Ping CHNG wrote:
> - Added TODO (upstream plan)
Wait, your TODO file references things not even in this patch:
> ---
> drivers/staging/Kconfig | 2 +
> drivers/staging/Makefile | 1 +
> drivers/staging/intel-gwdpa/Kconfig | 22 +
> drivers/staging/intel-gwdpa/Makefile | 5 +
> drivers/staging/intel-gwdpa/TODO | 52 ++
> drivers/staging/intel-gwdpa/gswip/Makefile | 10 +
> drivers/staging/intel-gwdpa/gswip/TODO | 4 +
> drivers/staging/intel-gwdpa/gswip/gswip.h | 399 +++++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_core.c | 755 +++++++++++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_core.h | 106 ++++
> drivers/staging/intel-gwdpa/gswip/gswip_dev.c | 184 ++++++
> drivers/staging/intel-gwdpa/gswip/gswip_dev.h | 18 +
> drivers/staging/intel-gwdpa/gswip/gswip_mac.c | 225 ++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_port.c | 296 ++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_reg.h | 487 ++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_tbl.c | 345 +++++++++++
> drivers/staging/intel-gwdpa/gswip/gswip_tbl.h | 195 +++++++
> drivers/staging/intel-gwdpa/gswip/lmac.c | 46 ++
> drivers/staging/intel-gwdpa/gswip/mac_cfg.c | 491 ++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/mac_common.h | 237 ++++++++
> drivers/staging/intel-gwdpa/gswip/mac_dev.c | 265 +++++++++
> drivers/staging/intel-gwdpa/gswip/xgmac.c | 636 +++++++++++++++++++++
> drivers/staging/intel-gwdpa/gswip/xgmac.h | 239 ++++++++
> drivers/staging/intel-gwdpa/intel-gwdpa.txt | 264 +++++++++
> 24 files changed, 5284 insertions(+)
<snip>
> --- /dev/null
> +++ b/drivers/staging/intel-gwdpa/TODO
> @@ -0,0 +1,52 @@
> +Intel gateway datapath architecture framework (gwdpa)
> +=====================================================
> +
> +Drivers for gwdpa
> +-----------------
> +1. drivers/staging/intel-gwdpa/gswip
> + patch: switch driver (GSWIP)
> +
> +2. drivers/staging/intel-gwdpa/cqm
> + patch: queue manager (CQM)
Where is this directory?
> +3. drivers/staging/intel-gwdpa/pp
> + patch: packet processor (pp)
And this one?
> +4. drivers/staging/intel-gwdpa/dpm
> + patch: datapath manager (DPM)
> + dependencies: GSWIP, CQM, PP
And this one?
> +5. driver/net/ethernet/intel
> + patch: ethernet driver
> + dependencies: DPM
Why is this listed?
> +6. drivers/staging/intel-gwdpa/dcdp
> + patch: direct connect datapath (DCDP)
> + dependencies: DPM
Where is this one?
> +7.1 drivers/net/wireless
> +7.2 drivers/net/wan
> + patch: wireless driver and DSL driver
> + dependencies: DCDP
What does this even mean?
Have you worked with the Intel Linux networking developers to try to get
this all working properly?
totally confused,
greg k-h
next prev parent reply other threads:[~2019-12-11 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 8:57 [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver Jack Ping CHNG
2019-12-11 9:27 ` Greg KH
[not found] ` <BYAPR11MB317606F8BE2B60C4BAD872F1DE5A0@BYAPR11MB3176.namprd11.prod.outlook.com>
[not found] ` <c26e56cf-eb04-5992-252a-e66f6029d6ac@linux.intel.com>
2019-12-11 12:17 ` FW: " Greg KH
2019-12-11 16:03 ` Andrew Lunn
2019-12-11 9:29 ` Greg KH [this message]
2019-12-11 10:57 ` Dan Carpenter
[not found] ` <BYAPR11MB3176EB0A2BF59AAF161D4174DE5A0@BYAPR11MB3176.namprd11.prod.outlook.com>
2019-12-12 7:25 ` Chng, Jack Ping
2019-12-16 16:16 ` kbuild test robot
2019-12-16 16:16 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211092944.GB505511@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=jack.ping.chng@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.