All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chng, Jack Ping" <jack.ping.chng@linux.intel.com>
To: dan.carpenter@oracle.com
Cc: devel@driverdev.osuosl.org, cheol.yong.kim@intel.com,
	andriy.shevchenko@intel.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	mallikarjunax.reddy@linux.intel.com, gregkh@linuxfoundation.org,
	davem@davemloft.net
Subject: Re: [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver
Date: Thu, 12 Dec 2019 15:25:17 +0800	[thread overview]
Message-ID: <b46dc709-38c7-9c6e-cb75-e5efd3be6ae9@linux.intel.com> (raw)
In-Reply-To: <BYAPR11MB3176EB0A2BF59AAF161D4174DE5A0@BYAPR11MB3176.namprd11.prod.outlook.com>

Hi Dan,

On 11/12/2019 6:58 PM, Dan Carpenter wrote:

> This should just be sent to netdev.  I spotted a couple bugs.
>
> 1) enable/disable we flipped xgmac_set_xgmii_2500_speed()
> 2) retries wasn't reset in a couple places.
>
> I had a few tiny style nits as well but there is no reason to send it to
> staging.
>
> regards,
> dan carpenter

Thanks for the review and comments.
We will fix the bug and address the comments.

Best regards,
Chng Jack Ping


  parent reply	other threads:[~2019-12-12  7:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11  8:57 [PATCH v2] staging: intel-gwdpa: gswip: Introduce Gigabit Ethernet Switch (GSWIP) device driver Jack Ping CHNG
2019-12-11  9:27 ` Greg KH
     [not found]   ` <BYAPR11MB317606F8BE2B60C4BAD872F1DE5A0@BYAPR11MB3176.namprd11.prod.outlook.com>
     [not found]     ` <c26e56cf-eb04-5992-252a-e66f6029d6ac@linux.intel.com>
2019-12-11 12:17       ` FW: " Greg KH
2019-12-11 16:03         ` Andrew Lunn
2019-12-11  9:29 ` Greg KH
2019-12-11 10:57 ` Dan Carpenter
     [not found]   ` <BYAPR11MB3176EB0A2BF59AAF161D4174DE5A0@BYAPR11MB3176.namprd11.prod.outlook.com>
2019-12-12  7:25     ` Chng, Jack Ping [this message]
2019-12-16 16:16 ` kbuild test robot
2019-12-16 16:16   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b46dc709-38c7-9c6e-cb75-e5efd3be6ae9@linux.intel.com \
    --to=jack.ping.chng@linux.intel.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mallikarjunax.reddy@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.