From: Daniel Borkmann <daniel@iogearbox.net>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Shubham Bansal <illusionist.neo@gmail.com>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andriin@fb.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: net: bpf: improve prologue code sequence
Date: Wed, 11 Dec 2019 14:56:15 +0100 [thread overview]
Message-ID: <20191211135615.GA25011@linux.fritz.box> (raw)
In-Reply-To: <E1ieH2g-0004ih-Rb@rmk-PC.armlinux.org.uk>
On Mon, Dec 09, 2019 at 11:17:30AM +0000, Russell King wrote:
> Improve the prologue code sequence to be able to take advantage of
> 64-bit stores, changing the code from:
>
> push {r4, r5, r6, r7, r8, r9, fp, lr}
> mov fp, sp
> sub ip, sp, #80 ; 0x50
> sub sp, sp, #600 ; 0x258
> str ip, [fp, #-100] ; 0xffffff9c
> mov r6, #0
> str r6, [fp, #-96] ; 0xffffffa0
> mov r4, #0
> mov r3, r4
> mov r2, r0
> str r4, [fp, #-104] ; 0xffffff98
> str r4, [fp, #-108] ; 0xffffff94
>
> to the tighter:
>
> push {r4, r5, r6, r7, r8, r9, fp, lr}
> mov fp, sp
> mov r3, #0
> sub r2, sp, #80 ; 0x50
> sub sp, sp, #600 ; 0x258
> strd r2, [fp, #-100] ; 0xffffff9c
> mov r2, #0
> strd r2, [fp, #-108] ; 0xffffff94
> mov r2, r0
>
> resulting in a saving of three instructions.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Borkmann <daniel@iogearbox.net>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Song Liu <songliubraving@fb.com>,
netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Shubham Bansal <illusionist.neo@gmail.com>,
Yonghong Song <yhs@fb.com>,
bpf@vger.kernel.org, Andrii Nakryiko <andriin@fb.com>,
Martin KaFai Lau <kafai@fb.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: net: bpf: improve prologue code sequence
Date: Wed, 11 Dec 2019 14:56:15 +0100 [thread overview]
Message-ID: <20191211135615.GA25011@linux.fritz.box> (raw)
In-Reply-To: <E1ieH2g-0004ih-Rb@rmk-PC.armlinux.org.uk>
On Mon, Dec 09, 2019 at 11:17:30AM +0000, Russell King wrote:
> Improve the prologue code sequence to be able to take advantage of
> 64-bit stores, changing the code from:
>
> push {r4, r5, r6, r7, r8, r9, fp, lr}
> mov fp, sp
> sub ip, sp, #80 ; 0x50
> sub sp, sp, #600 ; 0x258
> str ip, [fp, #-100] ; 0xffffff9c
> mov r6, #0
> str r6, [fp, #-96] ; 0xffffffa0
> mov r4, #0
> mov r3, r4
> mov r2, r0
> str r4, [fp, #-104] ; 0xffffff98
> str r4, [fp, #-108] ; 0xffffff94
>
> to the tighter:
>
> push {r4, r5, r6, r7, r8, r9, fp, lr}
> mov fp, sp
> mov r3, #0
> sub r2, sp, #80 ; 0x50
> sub sp, sp, #600 ; 0x258
> strd r2, [fp, #-100] ; 0xffffff9c
> mov r2, #0
> strd r2, [fp, #-108] ; 0xffffff94
> mov r2, r0
>
> resulting in a saving of three instructions.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-11 13:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 11:17 [PATCH] ARM: net: bpf: improve prologue code sequence Russell King
2019-12-09 11:17 ` Russell King
2019-12-11 13:56 ` Daniel Borkmann [this message]
2019-12-11 13:56 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211135615.GA25011@linux.fritz.box \
--to=daniel@iogearbox.net \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=illusionist.neo@gmail.com \
--cc=kafai@fb.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.