* [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup
@ 2019-12-11 17:58 Sean Christopherson
2019-12-11 17:58 ` [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() Sean Christopherson
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Sean Christopherson @ 2019-12-11 17:58 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Sean Christopherson, Vitaly Kuznetsov, Wanpeng Li, Jim Mattson,
Joerg Roedel, kvm, linux-kernel
Small series to add build-time protections on reverse CPUID lookup (and
other usages of bit()), and to rename the misleading-generic bit() helper
to something that better conveys its purpose.
Sean Christopherson (2):
KVM: x86: Add build-time assertion on usage of bit()
KVM: x86: Refactor and rename bit() to feature_bit() macro
arch/x86/kvm/cpuid.c | 2 +-
arch/x86/kvm/cpuid.h | 4 ++--
arch/x86/kvm/emulate.c | 8 +++-----
arch/x86/kvm/svm.c | 4 ++--
arch/x86/kvm/vmx/vmx.c | 42 +++++++++++++++++++++---------------------
arch/x86/kvm/x86.h | 24 ++++++++++++++++++++++--
6 files changed, 51 insertions(+), 33 deletions(-)
--
2.24.0
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() 2019-12-11 17:58 [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup Sean Christopherson @ 2019-12-11 17:58 ` Sean Christopherson 2019-12-11 18:24 ` Jim Mattson 2019-12-11 17:58 ` [PATCH 2/2] KVM: x86: Refactor and rename bit() to feature_bit() macro Sean Christopherson 2019-12-14 3:35 ` [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup Sean Christopherson 2 siblings, 1 reply; 7+ messages in thread From: Sean Christopherson @ 2019-12-11 17:58 UTC (permalink / raw) To: Paolo Bonzini Cc: Sean Christopherson, Vitaly Kuznetsov, Wanpeng Li, Jim Mattson, Joerg Roedel, kvm, linux-kernel Add build-time checks to ensure KVM isn't trying to do a reverse CPUID lookup on Linux-defined feature bits, along with comments to explain the gory details of X86_FEATUREs and bit(). Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- Note, the premature newline in the first line of the second comment is intentional to reduce churn in the next patch. arch/x86/kvm/x86.h | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h index cab5e71f0f0f..4ee4175c66a7 100644 --- a/arch/x86/kvm/x86.h +++ b/arch/x86/kvm/x86.h @@ -144,9 +144,28 @@ static inline bool is_pae_paging(struct kvm_vcpu *vcpu) return !is_long_mode(vcpu) && is_pae(vcpu) && is_paging(vcpu); } -static inline u32 bit(int bitno) +/* + * Retrieve the bit mask from an X86_FEATURE_* definition. Features contain + * the hardware defined bit number (stored in bits 4:0) and a software defined + * "word" (stored in bits 31:5). The word is used to index into arrays of + * bit masks that hold the per-cpu feature capabilities, e.g. this_cpu_has(). + */ +static __always_inline u32 bit(int feature) { - return 1 << (bitno & 31); + /* + * bit() is intended to be used only for hardware-defined + * words, i.e. words whose bits directly correspond to a CPUID leaf. + * Retrieving the bit mask from a Linux-defined word is nonsensical + * as the bit number/mask is an arbitrary software-defined value and + * can't be used by KVM to query/control guest capabilities. + */ + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_1); + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_2); + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_3); + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_4); + BUILD_BUG_ON((feature >> 5) > CPUID_7_EDX); + + return 1 << (feature & 31); } static inline u8 vcpu_virt_addr_bits(struct kvm_vcpu *vcpu) -- 2.24.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() 2019-12-11 17:58 ` [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() Sean Christopherson @ 2019-12-11 18:24 ` Jim Mattson 2019-12-11 19:18 ` Sean Christopherson 0 siblings, 1 reply; 7+ messages in thread From: Jim Mattson @ 2019-12-11 18:24 UTC (permalink / raw) To: Sean Christopherson Cc: Paolo Bonzini, Vitaly Kuznetsov, Wanpeng Li, Joerg Roedel, kvm list, LKML On Wed, Dec 11, 2019 at 9:58 AM Sean Christopherson <sean.j.christopherson@intel.com> wrote: > > Add build-time checks to ensure KVM isn't trying to do a reverse CPUID > lookup on Linux-defined feature bits, along with comments to explain > the gory details of X86_FEATUREs and bit(). > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > --- > > Note, the premature newline in the first line of the second comment is > intentional to reduce churn in the next patch. > > arch/x86/kvm/x86.h | 23 +++++++++++++++++++++-- > 1 file changed, 21 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h > index cab5e71f0f0f..4ee4175c66a7 100644 > --- a/arch/x86/kvm/x86.h > +++ b/arch/x86/kvm/x86.h > @@ -144,9 +144,28 @@ static inline bool is_pae_paging(struct kvm_vcpu *vcpu) > return !is_long_mode(vcpu) && is_pae(vcpu) && is_paging(vcpu); > } > > -static inline u32 bit(int bitno) > +/* > + * Retrieve the bit mask from an X86_FEATURE_* definition. Features contain > + * the hardware defined bit number (stored in bits 4:0) and a software defined > + * "word" (stored in bits 31:5). The word is used to index into arrays of > + * bit masks that hold the per-cpu feature capabilities, e.g. this_cpu_has(). > + */ > +static __always_inline u32 bit(int feature) > { > - return 1 << (bitno & 31); > + /* > + * bit() is intended to be used only for hardware-defined > + * words, i.e. words whose bits directly correspond to a CPUID leaf. > + * Retrieving the bit mask from a Linux-defined word is nonsensical > + * as the bit number/mask is an arbitrary software-defined value and > + * can't be used by KVM to query/control guest capabilities. > + */ > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_1); > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_2); > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_3); > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_4); > + BUILD_BUG_ON((feature >> 5) > CPUID_7_EDX); What is magical about CPUID_7_EDX? > + > + return 1 << (feature & 31); Why not BIT(feature & 31)? > } > > static inline u8 vcpu_virt_addr_bits(struct kvm_vcpu *vcpu) > -- > 2.24.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() 2019-12-11 18:24 ` Jim Mattson @ 2019-12-11 19:18 ` Sean Christopherson 0 siblings, 0 replies; 7+ messages in thread From: Sean Christopherson @ 2019-12-11 19:18 UTC (permalink / raw) To: Jim Mattson Cc: Paolo Bonzini, Vitaly Kuznetsov, Wanpeng Li, Joerg Roedel, kvm list, LKML On Wed, Dec 11, 2019 at 10:24:36AM -0800, Jim Mattson wrote: > On Wed, Dec 11, 2019 at 9:58 AM Sean Christopherson > <sean.j.christopherson@intel.com> wrote: > > > > Add build-time checks to ensure KVM isn't trying to do a reverse CPUID > > lookup on Linux-defined feature bits, along with comments to explain > > the gory details of X86_FEATUREs and bit(). > > > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> > > --- > > > > Note, the premature newline in the first line of the second comment is > > intentional to reduce churn in the next patch. > > > > arch/x86/kvm/x86.h | 23 +++++++++++++++++++++-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h > > index cab5e71f0f0f..4ee4175c66a7 100644 > > --- a/arch/x86/kvm/x86.h > > +++ b/arch/x86/kvm/x86.h > > @@ -144,9 +144,28 @@ static inline bool is_pae_paging(struct kvm_vcpu *vcpu) > > return !is_long_mode(vcpu) && is_pae(vcpu) && is_paging(vcpu); > > } > > > > -static inline u32 bit(int bitno) > > +/* > > + * Retrieve the bit mask from an X86_FEATURE_* definition. Features contain > > + * the hardware defined bit number (stored in bits 4:0) and a software defined > > + * "word" (stored in bits 31:5). The word is used to index into arrays of > > + * bit masks that hold the per-cpu feature capabilities, e.g. this_cpu_has(). > > + */ > > +static __always_inline u32 bit(int feature) > > { > > - return 1 << (bitno & 31); > > + /* > > + * bit() is intended to be used only for hardware-defined > > + * words, i.e. words whose bits directly correspond to a CPUID leaf. > > + * Retrieving the bit mask from a Linux-defined word is nonsensical > > + * as the bit number/mask is an arbitrary software-defined value and > > + * can't be used by KVM to query/control guest capabilities. > > + */ > > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_1); > > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_2); > > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_3); > > + BUILD_BUG_ON((feature >> 5) == CPUID_LNX_4); > > + BUILD_BUG_ON((feature >> 5) > CPUID_7_EDX); > > What is magical about CPUID_7_EDX? It's currently the last cpufeatures word. My thought was to force this to be updated in order to do reverse lookup on the next new word. I didn't want to use NCAPINTS because that gets updated when a new word is added to cpufeatures, i.e. wouldn't catch the case where the next new word is a Linux-defined word, which is extremely unlikely but theoretically possible. > > + > > + return 1 << (feature & 31); > > Why not BIT(feature & 31)? That's a very good question. > > } > > > > static inline u8 vcpu_virt_addr_bits(struct kvm_vcpu *vcpu) > > -- > > 2.24.0 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] KVM: x86: Refactor and rename bit() to feature_bit() macro 2019-12-11 17:58 [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup Sean Christopherson 2019-12-11 17:58 ` [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() Sean Christopherson @ 2019-12-11 17:58 ` Sean Christopherson 2019-12-11 18:27 ` Jim Mattson 2019-12-14 3:35 ` [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup Sean Christopherson 2 siblings, 1 reply; 7+ messages in thread From: Sean Christopherson @ 2019-12-11 17:58 UTC (permalink / raw) To: Paolo Bonzini Cc: Sean Christopherson, Vitaly Kuznetsov, Wanpeng Li, Jim Mattson, Joerg Roedel, kvm, linux-kernel Rename bit() to __feature_bit() to give it a more descriptive name, and add a macro, feature_bit(), to stuff the X68_FEATURE_ prefix to keep line lengths manageable for code that hardcodes the bit to be retrieved. No functional change intended. Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> --- arch/x86/kvm/cpuid.c | 2 +- arch/x86/kvm/cpuid.h | 4 ++-- arch/x86/kvm/emulate.c | 8 +++----- arch/x86/kvm/svm.c | 4 ++-- arch/x86/kvm/vmx/vmx.c | 42 +++++++++++++++++++++--------------------- arch/x86/kvm/x86.h | 5 +++-- 6 files changed, 32 insertions(+), 33 deletions(-) diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c index cfafa320a8cf..2b80948f5ddb 100644 --- a/arch/x86/kvm/cpuid.c +++ b/arch/x86/kvm/cpuid.c @@ -62,7 +62,7 @@ u64 kvm_supported_xcr0(void) return xcr0; } -#define F(x) bit(X86_FEATURE_##x) +#define F feature_bit int kvm_update_cpuid(struct kvm_vcpu *vcpu) { diff --git a/arch/x86/kvm/cpuid.h b/arch/x86/kvm/cpuid.h index d78a61408243..5a96037e8fd7 100644 --- a/arch/x86/kvm/cpuid.h +++ b/arch/x86/kvm/cpuid.h @@ -101,7 +101,7 @@ static __always_inline bool guest_cpuid_has(struct kvm_vcpu *vcpu, unsigned x86_ if (!reg) return false; - return *reg & bit(x86_feature); + return *reg & __feature_bit(x86_feature); } static __always_inline void guest_cpuid_clear(struct kvm_vcpu *vcpu, unsigned x86_feature) @@ -110,7 +110,7 @@ static __always_inline void guest_cpuid_clear(struct kvm_vcpu *vcpu, unsigned x8 reg = guest_cpuid_get_register(vcpu, x86_feature); if (reg) - *reg &= ~bit(x86_feature); + *reg &= ~__feature_bit(x86_feature); } static inline bool guest_cpuid_is_amd(struct kvm_vcpu *vcpu) diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index 952d1a4f4d7e..acb21e5b7e61 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -2353,7 +2353,7 @@ static int emulator_has_longmode(struct x86_emulate_ctxt *ctxt) eax = 0x80000001; ecx = 0; ctxt->ops->get_cpuid(ctxt, &eax, &ebx, &ecx, &edx, false); - return edx & bit(X86_FEATURE_LM); + return edx & feature_bit(LM); #else return false; #endif @@ -3618,8 +3618,6 @@ static int em_mov(struct x86_emulate_ctxt *ctxt) return X86EMUL_CONTINUE; } -#define FFL(x) bit(X86_FEATURE_##x) - static int em_movbe(struct x86_emulate_ctxt *ctxt) { u32 ebx, ecx, edx, eax = 1; @@ -3629,7 +3627,7 @@ static int em_movbe(struct x86_emulate_ctxt *ctxt) * Check MOVBE is set in the guest-visible CPUID leaf. */ ctxt->ops->get_cpuid(ctxt, &eax, &ebx, &ecx, &edx, false); - if (!(ecx & FFL(MOVBE))) + if (!(ecx & feature_bit(MOVBE))) return emulate_ud(ctxt); switch (ctxt->op_bytes) { @@ -4030,7 +4028,7 @@ static int check_fxsr(struct x86_emulate_ctxt *ctxt) u32 eax = 1, ebx, ecx = 0, edx; ctxt->ops->get_cpuid(ctxt, &eax, &ebx, &ecx, &edx, false); - if (!(edx & FFL(FXSR))) + if (!(edx & feature_bit(FXSR))) return emulate_ud(ctxt); if (ctxt->ops->get_cr(ctxt, 0) & (X86_CR0_TS | X86_CR0_EM)) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 8f1b715dfde8..832b8ad5a178 100644 --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -5924,14 +5924,14 @@ static void svm_cpuid_update(struct kvm_vcpu *vcpu) guest_cpuid_clear(vcpu, X86_FEATURE_X2APIC); } -#define F(x) bit(X86_FEATURE_##x) +#define F feature_bit static void svm_set_supported_cpuid(u32 func, struct kvm_cpuid_entry2 *entry) { switch (func) { case 0x1: if (avic) - entry->ecx &= ~bit(X86_FEATURE_X2APIC); + entry->ecx &= ~F(X2APIC); break; case 0x80000001: if (nested) diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c index 51e3b27f90ed..3608de5649f2 100644 --- a/arch/x86/kvm/vmx/vmx.c +++ b/arch/x86/kvm/vmx/vmx.c @@ -6979,28 +6979,28 @@ static void nested_vmx_cr_fixed1_bits_update(struct kvm_vcpu *vcpu) } while (0) entry = kvm_find_cpuid_entry(vcpu, 0x1, 0); - cr4_fixed1_update(X86_CR4_VME, edx, bit(X86_FEATURE_VME)); - cr4_fixed1_update(X86_CR4_PVI, edx, bit(X86_FEATURE_VME)); - cr4_fixed1_update(X86_CR4_TSD, edx, bit(X86_FEATURE_TSC)); - cr4_fixed1_update(X86_CR4_DE, edx, bit(X86_FEATURE_DE)); - cr4_fixed1_update(X86_CR4_PSE, edx, bit(X86_FEATURE_PSE)); - cr4_fixed1_update(X86_CR4_PAE, edx, bit(X86_FEATURE_PAE)); - cr4_fixed1_update(X86_CR4_MCE, edx, bit(X86_FEATURE_MCE)); - cr4_fixed1_update(X86_CR4_PGE, edx, bit(X86_FEATURE_PGE)); - cr4_fixed1_update(X86_CR4_OSFXSR, edx, bit(X86_FEATURE_FXSR)); - cr4_fixed1_update(X86_CR4_OSXMMEXCPT, edx, bit(X86_FEATURE_XMM)); - cr4_fixed1_update(X86_CR4_VMXE, ecx, bit(X86_FEATURE_VMX)); - cr4_fixed1_update(X86_CR4_SMXE, ecx, bit(X86_FEATURE_SMX)); - cr4_fixed1_update(X86_CR4_PCIDE, ecx, bit(X86_FEATURE_PCID)); - cr4_fixed1_update(X86_CR4_OSXSAVE, ecx, bit(X86_FEATURE_XSAVE)); + cr4_fixed1_update(X86_CR4_VME, edx, feature_bit(VME)); + cr4_fixed1_update(X86_CR4_PVI, edx, feature_bit(VME)); + cr4_fixed1_update(X86_CR4_TSD, edx, feature_bit(TSC)); + cr4_fixed1_update(X86_CR4_DE, edx, feature_bit(DE)); + cr4_fixed1_update(X86_CR4_PSE, edx, feature_bit(PSE)); + cr4_fixed1_update(X86_CR4_PAE, edx, feature_bit(PAE)); + cr4_fixed1_update(X86_CR4_MCE, edx, feature_bit(MCE)); + cr4_fixed1_update(X86_CR4_PGE, edx, feature_bit(PGE)); + cr4_fixed1_update(X86_CR4_OSFXSR, edx, feature_bit(FXSR)); + cr4_fixed1_update(X86_CR4_OSXMMEXCPT, edx, feature_bit(XMM)); + cr4_fixed1_update(X86_CR4_VMXE, ecx, feature_bit(VMX)); + cr4_fixed1_update(X86_CR4_SMXE, ecx, feature_bit(SMX)); + cr4_fixed1_update(X86_CR4_PCIDE, ecx, feature_bit(PCID)); + cr4_fixed1_update(X86_CR4_OSXSAVE, ecx, feature_bit(XSAVE)); entry = kvm_find_cpuid_entry(vcpu, 0x7, 0); - cr4_fixed1_update(X86_CR4_FSGSBASE, ebx, bit(X86_FEATURE_FSGSBASE)); - cr4_fixed1_update(X86_CR4_SMEP, ebx, bit(X86_FEATURE_SMEP)); - cr4_fixed1_update(X86_CR4_SMAP, ebx, bit(X86_FEATURE_SMAP)); - cr4_fixed1_update(X86_CR4_PKE, ecx, bit(X86_FEATURE_PKU)); - cr4_fixed1_update(X86_CR4_UMIP, ecx, bit(X86_FEATURE_UMIP)); - cr4_fixed1_update(X86_CR4_LA57, ecx, bit(X86_FEATURE_LA57)); + cr4_fixed1_update(X86_CR4_FSGSBASE, ebx, feature_bit(FSGSBASE)); + cr4_fixed1_update(X86_CR4_SMEP, ebx, feature_bit(SMEP)); + cr4_fixed1_update(X86_CR4_SMAP, ebx, feature_bit(SMAP)); + cr4_fixed1_update(X86_CR4_PKE, ecx, feature_bit(PKU)); + cr4_fixed1_update(X86_CR4_UMIP, ecx, feature_bit(UMIP)); + cr4_fixed1_update(X86_CR4_LA57, ecx, feature_bit(LA57)); #undef cr4_fixed1_update } @@ -7134,7 +7134,7 @@ static void vmx_cpuid_update(struct kvm_vcpu *vcpu) static void vmx_set_supported_cpuid(u32 func, struct kvm_cpuid_entry2 *entry) { if (func == 1 && nested) - entry->ecx |= bit(X86_FEATURE_VMX); + entry->ecx |= feature_bit(VMX); } static void vmx_request_immediate_exit(struct kvm_vcpu *vcpu) diff --git a/arch/x86/kvm/x86.h b/arch/x86/kvm/x86.h index 4ee4175c66a7..d6ea2e0b24f1 100644 --- a/arch/x86/kvm/x86.h +++ b/arch/x86/kvm/x86.h @@ -150,10 +150,10 @@ static inline bool is_pae_paging(struct kvm_vcpu *vcpu) * "word" (stored in bits 31:5). The word is used to index into arrays of * bit masks that hold the per-cpu feature capabilities, e.g. this_cpu_has(). */ -static __always_inline u32 bit(int feature) +static __always_inline u32 __feature_bit(u32 feature) { /* - * bit() is intended to be used only for hardware-defined + * __feature_bit() is intended to be used only for hardware-defined * words, i.e. words whose bits directly correspond to a CPUID leaf. * Retrieving the bit mask from a Linux-defined word is nonsensical * as the bit number/mask is an arbitrary software-defined value and @@ -167,6 +167,7 @@ static __always_inline u32 bit(int feature) return 1 << (feature & 31); } +#define feature_bit(name) __feature_bit(X86_FEATURE_##name) static inline u8 vcpu_virt_addr_bits(struct kvm_vcpu *vcpu) { -- 2.24.0 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] KVM: x86: Refactor and rename bit() to feature_bit() macro 2019-12-11 17:58 ` [PATCH 2/2] KVM: x86: Refactor and rename bit() to feature_bit() macro Sean Christopherson @ 2019-12-11 18:27 ` Jim Mattson 0 siblings, 0 replies; 7+ messages in thread From: Jim Mattson @ 2019-12-11 18:27 UTC (permalink / raw) To: Sean Christopherson Cc: Paolo Bonzini, Vitaly Kuznetsov, Wanpeng Li, Joerg Roedel, kvm list, LKML On Wed, Dec 11, 2019 at 9:58 AM Sean Christopherson <sean.j.christopherson@intel.com> wrote: > > Rename bit() to __feature_bit() to give it a more descriptive name, and > add a macro, feature_bit(), to stuff the X68_FEATURE_ prefix to keep > line lengths manageable for code that hardcodes the bit to be retrieved. > > No functional change intended. > > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> Reviewed-by: Jim Mattson <jmattson@google.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup 2019-12-11 17:58 [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup Sean Christopherson 2019-12-11 17:58 ` [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() Sean Christopherson 2019-12-11 17:58 ` [PATCH 2/2] KVM: x86: Refactor and rename bit() to feature_bit() macro Sean Christopherson @ 2019-12-14 3:35 ` Sean Christopherson 2 siblings, 0 replies; 7+ messages in thread From: Sean Christopherson @ 2019-12-14 3:35 UTC (permalink / raw) To: Paolo Bonzini Cc: Vitaly Kuznetsov, Wanpeng Li, Jim Mattson, Joerg Roedel, kvm, linux-kernel On Wed, Dec 11, 2019 at 09:58:20AM -0800, Sean Christopherson wrote: > Small series to add build-time protections on reverse CPUID lookup (and > other usages of bit()), and to rename the misleading-generic bit() helper > to something that better conveys its purpose. Paolo, please don't merge this even though Jim's feedback was minor, I have a revamped version that I'll send out next week. Thanks! ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-12-14 3:35 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-12-11 17:58 [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup Sean Christopherson 2019-12-11 17:58 ` [PATCH 1/2] KVM: x86: Add build-time assertion on usage of bit() Sean Christopherson 2019-12-11 18:24 ` Jim Mattson 2019-12-11 19:18 ` Sean Christopherson 2019-12-11 17:58 ` [PATCH 2/2] KVM: x86: Refactor and rename bit() to feature_bit() macro Sean Christopherson 2019-12-11 18:27 ` Jim Mattson 2019-12-14 3:35 ` [PATCH 0/2] KVM: x86: X86_FEATURE bit() cleanup Sean Christopherson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.