* [morimoto-linux:fw-cleanup-2019-12-04-v1 419/453] sound/soc/codecs/max98090.c:2139:9: error: implicit declaration of function 'snd_soc_component_read32'; did you mean 'snd_soc_component_read'?
@ 2019-12-11 16:25 kbuild test robot
0 siblings, 0 replies; only message in thread
From: kbuild test robot @ 2019-12-11 16:25 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4585 bytes --]
tree: https://github.com/morimoto/linux fw-cleanup-2019-12-04-v1
head: d2c9fb0fe38242747a515c050a9a6c697c51d17e
commit: 60417f62648cc92ea02205b53a248c2a68db9f77 [419/453] ASoC: remove snd_soc_component_read32()
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 60417f62648cc92ea02205b53a248c2a68db9f77
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
sound/soc/codecs/max98090.c: In function 'max98090_pll_work':
>> sound/soc/codecs/max98090.c:2139:9: error: implicit declaration of function 'snd_soc_component_read32'; did you mean 'snd_soc_component_read'? [-Werror=implicit-function-declaration]
pll = snd_soc_component_read32(
^~~~~~~~~~~~~~~~~~~~~~~~
snd_soc_component_read
cc1: some warnings being treated as errors
vim +2139 sound/soc/codecs/max98090.c
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2109
45dfbf56975994 Tzung-Bi Shih 2019-11-22 2110 static void max98090_pll_work(struct max98090_priv *max98090)
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2111 {
4c66b9d165e099 Kuninori Morimoto 2018-01-29 2112 struct snd_soc_component *component = max98090->component;
6f49919d11690a Tzung-Bi Shih 2019-11-22 2113 unsigned int pll;
6f49919d11690a Tzung-Bi Shih 2019-11-22 2114 int i;
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2115
e752b61e6562a1 Kuninori Morimoto 2019-08-22 2116 if (!snd_soc_component_activity(component))
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2117 return;
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2118
4c66b9d165e099 Kuninori Morimoto 2018-01-29 2119 dev_info_ratelimited(component->dev, "PLL unlocked\n");
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2120
acb874a7c049ec Tzung-Bi Shih 2019-11-22 2121 /*
acb874a7c049ec Tzung-Bi Shih 2019-11-22 2122 * As the datasheet suggested, the maximum PLL lock time should be
acb874a7c049ec Tzung-Bi Shih 2019-11-22 2123 * 7 msec. The workaround resets the codec softly by toggling SHDN
acb874a7c049ec Tzung-Bi Shih 2019-11-22 2124 * off and on if PLL failed to lock for 10 msec. Notably, there is
acb874a7c049ec Tzung-Bi Shih 2019-11-22 2125 * no suggested hold time for SHDN off.
acb874a7c049ec Tzung-Bi Shih 2019-11-22 2126 */
acb874a7c049ec Tzung-Bi Shih 2019-11-22 2127
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2128 /* Toggle shutdown OFF then ON */
4c66b9d165e099 Kuninori Morimoto 2018-01-29 2129 snd_soc_component_update_bits(component, M98090_REG_DEVICE_SHUTDOWN,
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2130 M98090_SHDNN_MASK, 0);
4c66b9d165e099 Kuninori Morimoto 2018-01-29 2131 snd_soc_component_update_bits(component, M98090_REG_DEVICE_SHUTDOWN,
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2132 M98090_SHDNN_MASK, M98090_SHDNN_MASK);
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2133
6f49919d11690a Tzung-Bi Shih 2019-11-22 2134 for (i = 0; i < 10; ++i) {
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2135 /* Give PLL time to lock */
6f49919d11690a Tzung-Bi Shih 2019-11-22 2136 usleep_range(1000, 1200);
6f49919d11690a Tzung-Bi Shih 2019-11-22 2137
6f49919d11690a Tzung-Bi Shih 2019-11-22 2138 /* Check lock status */
6f49919d11690a Tzung-Bi Shih 2019-11-22 @2139 pll = snd_soc_component_read32(
6f49919d11690a Tzung-Bi Shih 2019-11-22 2140 component, M98090_REG_DEVICE_STATUS);
6f49919d11690a Tzung-Bi Shih 2019-11-22 2141 if (!(pll & M98090_ULK_MASK))
6f49919d11690a Tzung-Bi Shih 2019-11-22 2142 break;
6f49919d11690a Tzung-Bi Shih 2019-11-22 2143 }
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2144 }
b8a3ee820f7b08 Jarkko Nikula 2014-09-03 2145
:::::: The code@line 2139 was first introduced by commit
:::::: 6f49919d11690a9b5614445ba30fde18083fdd63 ASoC: max98090: exit workaround earlier if PLL is locked
:::::: TO: Tzung-Bi Shih <tzungbi@google.com>
:::::: CC: Mark Brown <broonie@kernel.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org Intel Corporation
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 52281 bytes --]
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-12-11 16:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 16:25 [morimoto-linux:fw-cleanup-2019-12-04-v1 419/453] sound/soc/codecs/max98090.c:2139:9: error: implicit declaration of function 'snd_soc_component_read32'; did you mean 'snd_soc_component_read'? kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.