* [Intel-gfx] [PATCH] drm/i915/gt: Mark up ips_mchdev pointer access
@ 2019-12-11 22:50 Chris Wilson
2019-12-12 3:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chris Wilson @ 2019-12-11 22:50 UTC (permalink / raw)
To: intel-gfx
drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: error: incompatible types in comparison expression (different address spaces):
drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: struct drm_i915_private [noderef] <asn:4> *
drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: struct drm_i915_private *
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/gt/intel_rps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
index fd01e4100fc1..106c9fce9d6c 100644
--- a/drivers/gpu/drm/i915/gt/intel_rps.c
+++ b/drivers/gpu/drm/i915/gt/intel_rps.c
@@ -1723,7 +1723,7 @@ void intel_rps_driver_register(struct intel_rps *rps)
void intel_rps_driver_unregister(struct intel_rps *rps)
{
- if (ips_mchdev == rps_to_i915(rps))
+ if (rcu_access_pointer(ips_mchdev) == rps_to_i915(rps))
rcu_assign_pointer(ips_mchdev, NULL);
}
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gt: Mark up ips_mchdev pointer access
2019-12-11 22:50 [Intel-gfx] [PATCH] drm/i915/gt: Mark up ips_mchdev pointer access Chris Wilson
@ 2019-12-12 3:18 ` Patchwork
2019-12-12 3:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-12 8:13 ` [Intel-gfx] [PATCH] " Venkata Sandeep Dhanalakota
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-12-12 3:18 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Mark up ips_mchdev pointer access
URL : https://patchwork.freedesktop.org/series/70792/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915/gt: Mark up ips_mchdev pointer access
-O:drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: error: incompatible types in comparison expression (different address spaces)
+
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Mark up ips_mchdev pointer access
2019-12-11 22:50 [Intel-gfx] [PATCH] drm/i915/gt: Mark up ips_mchdev pointer access Chris Wilson
2019-12-12 3:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
@ 2019-12-12 3:49 ` Patchwork
2019-12-12 8:13 ` [Intel-gfx] [PATCH] " Venkata Sandeep Dhanalakota
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-12-12 3:49 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/gt: Mark up ips_mchdev pointer access
URL : https://patchwork.freedesktop.org/series/70792/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7545 -> Patchwork_15703
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15703 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15703, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15703:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_gt_pm:
- fi-kbl-x1275: NOTRUN -> [DMESG-FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-kbl-x1275/igt@i915_selftest@live_gt_pm.html
Known issues
------------
Here are the changes found in Patchwork_15703 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- fi-ilk-650: [PASS][2] -> [DMESG-WARN][3] ([i915#116])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-ilk-650/igt@gem_exec_suspend@basic-s3.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-ilk-650/igt@gem_exec_suspend@basic-s3.html
* igt@i915_selftest@live_gem_contexts:
- fi-skl-lmem: [PASS][4] -> [INCOMPLETE][5] ([i915#424])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
- fi-hsw-peppy: [PASS][6] -> [INCOMPLETE][7] ([i915#694])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html
- fi-byt-n2820: [PASS][8] -> [INCOMPLETE][9] ([i915#45])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-byt-n2820/igt@i915_selftest@live_gem_contexts.html
#### Possible fixes ####
* igt@i915_selftest@live_blt:
- fi-ivb-3770: [DMESG-FAIL][10] ([i915#725]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-ivb-3770/igt@i915_selftest@live_blt.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-ivb-3770/igt@i915_selftest@live_blt.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][12] ([fdo#111096] / [i915#323]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
#### Warnings ####
* igt@gem_exec_suspend@basic-s4-devices:
- fi-kbl-x1275: [DMESG-WARN][14] ([fdo#107139] / [i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][15] ([fdo#107139] / [i915#62] / [i915#92])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-kbl-x1275/igt@gem_exec_suspend@basic-s4-devices.html
* igt@i915_module_load@reload:
- fi-icl-u2: [DMESG-WARN][16] ([i915#109] / [i915#289]) -> [DMESG-WARN][17] ([i915#289])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-icl-u2/igt@i915_module_load@reload.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-icl-u2/igt@i915_module_load@reload.html
* igt@i915_selftest@live_blt:
- fi-hsw-4770r: [DMESG-FAIL][18] ([i915#553] / [i915#725]) -> [DMESG-FAIL][19] ([i915#725])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-hsw-4770r/igt@i915_selftest@live_blt.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-hsw-4770r/igt@i915_selftest@live_blt.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][20] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][21] ([i915#62] / [i915#92]) +4 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
* igt@kms_pipe_crc_basic@read-crc-pipe-a:
- fi-kbl-x1275: [DMESG-WARN][22] ([i915#62] / [i915#92]) -> [DMESG-WARN][23] ([i915#62] / [i915#92] / [i915#95]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7545/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107139]: https://bugs.freedesktop.org/show_bug.cgi?id=107139
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
[i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109
[i915#116]: https://gitlab.freedesktop.org/drm/intel/issues/116
[i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289
[i915#323]: https://gitlab.freedesktop.org/drm/intel/issues/323
[i915#424]: https://gitlab.freedesktop.org/drm/intel/issues/424
[i915#45]: https://gitlab.freedesktop.org/drm/intel/issues/45
[i915#553]: https://gitlab.freedesktop.org/drm/intel/issues/553
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694
[i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (52 -> 46)
------------------------------
Missing (6): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7545 -> Patchwork_15703
CI-20190529: 20190529
CI_DRM_7545: b1b808dff985c3c2050b20771050453589a60ca3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5346: 466b0e6cbcbaccff012b484d1fd7676364b37b93 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15703: 96374d1f00f16e132418d8eebc66224ad93fd9cd @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
96374d1f00f1 drm/i915/gt: Mark up ips_mchdev pointer access
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15703/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-gfx] [PATCH] drm/i915/gt: Mark up ips_mchdev pointer access
2019-12-11 22:50 [Intel-gfx] [PATCH] drm/i915/gt: Mark up ips_mchdev pointer access Chris Wilson
2019-12-12 3:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-12-12 3:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
@ 2019-12-12 8:13 ` Venkata Sandeep Dhanalakota
2 siblings, 0 replies; 4+ messages in thread
From: Venkata Sandeep Dhanalakota @ 2019-12-12 8:13 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On 19/12/11 10:50, Chris Wilson wrote:
> drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: error: incompatible types in comparison expression (different address spaces):
> drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: struct drm_i915_private [noderef] <asn:4> *
> drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: struct drm_i915_private *
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index fd01e4100fc1..106c9fce9d6c 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -1723,7 +1723,7 @@ void intel_rps_driver_register(struct intel_rps *rps)
>
> void intel_rps_driver_unregister(struct intel_rps *rps)
> {
> - if (ips_mchdev == rps_to_i915(rps))
> + if (rcu_access_pointer(ips_mchdev) == rps_to_i915(rps))
> rcu_assign_pointer(ips_mchdev, NULL);
> }
My bad, I missed to spot this in previous patch.
Can we squash this with the other patch, if it was not merged already?
>
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-12 8:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 22:50 [Intel-gfx] [PATCH] drm/i915/gt: Mark up ips_mchdev pointer access Chris Wilson
2019-12-12 3:18 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2019-12-12 3:49 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2019-12-12 8:13 ` [Intel-gfx] [PATCH] " Venkata Sandeep Dhanalakota
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.