From: Greg KH <gregkh@linuxfoundation.org>
To: Vitor Soares <Vitor.Soares@synopsys.com>
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>
Subject: Re: [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev
Date: Thu, 12 Dec 2019 17:00:45 +0100 [thread overview]
Message-ID: <20191212160045.GA1672362@kroah.com> (raw)
In-Reply-To: <CH2PR12MB421658E00DF331400728DB6CAE550@CH2PR12MB4216.namprd12.prod.outlook.com>
On Thu, Dec 12, 2019 at 02:56:56PM +0000, Vitor Soares wrote:
> Hi Greg,
>
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Thu, Dec 12, 2019 at 14:44:59
>
> > On Tue, Dec 10, 2019 at 04:37:33PM +0100, Vitor Soares wrote:
> > > +static int __init i3cdev_init(void)
> > > +{
> > > + int res;
> > > +
> > > + pr_info("i3c /dev entries driver\n");
> >
> > Please remove debugging information, kernel code should be quiet unless
> > something goes wrong.
>
> I will remove it.
>
> >
> > > + /* Dynamically request unused major number */
> > > + res = alloc_chrdev_region(&i3cdev_number, 0, N_I3C_MINORS, "i3c");
> >
> > Do you really need a whole major, or will a few minors work?
> >
> > thanks,
> >
> > greg k-h
>
> I'm reserving one per device. What do you suggest?
How many devices do you have in a system?
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Vitor Soares <Vitor.Soares@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"wsa@the-dreams.de" <wsa@the-dreams.de>,
"arnd@arndb.de" <arnd@arndb.de>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev
Date: Thu, 12 Dec 2019 17:00:45 +0100 [thread overview]
Message-ID: <20191212160045.GA1672362@kroah.com> (raw)
In-Reply-To: <CH2PR12MB421658E00DF331400728DB6CAE550@CH2PR12MB4216.namprd12.prod.outlook.com>
On Thu, Dec 12, 2019 at 02:56:56PM +0000, Vitor Soares wrote:
> Hi Greg,
>
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Thu, Dec 12, 2019 at 14:44:59
>
> > On Tue, Dec 10, 2019 at 04:37:33PM +0100, Vitor Soares wrote:
> > > +static int __init i3cdev_init(void)
> > > +{
> > > + int res;
> > > +
> > > + pr_info("i3c /dev entries driver\n");
> >
> > Please remove debugging information, kernel code should be quiet unless
> > something goes wrong.
>
> I will remove it.
>
> >
> > > + /* Dynamically request unused major number */
> > > + res = alloc_chrdev_region(&i3cdev_number, 0, N_I3C_MINORS, "i3c");
> >
> > Do you really need a whole major, or will a few minors work?
> >
> > thanks,
> >
> > greg k-h
>
> I'm reserving one per device. What do you suggest?
How many devices do you have in a system?
next prev parent reply other threads:[~2019-12-16 18:36 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 15:37 [RFC 0/5] Introduce i3c device userspace interface Vitor Soares
2019-12-10 15:37 ` Vitor Soares
2019-12-10 15:37 ` [RFC 1/5] i3c: master: export i3c_masterdev_type Vitor Soares
2019-12-10 15:37 ` Vitor Soares
2019-12-10 15:37 ` [RFC 2/5] i3c: master: export i3c_bus_type symbol Vitor Soares
2019-12-10 15:37 ` Vitor Soares
2019-12-10 15:37 ` [RFC 3/5] i3c: device: expose transfer strutures to uapi Vitor Soares
2019-12-10 15:37 ` Vitor Soares
2019-12-12 14:42 ` Greg KH
2019-12-12 14:42 ` Greg KH
2019-12-12 14:48 ` Vitor Soares
2019-12-12 14:48 ` Vitor Soares
2019-12-10 15:37 ` [RFC 4/5] i3c: master: add i3c_for_each_dev helper Vitor Soares
2019-12-10 15:37 ` Vitor Soares
2019-12-10 15:37 ` [RFC 5/5] i3c: add i3cdev module to expose i3c dev in /dev Vitor Soares
2019-12-10 15:37 ` Vitor Soares
2019-12-10 17:51 ` Arnd Bergmann
2019-12-10 17:51 ` Arnd Bergmann
2019-12-10 19:15 ` Vitor Soares
2019-12-10 19:15 ` Vitor Soares
2019-12-10 19:37 ` Arnd Bergmann
2019-12-10 19:37 ` Arnd Bergmann
2019-12-11 15:07 ` Vitor Soares
2019-12-11 15:07 ` Vitor Soares
2019-12-11 15:33 ` Arnd Bergmann
2019-12-11 15:33 ` Arnd Bergmann
2019-12-20 12:39 ` Vitor Soares
2019-12-20 12:39 ` Vitor Soares
2019-12-12 14:44 ` Greg KH
2019-12-12 14:44 ` Greg KH
2019-12-12 14:56 ` Vitor Soares
2019-12-12 14:56 ` Vitor Soares
2019-12-12 16:00 ` Greg KH [this message]
2019-12-12 16:00 ` Greg KH
2019-12-12 17:25 ` Vitor Soares
2019-12-12 17:25 ` Vitor Soares
2019-12-12 17:32 ` Greg KH
2019-12-12 17:32 ` Greg KH
2019-12-12 14:46 ` Greg KH
2019-12-12 14:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212160045.GA1672362@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Joao.Pinto@synopsys.com \
--cc=Vitor.Soares@synopsys.com \
--cc=arnd@arndb.de \
--cc=bbrezillon@kernel.org \
--cc=broonie@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.