All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, virtio-dev@lists.oasis-open.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org
Subject: [virtio-dev] [PATCH RFC v4 11/13] mm/vmscan: Move count_vm_event(DROP_SLAB) into drop_slab()
Date: Thu, 12 Dec 2019 18:11:35 +0100	[thread overview]
Message-ID: <20191212171137.13872-12-david@redhat.com> (raw)
In-Reply-To: <20191212171137.13872-1-david@redhat.com>

Let's count within the function itself, so every invocation (of future
users) will be counted.

Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 fs/drop_caches.c | 4 +---
 mm/vmscan.c      | 1 +
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/drop_caches.c b/fs/drop_caches.c
index d31b6c72b476..a042da782fcd 100644
--- a/fs/drop_caches.c
+++ b/fs/drop_caches.c
@@ -61,10 +61,8 @@ int drop_caches_sysctl_handler(struct ctl_table *table, int write,
 			iterate_supers(drop_pagecache_sb, NULL);
 			count_vm_event(DROP_PAGECACHE);
 		}
-		if (sysctl_drop_caches & 2) {
+		if (sysctl_drop_caches & 2)
 			drop_slab();
-			count_vm_event(DROP_SLAB);
-		}
 		if (!stfu) {
 			pr_info("%s (%d): drop_caches: %d\n",
 				current->comm, task_pid_nr(current),
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 5a6445e86328..c3e53502a84a 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -726,6 +726,7 @@ void drop_slab(void)
 
 	for_each_online_node(nid)
 		drop_slab_node(nid);
+	count_vm_event(DROP_SLAB);
 }
 
 static inline int is_page_cache_freeable(struct page *page)
-- 
2.23.0


---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org


WARNING: multiple messages have this Message-ID (diff)
From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, virtio-dev@lists.oasis-open.org,
	virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	Michal Hocko <mhocko@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Michael S . Tsirkin" <mst@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org
Subject: [PATCH RFC v4 11/13] mm/vmscan: Move count_vm_event(DROP_SLAB) into drop_slab()
Date: Thu, 12 Dec 2019 18:11:35 +0100	[thread overview]
Message-ID: <20191212171137.13872-12-david@redhat.com> (raw)
In-Reply-To: <20191212171137.13872-1-david@redhat.com>

Let's count within the function itself, so every invocation (of future
users) will be counted.

Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 fs/drop_caches.c | 4 +---
 mm/vmscan.c      | 1 +
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/drop_caches.c b/fs/drop_caches.c
index d31b6c72b476..a042da782fcd 100644
--- a/fs/drop_caches.c
+++ b/fs/drop_caches.c
@@ -61,10 +61,8 @@ int drop_caches_sysctl_handler(struct ctl_table *table, int write,
 			iterate_supers(drop_pagecache_sb, NULL);
 			count_vm_event(DROP_PAGECACHE);
 		}
-		if (sysctl_drop_caches & 2) {
+		if (sysctl_drop_caches & 2)
 			drop_slab();
-			count_vm_event(DROP_SLAB);
-		}
 		if (!stfu) {
 			pr_info("%s (%d): drop_caches: %d\n",
 				current->comm, task_pid_nr(current),
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 5a6445e86328..c3e53502a84a 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -726,6 +726,7 @@ void drop_slab(void)
 
 	for_each_online_node(nid)
 		drop_slab_node(nid);
+	count_vm_event(DROP_SLAB);
 }
 
 static inline int is_page_cache_freeable(struct page *page)
-- 
2.23.0


  parent reply	other threads:[~2019-12-12 17:13 UTC|newest]

Thread overview: 112+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-12 17:11 [virtio-dev] [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [PATCH RFC v4 01/13] ACPI: NUMA: export pxm_to_node David Hildenbrand
2019-12-12 17:11   ` [virtio-dev] " David Hildenbrand
2019-12-12 21:43   ` Rafael J. Wysocki
2019-12-13  9:41     ` David Hildenbrand
2019-12-13  9:41       ` [virtio-dev] " David Hildenbrand
2019-12-13  9:47       ` Rafael J. Wysocki
2019-12-13  9:47       ` Rafael J. Wysocki
2019-12-13  9:41     ` David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [PATCH RFC v4 02/13] virtio-mem: Paravirtualized memory hotplug David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11   ` [virtio-dev] " David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] [PATCH RFC v4 03/13] virtio-mem: Paravirtualized memory hotunplug part 1 David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] [PATCH RFC v4 04/13] mm: Export alloc_contig_range() / free_contig_range() David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] [PATCH RFC v4 05/13] virtio-mem: Paravirtualized memory hotunplug part 2 David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] [PATCH RFC v4 06/13] mm: Allow to offline unmovable PageOffline() pages via MEM_GOING_OFFLINE David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2020-02-25 18:26   ` [virtio-dev] " Alexander Duyck
2020-02-25 18:26     ` Alexander Duyck
2020-02-25 18:49     ` [virtio-dev] " David Hildenbrand
2020-02-25 18:49       ` David Hildenbrand
2020-02-25 18:49       ` David Hildenbrand
2020-02-25 21:46       ` [virtio-dev] " Alexander Duyck
2020-02-25 21:46         ` Alexander Duyck
2020-02-25 22:19         ` [virtio-dev] " David Hildenbrand
2020-02-25 22:19           ` David Hildenbrand
2020-02-25 22:19           ` David Hildenbrand
2020-02-26 16:27           ` [virtio-dev] " Alexander Duyck
2020-02-26 16:27             ` Alexander Duyck
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [PATCH RFC v4 07/13] virtio-mem: Allow to offline partially unplugged memory blocks David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] " David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] [PATCH RFC v4 08/13] mm/memory_hotplug: Introduce offline_and_remove_memory() David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2020-02-25 14:11   ` Michal Hocko
2020-02-25 14:27     ` [virtio-dev] " David Hildenbrand
2020-02-25 14:27       ` David Hildenbrand
2020-03-02 12:48       ` Michal Hocko
2020-03-02 12:53         ` [virtio-dev] " David Hildenbrand
2020-03-02 12:53           ` David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] [PATCH RFC v4 09/13] virtio-mem: Offline and remove completely unplugged memory blocks David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand
2019-12-12 17:11 ` [PATCH RFC v4 10/13] virtio-mem: Better retry handling David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] " David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2019-12-12 17:11 ` [PATCH RFC v4 11/13] mm/vmscan: Move count_vm_event(DROP_SLAB) into drop_slab() David Hildenbrand
2019-12-12 17:11 ` David Hildenbrand [this message]
2019-12-12 17:11   ` David Hildenbrand
2020-02-25 14:13   ` Michal Hocko
2019-12-12 17:11 ` [PATCH RFC v4 12/13] mm/vmscan: Export drop_slab() and drop_slab_node() David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] " David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2020-02-25 14:58   ` Michal Hocko
2020-02-25 15:09     ` [virtio-dev] " David Hildenbrand
2020-02-25 15:09       ` David Hildenbrand
2020-02-25 17:06       ` Michal Hocko
2020-02-25 17:23         ` [virtio-dev] " David Hildenbrand
2020-02-25 17:23           ` David Hildenbrand
2019-12-12 17:11 ` [PATCH RFC v4 13/13] virtio-mem: Drop slab objects when unplug continues to fail David Hildenbrand
2019-12-12 17:11 ` [virtio-dev] " David Hildenbrand
2019-12-12 17:11   ` David Hildenbrand
2019-12-13 20:15 ` [PATCH RFC v4 00/13] virtio-mem: paravirtualized memory Konrad Rzeszutek Wilk
2019-12-13 20:15   ` Konrad Rzeszutek Wilk
2019-12-16 11:03   ` David Hildenbrand
2019-12-16 11:03   ` [virtio-dev] " David Hildenbrand
2019-12-16 11:03     ` David Hildenbrand
2019-12-24  6:58 ` teawater
2019-12-24  9:28   ` David Hildenbrand
2019-12-24  9:28   ` [virtio-dev] " David Hildenbrand
2019-12-24  9:28     ` David Hildenbrand
2020-01-09 13:48 ` [virtio-dev] " David Hildenbrand
2020-01-09 13:48   ` David Hildenbrand
2020-01-29  9:41   ` [virtio-dev] " David Hildenbrand
2020-01-29  9:41     ` David Hildenbrand
2020-01-29  9:41     ` David Hildenbrand
2020-02-25  9:58     ` [virtio-dev] " David Hildenbrand
2020-02-25  9:58       ` David Hildenbrand
2020-02-25  9:58       ` David Hildenbrand
2020-06-05  8:55   ` Alex Shi
2020-06-05  8:55     ` Alex Shi
2020-06-05  9:08     ` [virtio-dev] " David Hildenbrand
2020-06-05  9:08       ` David Hildenbrand
2020-06-05  9:08       ` David Hildenbrand
2020-06-05  9:36       ` [virtio-dev] " David Hildenbrand
2020-06-05  9:36         ` David Hildenbrand
2020-06-05  9:36         ` David Hildenbrand
2020-06-05 10:05         ` [virtio-dev] " David Hildenbrand
2020-06-05 10:05           ` David Hildenbrand
2020-06-05 10:05           ` David Hildenbrand
2020-06-05 10:46           ` Alex Shi
2020-06-05 10:46             ` Alex Shi
2020-06-05 12:18             ` [virtio-dev] " David Hildenbrand
2020-06-05 12:18               ` David Hildenbrand
2020-06-05 12:18               ` David Hildenbrand
2020-06-09  3:05               ` Alex Shi
2020-06-09  3:05                 ` Alex Shi
2020-06-05 10:08         ` Alex Shi
2020-06-05 10:08           ` Alex Shi
2020-06-05 10:06       ` Alex Shi
2020-06-05 10:06         ` Alex Shi
2020-01-09 13:48 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191212171137.13872-12-david@redhat.com \
    --to=david@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=mst@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.