[PATCH] perf list: remove name from L1D_RO_EXCL_WRITES description

[PATCH] perf list: remove name from L1D_RO_EXCL_WRITES description

[Ed Maste]

From: Ed Maste <emaste@freebsd.org>

In 7fcfa9a2d9 an unintended prefix "Counter:18 Name:" was removed from
the description for L1D_RO_EXCL_WRITES, but the extra name remained in
the description.  Remove it too.

Signed-off-by: Ed Maste <emaste@freebsd.org>
---
 tools/perf/pmu-events/arch/s390/cf_z14/extended.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
index e6478dff0af7..4942b20a1ea1 100644
--- a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
+++ b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
@@ -4,7 +4,7 @@
 		"EventCode": "128",
 		"EventName": "L1D_RO_EXCL_WRITES",
 		"BriefDescription": "L1D Read-only Exclusive Writes",
-		"PublicDescription": "L1D_RO_EXCL_WRITES A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
+		"PublicDescription": "A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
 	},
 	{
 		"Unit": "CPU-M-CF",
-- 
2.24.0

Re: [PATCH] perf list: remove name from L1D_RO_EXCL_WRITES description

[Arnaldo Carvalho de Melo]

Em Thu, Dec 12, 2019 at 02:53:46PM +0000, Ed Maste escreveu:
> From: Ed Maste <emaste@freebsd.org>
> 
> In 7fcfa9a2d9 an unintended prefix "Counter:18 Name:" was removed from
> the description for L1D_RO_EXCL_WRITES, but the extra name remained in
> the description.  Remove it too.

Also trivially correct, applied and added a Fixes tag with that cset
(7fcfa9a2d9).

- Arnaldo
 
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
>  tools/perf/pmu-events/arch/s390/cf_z14/extended.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
> index e6478dff0af7..4942b20a1ea1 100644
> --- a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
> +++ b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
> @@ -4,7 +4,7 @@
>  		"EventCode": "128",
>  		"EventName": "L1D_RO_EXCL_WRITES",
>  		"BriefDescription": "L1D Read-only Exclusive Writes",
> -		"PublicDescription": "L1D_RO_EXCL_WRITES A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
> +		"PublicDescription": "A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
>  	},
>  	{
>  		"Unit": "CPU-M-CF",
> -- 
> 2.24.0

-- 

- Arnaldo

Re: [PATCH] perf list: remove name from L1D_RO_EXCL_WRITES description

[Ed Maste]

On Thu, 12 Dec 2019 at 13:02, Arnaldo Carvalho de Melo
<arnaldo.melo@gmail.com> wrote:
>
> Em Thu, Dec 12, 2019 at 02:53:46PM +0000, Ed Maste escreveu:
> > From: Ed Maste <emaste@freebsd.org>
> >
> > In 7fcfa9a2d9 an unintended prefix "Counter:18 Name:" was removed from
> > the description for L1D_RO_EXCL_WRITES, but the extra name remained in
> > the description.  Remove it too.
>
> Also trivially correct, applied and added a Fixes tag with that cset
> (7fcfa9a2d9).
>
> - Arnaldo

Thank you, and sorry that these came not as a set. Each time I thought
I had only one change to submit and then found another nit shortly
after I sent the previous.

There is one more related change that hasn't been picked up yet (and
that I seem to have missed adding you on CC), with subject
[PATCH] perf vendor events s390: Fix commas so PMU event files are valid JSON

[tip: perf/urgent] perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description

[tip-bot2 for Ed Maste]

The following commit has been merged into the perf/urgent branch of tip:

Commit-ID:     58b3bafff8257c6946df5d6aeb215b8ac839ed2a
Gitweb:        https://git.kernel.org/tip/58b3bafff8257c6946df5d6aeb215b8ac839ed2a
Author:        Ed Maste <emaste@freebsd.org>
AuthorDate:    Thu, 12 Dec 2019 14:53:46 
Committer:     Arnaldo Carvalho de Melo <acme@redhat.com>
CommitterDate: Mon, 16 Dec 2019 13:40:26 -03:00

perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description

In 7fcfa9a2d9 an unintended prefix "Counter:18 Name:" was removed from
the description for L1D_RO_EXCL_WRITES, but the extra name remained in
the description.  Remove it too.

Fixes: 7fcfa9a2d9a7 ("perf list: Fix s390 counter long description for L1D_RO_EXCL_WRITES")
Signed-off-by: Ed Maste <emaste@freebsd.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Greentime Hu <green.hu@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Nick Hu <nickhu@andestech.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Richter <tmricht@linux.ibm.com>
Cc: Vincent Chen <deanbo422@gmail.com>
Link: http://lore.kernel.org/lkml/20191212145346.5026-1-emaste@freefall.freebsd.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/pmu-events/arch/s390/cf_z14/extended.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
index 6861815..89e0707 100644
--- a/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
+++ b/tools/perf/pmu-events/arch/s390/cf_z14/extended.json
@@ -4,7 +4,7 @@
 		"EventCode": "128",
 		"EventName": "L1D_RO_EXCL_WRITES",
 		"BriefDescription": "L1D Read-only Exclusive Writes",
-		"PublicDescription": "L1D_RO_EXCL_WRITES A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
+		"PublicDescription": "A directory write to the Level-1 Data cache where the line was originally in a Read-Only state in the cache but has been updated to be in the Exclusive state that allows stores to the cache line"
 	},
 	{
 		"Unit": "CPU-M-CF",