From: Andrew Lunn <andrew@lunn.ch>
To: biao huang <biao.huang@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Jose Abreu <joabreu@synopsys.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] net-next: stmmac: mediatek: add more suuport for RMII
Date: Fri, 13 Dec 2019 14:47:08 +0100 [thread overview]
Message-ID: <20191213134708.GA4286@lunn.ch> (raw)
In-Reply-To: <1576200981.29387.13.camel@mhfsdcap03>
> The clock labeled as "rmii_internal" is needed only in RMII(when MAC provides
> reference clock), and useless for RGMII/MII/RMII(when phy provides reference
> clock).
>
> So, add a boolean flag to indicate where the RMII reference clock is from, MAC
> or PHY, if MAC, enable the "rmii_internal", or disable it.
> and this clock already documented in dt-binding in PATCH 2/2.
>
> For power saving, it should not be enabled in default, so can't add it to the
> existing list of clocks directly.
>
> Any advice for this special case?
O.K. Add the boolean, but also add the clock to the list of clocks in
DT. Don't hard code the clock name in the driver.
Andrew
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: biao huang <biao.huang@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Jose Abreu <joabreu@synopsys.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com, yt.shen@mediatek.com,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] net-next: stmmac: mediatek: add more suuport for RMII
Date: Fri, 13 Dec 2019 14:47:08 +0100 [thread overview]
Message-ID: <20191213134708.GA4286@lunn.ch> (raw)
In-Reply-To: <1576200981.29387.13.camel@mhfsdcap03>
> The clock labeled as "rmii_internal" is needed only in RMII(when MAC provides
> reference clock), and useless for RGMII/MII/RMII(when phy provides reference
> clock).
>
> So, add a boolean flag to indicate where the RMII reference clock is from, MAC
> or PHY, if MAC, enable the "rmii_internal", or disable it.
> and this clock already documented in dt-binding in PATCH 2/2.
>
> For power saving, it should not be enabled in default, so can't add it to the
> existing list of clocks directly.
>
> Any advice for this special case?
O.K. Add the boolean, but also add the clock to the list of clocks in
DT. Don't hard code the clock name in the driver.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: biao huang <biao.huang@mediatek.com>
Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, yt.shen@mediatek.com
Subject: Re: [PATCH 1/2] net-next: stmmac: mediatek: add more suuport for RMII
Date: Fri, 13 Dec 2019 14:47:08 +0100 [thread overview]
Message-ID: <20191213134708.GA4286@lunn.ch> (raw)
In-Reply-To: <1576200981.29387.13.camel@mhfsdcap03>
> The clock labeled as "rmii_internal" is needed only in RMII(when MAC provides
> reference clock), and useless for RGMII/MII/RMII(when phy provides reference
> clock).
>
> So, add a boolean flag to indicate where the RMII reference clock is from, MAC
> or PHY, if MAC, enable the "rmii_internal", or disable it.
> and this clock already documented in dt-binding in PATCH 2/2.
>
> For power saving, it should not be enabled in default, so can't add it to the
> existing list of clocks directly.
>
> Any advice for this special case?
O.K. Add the boolean, but also add the clock to the list of clocks in
DT. Don't hard code the clock name in the driver.
Andrew
next prev parent reply other threads:[~2019-12-13 22:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 2:41 [PATCH 0/2] net-next: stmmac: dwmac-mediatek: add more support for RMII Biao Huang
2019-12-12 2:41 ` Biao Huang
2019-12-12 2:41 ` Biao Huang
2019-12-12 2:41 ` [PATCH 1/2] net-next: stmmac: mediatek: add more suuport " Biao Huang
2019-12-12 2:41 ` Biao Huang
2019-12-12 2:41 ` Biao Huang
2019-12-12 13:25 ` Andrew Lunn
2019-12-12 13:25 ` Andrew Lunn
2019-12-12 13:25 ` Andrew Lunn
[not found] ` <1576200981.29387.13.camel@mhfsdcap03>
2019-12-13 13:47 ` Andrew Lunn [this message]
2019-12-13 13:47 ` Andrew Lunn
2019-12-13 13:47 ` Andrew Lunn
2019-12-12 2:41 ` [PATCH 2/2] net-next: dt-binding: dwmac-mediatek: add more description " Biao Huang
2019-12-12 2:41 ` Biao Huang
2019-12-12 2:41 ` Biao Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213134708.GA4286@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@st.com \
--cc=biao.huang@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=joabreu@synopsys.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.