From: Rob Herring <robh@kernel.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Mark Rutland <mark.rutland@arm.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes
Date: Fri, 13 Dec 2019 15:34:18 -0600 [thread overview]
Message-ID: <20191213213418.GA17361@bogus> (raw)
In-Reply-To: <7556683b57d8ce100855857f03d1cd3d2903d045.1574943062.git.christophe.leroy@c-s.fr>
On Thu, Nov 28, 2019 at 12:16:35PM +0000, Christophe Leroy wrote:
> Since commit 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO
> descriptors"), the prefered way to define chipselect GPIOs is using
> 'cs-gpios' property instead of the legacy 'gpios' property.
This will break using a new dtb on a kernel without the above commit. Or
with any OS that never made the change.
I'm fine with the doc change, but you should keep 'gpios' as deprecated.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> Documentation/devicetree/bindings/spi/fsl-spi.txt | 8 ++++----
> arch/powerpc/boot/dts/mgcoge.dts | 2 +-
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 +-
> arch/powerpc/boot/dts/mpc8610_hpcd.dts | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Mark Brown <broonie@kernel.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes
Date: Fri, 13 Dec 2019 15:34:18 -0600 [thread overview]
Message-ID: <20191213213418.GA17361@bogus> (raw)
In-Reply-To: <7556683b57d8ce100855857f03d1cd3d2903d045.1574943062.git.christophe.leroy@c-s.fr>
On Thu, Nov 28, 2019 at 12:16:35PM +0000, Christophe Leroy wrote:
> Since commit 0f0581b24bd0 ("spi: fsl: Convert to use CS GPIO
> descriptors"), the prefered way to define chipselect GPIOs is using
> 'cs-gpios' property instead of the legacy 'gpios' property.
This will break using a new dtb on a kernel without the above commit. Or
with any OS that never made the change.
I'm fine with the doc change, but you should keep 'gpios' as deprecated.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
> ---
> Documentation/devicetree/bindings/spi/fsl-spi.txt | 8 ++++----
> arch/powerpc/boot/dts/mgcoge.dts | 2 +-
> arch/powerpc/boot/dts/mpc832x_rdb.dts | 2 +-
> arch/powerpc/boot/dts/mpc8610_hpcd.dts | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)
next prev parent reply other threads:[~2019-12-13 21:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 11:58 [PATCH v5 0/2] add device tree for SAM9X60 SoC and SAM9X60-EK board Claudiu Beznea
2019-11-28 12:16 ` [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes Christophe Leroy
2019-11-28 12:16 ` [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl, spi nodes Christophe Leroy
2019-11-28 12:21 ` [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl,spi nodes Linus Walleij
2019-11-28 12:21 ` Linus Walleij
2019-12-13 21:34 ` Rob Herring [this message]
2019-12-13 21:34 ` Rob Herring
2019-12-14 7:30 ` Christophe Leroy
2019-12-14 7:30 ` Christophe Leroy
2020-01-29 5:17 ` [PATCH] powerpc/devicetrees: Change 'gpios' to 'cs-gpios' on fsl, spi nodes Michael Ellerman
2020-02-10 14:25 ` Patchwork summary for: spi-devel-general patchwork-bot+linux-spi-DgEjT+Ai2ygdnm+yROfE0A
[not found] ` <1579262309-6542-1-git-send-email-claudiu.beznea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2020-01-17 11:58 ` [PATCH v5 1/2] dt-bindings: atmel-usart: remove wildcard Claudiu Beznea
[not found] ` <1579262309-6542-2-git-send-email-claudiu.beznea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2020-01-20 8:39 ` Lee Jones
2020-01-17 11:58 ` [PATCH v5 2/2] dt-bindings: atmel-usart: add microchip,sam9x60-{usart, dbgu} Claudiu Beznea
[not found] ` <1579262309-6542-3-git-send-email-claudiu.beznea-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2020-01-20 8:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213213418.GA17361@bogus \
--to=robh@kernel.org \
--cc=benh@kernel.crashing.org \
--cc=broonie@kernel.org \
--cc=christophe.leroy@c-s.fr \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.