From: Rob Herring <robh@kernel.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC
Date: Fri, 13 Dec 2019 15:42:58 -0600 [thread overview]
Message-ID: <20191213214258.GA7625@bogus> (raw)
In-Reply-To: <20191129000827.650566-2-joel@jms.id.au>
On Fri, Nov 29, 2019 at 10:38:26AM +1030, Joel Stanley wrote:
> The AST2600 has the same LPC layout as previous generation SoCs.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: Fix cut and paste error in reset bindings
> ---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> index 86446074e206..a5d89aa9a3c1 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> @@ -46,6 +46,7 @@ Required properties
> - compatible: One of:
> "aspeed,ast2400-lpc", "simple-mfd"
> "aspeed,ast2500-lpc", "simple-mfd"
> + "aspeed,ast2600-lpc", "simple-mfd"
>
> - reg: contains the physical address and length values of the Aspeed
> LPC memory region.
> @@ -64,6 +65,7 @@ BMC Node
> - compatible: One of:
> "aspeed,ast2400-lpc-bmc"
> "aspeed,ast2500-lpc-bmc"
> + "aspeed,ast2600-lpc-bmc"
>
> - reg: contains the physical address and length values of the
> H8S/2168-compatible LPC controller memory region
> @@ -128,6 +130,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lpc-ctrl";
> "aspeed,ast2500-lpc-ctrl";
> + "aspeed,ast2600-lpc-ctrl";
>
> - reg: contains offset/length values of the host interface controller
> memory regions
> @@ -168,6 +171,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lhc";
> "aspeed,ast2500-lhc";
> + "aspeed,ast2600-lhc";
>
> - reg: contains offset/length values of the LHC memory regions. In the
> AST2400 and AST2500 there are two regions.
> @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration.
>
> Required properties:
>
> - - compatible: "aspeed,ast2500-lpc-reset" or
> - "aspeed,ast2400-lpc-reset"
> + - compatible: One of:
> + "aspeed,ast2400-reset";
> + "aspeed,ast2500-reset";
> + "aspeed,ast2600-reset";
Doesn't match what's in the driver.
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC
Date: Fri, 13 Dec 2019 15:42:58 -0600 [thread overview]
Message-ID: <20191213214258.GA7625@bogus> (raw)
In-Reply-To: <20191129000827.650566-2-joel@jms.id.au>
On Fri, Nov 29, 2019 at 10:38:26AM +1030, Joel Stanley wrote:
> The AST2600 has the same LPC layout as previous generation SoCs.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: Fix cut and paste error in reset bindings
> ---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> index 86446074e206..a5d89aa9a3c1 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> @@ -46,6 +46,7 @@ Required properties
> - compatible: One of:
> "aspeed,ast2400-lpc", "simple-mfd"
> "aspeed,ast2500-lpc", "simple-mfd"
> + "aspeed,ast2600-lpc", "simple-mfd"
>
> - reg: contains the physical address and length values of the Aspeed
> LPC memory region.
> @@ -64,6 +65,7 @@ BMC Node
> - compatible: One of:
> "aspeed,ast2400-lpc-bmc"
> "aspeed,ast2500-lpc-bmc"
> + "aspeed,ast2600-lpc-bmc"
>
> - reg: contains the physical address and length values of the
> H8S/2168-compatible LPC controller memory region
> @@ -128,6 +130,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lpc-ctrl";
> "aspeed,ast2500-lpc-ctrl";
> + "aspeed,ast2600-lpc-ctrl";
>
> - reg: contains offset/length values of the host interface controller
> memory regions
> @@ -168,6 +171,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lhc";
> "aspeed,ast2500-lhc";
> + "aspeed,ast2600-lhc";
>
> - reg: contains offset/length values of the LHC memory regions. In the
> AST2400 and AST2500 there are two regions.
> @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration.
>
> Required properties:
>
> - - compatible: "aspeed,ast2500-lpc-reset" or
> - "aspeed,ast2400-lpc-reset"
> + - compatible: One of:
> + "aspeed,ast2400-reset";
> + "aspeed,ast2500-reset";
> + "aspeed,ast2600-reset";
Doesn't match what's in the driver.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Lee Jones <lee.jones@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC
Date: Fri, 13 Dec 2019 15:42:58 -0600 [thread overview]
Message-ID: <20191213214258.GA7625@bogus> (raw)
In-Reply-To: <20191129000827.650566-2-joel@jms.id.au>
On Fri, Nov 29, 2019 at 10:38:26AM +1030, Joel Stanley wrote:
> The AST2600 has the same LPC layout as previous generation SoCs.
>
> Signed-off-by: Joel Stanley <joel@jms.id.au>
> ---
> v2: Fix cut and paste error in reset bindings
> ---
> Documentation/devicetree/bindings/mfd/aspeed-lpc.txt | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> index 86446074e206..a5d89aa9a3c1 100644
> --- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
> @@ -46,6 +46,7 @@ Required properties
> - compatible: One of:
> "aspeed,ast2400-lpc", "simple-mfd"
> "aspeed,ast2500-lpc", "simple-mfd"
> + "aspeed,ast2600-lpc", "simple-mfd"
>
> - reg: contains the physical address and length values of the Aspeed
> LPC memory region.
> @@ -64,6 +65,7 @@ BMC Node
> - compatible: One of:
> "aspeed,ast2400-lpc-bmc"
> "aspeed,ast2500-lpc-bmc"
> + "aspeed,ast2600-lpc-bmc"
>
> - reg: contains the physical address and length values of the
> H8S/2168-compatible LPC controller memory region
> @@ -128,6 +130,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lpc-ctrl";
> "aspeed,ast2500-lpc-ctrl";
> + "aspeed,ast2600-lpc-ctrl";
>
> - reg: contains offset/length values of the host interface controller
> memory regions
> @@ -168,6 +171,7 @@ Required properties:
> - compatible: One of:
> "aspeed,ast2400-lhc";
> "aspeed,ast2500-lhc";
> + "aspeed,ast2600-lhc";
>
> - reg: contains offset/length values of the LHC memory regions. In the
> AST2400 and AST2500 there are two regions.
> @@ -187,8 +191,11 @@ state of the LPC bus. Some systems may chose to modify this configuration.
>
> Required properties:
>
> - - compatible: "aspeed,ast2500-lpc-reset" or
> - "aspeed,ast2400-lpc-reset"
> + - compatible: One of:
> + "aspeed,ast2400-reset";
> + "aspeed,ast2500-reset";
> + "aspeed,ast2600-reset";
Doesn't match what's in the driver.
Rob
next prev parent reply other threads:[~2019-12-13 21:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 0:08 [PATCH v2 0/2] reset: Add ast2600 support Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-11-29 0:08 ` [PATCH v2 1/2] dt-bindings: mfd: Add ast2600 to ASPEED LPC Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-12-01 23:29 ` Andrew Jeffery
2019-12-01 23:29 ` Andrew Jeffery
2019-12-01 23:29 ` Andrew Jeffery
2019-12-13 21:42 ` Rob Herring [this message]
2019-12-13 21:42 ` Rob Herring
2019-12-13 21:42 ` Rob Herring
2019-11-29 0:08 ` [PATCH v2 2/2] reset: simple: Add AST2600 compatibility string Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-11-29 0:08 ` Joel Stanley
2019-12-02 12:53 ` Philipp Zabel
2019-12-02 12:53 ` Philipp Zabel
2019-12-02 12:53 ` Philipp Zabel
2019-12-12 14:51 ` Brad Bishop
2019-12-12 14:51 ` Brad Bishop
2019-12-12 14:51 ` Brad Bishop
2019-12-12 15:17 ` Philipp Zabel
2019-12-12 15:17 ` Philipp Zabel
2019-12-12 15:17 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213214258.GA7625@bogus \
--to=robh@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.