All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support
Date: Mon, 16 Dec 2019 11:47:09 +0100	[thread overview]
Message-ID: <20191216114709.0fca7240@xps13> (raw)
In-Reply-To: <20191214100911.GA2967@ravnborg.org>

Hi Sam,

Sam Ravnborg <sam@ravnborg.org> wrote on Sat, 14 Dec 2019 11:09:11
+0100:

> Hi Miquel.
> 
> On Fri, Dec 13, 2019 at 07:23:25PM +0100, Miquel Raynal wrote:
> > Add support for the Satoz SAT050AT40H12R2 RGB panel.  
> 
> Google failed to find this display - do you have any pointers to
> datasheet?
> 
> This turned up: SAT050AT40H12B2
> But I failed to find any data sheet.

I could not find the datasheet myself on the Internet, I found other
datasheets of other panels from the same vendor though.

I confirm I am talking about the R2 package (not B2 your find).

> 
> I wonder if there is any typical, min, max timings - so we could use
> display_timing rather than display_mode.

Yes there are min/typ/max timings in the datasheet, I didn't know about
display_mode (copied/pasted another random timing structure and adapted
it). I will try to adapt.

> 
> Before the compatible is documented the patch will not be applied.
> So you need to submit a binding document too,
> which must be in meta-schema syntax (.yaml).

Any reason to create one (almost empty) file by compatible? As
comparison, simple I2C/SPI devices with no singularities are
listed there:
Documentation/devicetree/bindings/trivial-devices.yaml

I'll create a bindings file for this panel though.

Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	David Airlie <airlied@linux.ie>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
	Rob Herring <robh+dt@kernel.org>,
	Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support
Date: Mon, 16 Dec 2019 11:47:09 +0100	[thread overview]
Message-ID: <20191216114709.0fca7240@xps13> (raw)
In-Reply-To: <20191214100911.GA2967@ravnborg.org>

Hi Sam,

Sam Ravnborg <sam@ravnborg.org> wrote on Sat, 14 Dec 2019 11:09:11
+0100:

> Hi Miquel.
> 
> On Fri, Dec 13, 2019 at 07:23:25PM +0100, Miquel Raynal wrote:
> > Add support for the Satoz SAT050AT40H12R2 RGB panel.  
> 
> Google failed to find this display - do you have any pointers to
> datasheet?
> 
> This turned up: SAT050AT40H12B2
> But I failed to find any data sheet.

I could not find the datasheet myself on the Internet, I found other
datasheets of other panels from the same vendor though.

I confirm I am talking about the R2 package (not B2 your find).

> 
> I wonder if there is any typical, min, max timings - so we could use
> display_timing rather than display_mode.

Yes there are min/typ/max timings in the datasheet, I didn't know about
display_mode (copied/pasted another random timing structure and adapted
it). I will try to adapt.

> 
> Before the compatible is documented the patch will not be applied.
> So you need to submit a binding document too,
> which must be in meta-schema syntax (.yaml).

Any reason to create one (almost empty) file by compatible? As
comparison, simple I2C/SPI devices with no singularities are
listed there:
Documentation/devicetree/bindings/trivial-devices.yaml

I'll create a bindings file for this panel though.

Thanks,
Miquèl
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2019-12-16 10:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 18:23 [PATCH 1/2] dt-bindings: Add vendor prefix for Satoz Miquel Raynal
2019-12-13 18:23 ` Miquel Raynal
2019-12-13 18:23 ` [PATCH 2/2] drm/panel: simple: Add Satoz SAT050AT40H12R2 panel support Miquel Raynal
2019-12-13 18:23   ` Miquel Raynal
2019-12-14 10:09   ` Sam Ravnborg
2019-12-14 10:09     ` Sam Ravnborg
2019-12-16 10:47     ` Miquel Raynal [this message]
2019-12-16 10:47       ` Miquel Raynal
2019-12-19 23:51 ` [PATCH 1/2] dt-bindings: Add vendor prefix for Satoz Rob Herring
2019-12-19 23:51   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216114709.0fca7240@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.