All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: David Airlie <airlied@linux.ie>, Sam Ravnborg <sam@ravnborg.org>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/6] dt-bindings: display/ingenic: Add compatible string for JZ4770
Date: Mon, 16 Dec 2019 16:43:24 +0200	[thread overview]
Message-ID: <20191216144324.GW1208@intel.com> (raw)
In-Reply-To: <1576503593.3.2@crapouillou.net>

On Mon, Dec 16, 2019 at 02:39:53PM +0100, Paul Cercueil wrote:
> Hi Ville,
> 
> 
> Le lun., déc. 16, 2019 at 15:15, Ville Syrjälä 
> <ville.syrjala@linux.intel.com> a écrit :
> > On Sat, Dec 14, 2019 at 11:54:18AM +0100, Sam Ravnborg wrote:
> >>  Hi Paul.
> >> 
> >>  On Tue, Dec 10, 2019 at 03:41:37PM +0100, Paul Cercueil wrote:
> >>  > Add a compatible string for the LCD controller found in the 
> >> JZ4770 SoC.
> >>  >
> >>  > v2: No change
> >>  >
> >>  > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> >>  > Acked-by: Rob Herring <robh@kernel.org>
> >> 
> >>  Whole series looks good.
> >>  Acked-by: Sam Ravnborg <sam@ravnborg.org>
> > 
> > Paul, looks like you forgot to git commit --amend after adding the 
> > tags.
> > Now the commit messages have and extra "# *** extracted tags ***" in 
> > them.
> 
> Sorry, I'm still relatively new to this :(
> 
> I thought they were going to be automatically removed since they are 
> comments.

They will be of you commit --amend. But not without that.

People tend to typo these things quite often so I made dim extract-tags
rather liberal in what it accepts. And sometimes that means it'll pull
in all kinds of crap when people put a ':' in the wrong place. And
that's the reason I added the extra marker so it's trivial to see what
got pulled in by dim and what was there already. But it does mean you
always have to do the --amend to get rid of the markers.

I guess there are at least two options to improve the situation:
a) make dim extract-tags more strict and risk missing typoed tags
b) make dim push check that there marker has been removed from the
   commit msg

-- 
Ville Syrjälä
Intel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: display/ingenic: Add compatible string for JZ4770
Date: Mon, 16 Dec 2019 16:43:24 +0200	[thread overview]
Message-ID: <20191216144324.GW1208@intel.com> (raw)
In-Reply-To: <1576503593.3.2@crapouillou.net>

On Mon, Dec 16, 2019 at 02:39:53PM +0100, Paul Cercueil wrote:
> Hi Ville,
> 
> 
> Le lun., déc. 16, 2019 at 15:15, Ville Syrjälä 
> <ville.syrjala@linux.intel.com> a écrit :
> > On Sat, Dec 14, 2019 at 11:54:18AM +0100, Sam Ravnborg wrote:
> >>  Hi Paul.
> >> 
> >>  On Tue, Dec 10, 2019 at 03:41:37PM +0100, Paul Cercueil wrote:
> >>  > Add a compatible string for the LCD controller found in the 
> >> JZ4770 SoC.
> >>  >
> >>  > v2: No change
> >>  >
> >>  > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> >>  > Acked-by: Rob Herring <robh@kernel.org>
> >> 
> >>  Whole series looks good.
> >>  Acked-by: Sam Ravnborg <sam@ravnborg.org>
> > 
> > Paul, looks like you forgot to git commit --amend after adding the 
> > tags.
> > Now the commit messages have and extra "# *** extracted tags ***" in 
> > them.
> 
> Sorry, I'm still relatively new to this :(
> 
> I thought they were going to be automatically removed since they are 
> comments.

They will be of you commit --amend. But not without that.

People tend to typo these things quite often so I made dim extract-tags
rather liberal in what it accepts. And sometimes that means it'll pull
in all kinds of crap when people put a ':' in the wrong place. And
that's the reason I added the extra marker so it's trivial to see what
got pulled in by dim and what was there already. But it does mean you
always have to do the --amend to get rid of the markers.

I guess there are at least two options to improve the situation:
a) make dim extract-tags more strict and risk missing typoed tags
b) make dim push check that there marker has been removed from the
   commit msg

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2019-12-16 14:43 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 14:41 [PATCH v2 1/6] dt-bindings: display/ingenic: Add compatible string for JZ4770 Paul Cercueil
2019-12-10 14:41 ` Paul Cercueil
2019-12-10 14:41 ` [PATCH v2 2/6] gpu/drm: ingenic: Avoid null pointer deference in plane atomic update Paul Cercueil
2019-12-10 14:41   ` Paul Cercueil
2019-12-10 14:41 ` [PATCH v2 3/6] gpu/drm: ingenic: Use the plane's src_[x, y] to configure DMA length Paul Cercueil
2019-12-10 14:41   ` [PATCH v2 3/6] gpu/drm: ingenic: Use the plane's src_[x,y] " Paul Cercueil
2019-12-10 14:41 ` [PATCH v2 4/6] gpu/drm: ingenic: Set max FB height to 4095 Paul Cercueil
2019-12-10 14:41   ` Paul Cercueil
2019-12-10 14:41 ` [PATCH v2 5/6] gpu/drm: ingenic: Check for display size in CRTC atomic check Paul Cercueil
2019-12-10 14:41   ` Paul Cercueil
2019-12-10 14:41 ` [PATCH v2 6/6] gpu/drm: ingenic: Add support for the JZ4770 Paul Cercueil
2019-12-10 14:41   ` Paul Cercueil
2019-12-14 10:54 ` [PATCH v2 1/6] dt-bindings: display/ingenic: Add compatible string for JZ4770 Sam Ravnborg
2019-12-14 10:54   ` Sam Ravnborg
2019-12-16 13:15   ` Ville Syrjälä
2019-12-16 13:15     ` Ville Syrjälä
2019-12-16 13:39     ` Paul Cercueil
2019-12-16 13:39       ` Paul Cercueil
2019-12-16 14:43       ` Ville Syrjälä [this message]
2019-12-16 14:43         ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216144324.GW1208@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.