All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joerg Roedel <joro@8bytes.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] iommu: Implement iommu_put_resv_regions_simple()
Date: Tue, 17 Dec 2019 11:08:50 +0100	[thread overview]
Message-ID: <20191217100850.GI8689@8bytes.org> (raw)
In-Reply-To: <20191209145007.2433144-1-thierry.reding@gmail.com>

Hi Thierry

On Mon, Dec 09, 2019 at 03:50:02PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Most IOMMU drivers only need to free the memory allocated for each
> reserved region. Instead of open-coding the loop to do this in each
> driver, extract the code into a common function that can be used by
> all these drivers.
> 
> Changes in v2:
> - change subject prefix to "iommu: virtio: " for virtio-iommu.c driver
> 
> Thierry
> 
> Thierry Reding (5):
>   iommu: Implement iommu_put_resv_regions_simple()
>   iommu: arm: Use iommu_put_resv_regions_simple()
>   iommu: amd: Use iommu_put_resv_regions_simple()
>   iommu: intel: Use iommu_put_resv_regions_simple()
>   iommu: virtio: Use iommu_put_resv_regions_simple()

Thanks, that is a nice consolidation. Just a minor nit, can you please
rename iommu_put_resv_regions_simple to
generic_iommu_put_resv_regsions(). That matches the naming in other
places where we have done similar things.

Thanks,

	Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Will Deacon <will@kernel.org>,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Christoph Hellwig <hch@infradead.org>,
	iommu@lists.linux-foundation.org,
	Robin Murphy <robin.murphy@arm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/5] iommu: Implement iommu_put_resv_regions_simple()
Date: Tue, 17 Dec 2019 11:08:50 +0100	[thread overview]
Message-ID: <20191217100850.GI8689@8bytes.org> (raw)
In-Reply-To: <20191209145007.2433144-1-thierry.reding@gmail.com>

Hi Thierry

On Mon, Dec 09, 2019 at 03:50:02PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Most IOMMU drivers only need to free the memory allocated for each
> reserved region. Instead of open-coding the loop to do this in each
> driver, extract the code into a common function that can be used by
> all these drivers.
> 
> Changes in v2:
> - change subject prefix to "iommu: virtio: " for virtio-iommu.c driver
> 
> Thierry
> 
> Thierry Reding (5):
>   iommu: Implement iommu_put_resv_regions_simple()
>   iommu: arm: Use iommu_put_resv_regions_simple()
>   iommu: amd: Use iommu_put_resv_regions_simple()
>   iommu: intel: Use iommu_put_resv_regions_simple()
>   iommu: virtio: Use iommu_put_resv_regions_simple()

Thanks, that is a nice consolidation. Just a minor nit, can you please
rename iommu_put_resv_regions_simple to
generic_iommu_put_resv_regsions(). That matches the naming in other
places where we have done similar things.

Thanks,

	Joerg

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	Christoph Hellwig <hch@infradead.org>,
	iommu@lists.linux-foundation.org,
	linux-arm-kernel@lists.infradead.org,
	virtualization@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/5] iommu: Implement iommu_put_resv_regions_simple()
Date: Tue, 17 Dec 2019 11:08:50 +0100	[thread overview]
Message-ID: <20191217100850.GI8689@8bytes.org> (raw)
In-Reply-To: <20191209145007.2433144-1-thierry.reding@gmail.com>

Hi Thierry

On Mon, Dec 09, 2019 at 03:50:02PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Most IOMMU drivers only need to free the memory allocated for each
> reserved region. Instead of open-coding the loop to do this in each
> driver, extract the code into a common function that can be used by
> all these drivers.
> 
> Changes in v2:
> - change subject prefix to "iommu: virtio: " for virtio-iommu.c driver
> 
> Thierry
> 
> Thierry Reding (5):
>   iommu: Implement iommu_put_resv_regions_simple()
>   iommu: arm: Use iommu_put_resv_regions_simple()
>   iommu: amd: Use iommu_put_resv_regions_simple()
>   iommu: intel: Use iommu_put_resv_regions_simple()
>   iommu: virtio: Use iommu_put_resv_regions_simple()

Thanks, that is a nice consolidation. Just a minor nit, can you please
rename iommu_put_resv_regions_simple to
generic_iommu_put_resv_regsions(). That matches the naming in other
places where we have done similar things.

Thanks,

	Joerg

  parent reply	other threads:[~2019-12-17 10:08 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 14:50 [PATCH v2 0/5] iommu: Implement iommu_put_resv_regions_simple() Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50 ` [PATCH v2 1/5] " Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50 ` [PATCH v2 2/5] iommu: arm: Use iommu_put_resv_regions_simple() Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-17 10:59   ` Will Deacon
2019-12-17 10:59   ` Will Deacon
2019-12-17 10:59     ` Will Deacon
2019-12-17 10:59     ` Will Deacon
2019-12-09 14:50 ` [PATCH v2 3/5] iommu: amd: " Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50 ` [PATCH v2 4/5] iommu: intel: " Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50 ` [PATCH v2 5/5] iommu: virtio: " Thierry Reding
2019-12-09 14:50 ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-09 14:50   ` Thierry Reding
2019-12-11 15:44   ` Jean-Philippe Brucker
2019-12-11 15:44     ` Jean-Philippe Brucker
2019-12-11 15:44     ` Jean-Philippe Brucker
2019-12-11 15:44     ` Jean-Philippe Brucker
2019-12-17 10:08 ` [PATCH v2 0/5] iommu: Implement iommu_put_resv_regions_simple() Joerg Roedel
2019-12-17 10:08 ` Joerg Roedel [this message]
2019-12-17 10:08   ` Joerg Roedel
2019-12-17 10:08   ` Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217100850.GI8689@8bytes.org \
    --to=joro@8bytes.org \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jean-philippe@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=thierry.reding@gmail.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.