From: SeongJae Park <sjpark@amazon.com>
To: <jgross@suse.com>, <axboe@kernel.dk>, <konrad.wilk@oracle.com>,
<roger.pau@citrix.com>
Cc: SeongJae Park <sjpark@amazon.de>, <pdurrant@amazon.com>,
<sjpark@amazon.com>, <sj38.park@gmail.com>,
<xen-devel@lists.xenproject.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v11 6/6] xen/blkback: Consistently insert one empty line between functions
Date: Tue, 17 Dec 2019 17:10:41 +0100 [thread overview]
Message-ID: <20191217161041.1433-1-sjpark@amazon.com> (raw)
In-Reply-To: <20191217160748.693-1-sjpark@amazon.com>
From: SeongJae Park <sjpark@amazon.de>
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
drivers/block/xen-blkback/xenbus.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 20045827a391..453f97dd533d 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -432,7 +432,6 @@ static void xenvbd_sysfs_delif(struct xenbus_device *dev)
device_remove_file(&dev->dev, &dev_attr_physical_device);
}
-
static void xen_vbd_free(struct xen_vbd *vbd)
{
if (vbd->bdev)
@@ -489,6 +488,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
handle, blkif->domid);
return 0;
}
+
static int xen_blkbk_remove(struct xenbus_device *dev)
{
struct backend_info *be = dev_get_drvdata(&dev->dev);
@@ -575,6 +575,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
if (err)
dev_warn(&dev->dev, "writing feature-discard (%d)", err);
}
+
int xen_blkbk_barrier(struct xenbus_transaction xbt,
struct backend_info *be, int state)
{
@@ -663,7 +664,6 @@ static int xen_blkbk_probe(struct xenbus_device *dev,
return err;
}
-
/*
* Callback received when the hotplug scripts have placed the physical-device
* node. Read it and the mode node, and create a vbd. If the frontend is
@@ -755,7 +755,6 @@ static void backend_changed(struct xenbus_watch *watch,
}
}
-
/*
* Callback received when the frontend's state changes.
*/
@@ -830,7 +829,6 @@ static void frontend_changed(struct xenbus_device *dev,
}
}
-
/* Once a memory pressure is detected, squeeze free page pools for a while. */
static unsigned int buffer_squeeze_duration_ms = 10;
module_param_named(buffer_squeeze_duration_ms,
@@ -855,7 +853,6 @@ static void reclaim_memory(struct xenbus_device *dev)
/* ** Connection ** */
-
/*
* Write the physical details regarding the block device to the store, and
* switch to Connected state.
--
2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: SeongJae Park <sjpark@amazon.com>
To: <jgross@suse.com>, <axboe@kernel.dk>, <konrad.wilk@oracle.com>,
<roger.pau@citrix.com>
Cc: linux-block@vger.kernel.org, sjpark@amazon.com,
pdurrant@amazon.com, SeongJae Park <sjpark@amazon.de>,
linux-kernel@vger.kernel.org, sj38.park@gmail.com,
xen-devel@lists.xenproject.org
Subject: [Xen-devel] [PATCH v11 6/6] xen/blkback: Consistently insert one empty line between functions
Date: Tue, 17 Dec 2019 17:10:41 +0100 [thread overview]
Message-ID: <20191217161041.1433-1-sjpark@amazon.com> (raw)
In-Reply-To: <20191217160748.693-1-sjpark@amazon.com>
From: SeongJae Park <sjpark@amazon.de>
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
drivers/block/xen-blkback/xenbus.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 20045827a391..453f97dd533d 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -432,7 +432,6 @@ static void xenvbd_sysfs_delif(struct xenbus_device *dev)
device_remove_file(&dev->dev, &dev_attr_physical_device);
}
-
static void xen_vbd_free(struct xen_vbd *vbd)
{
if (vbd->bdev)
@@ -489,6 +488,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
handle, blkif->domid);
return 0;
}
+
static int xen_blkbk_remove(struct xenbus_device *dev)
{
struct backend_info *be = dev_get_drvdata(&dev->dev);
@@ -575,6 +575,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
if (err)
dev_warn(&dev->dev, "writing feature-discard (%d)", err);
}
+
int xen_blkbk_barrier(struct xenbus_transaction xbt,
struct backend_info *be, int state)
{
@@ -663,7 +664,6 @@ static int xen_blkbk_probe(struct xenbus_device *dev,
return err;
}
-
/*
* Callback received when the hotplug scripts have placed the physical-device
* node. Read it and the mode node, and create a vbd. If the frontend is
@@ -755,7 +755,6 @@ static void backend_changed(struct xenbus_watch *watch,
}
}
-
/*
* Callback received when the frontend's state changes.
*/
@@ -830,7 +829,6 @@ static void frontend_changed(struct xenbus_device *dev,
}
}
-
/* Once a memory pressure is detected, squeeze free page pools for a while. */
static unsigned int buffer_squeeze_duration_ms = 10;
module_param_named(buffer_squeeze_duration_ms,
@@ -855,7 +853,6 @@ static void reclaim_memory(struct xenbus_device *dev)
/* ** Connection ** */
-
/*
* Write the physical details regarding the block device to the store, and
* switch to Connected state.
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-17 16:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 16:07 [PATCH v11 0/6] xenbus/backend: Add a memory pressure handler callback SeongJae Park
2019-12-17 16:07 ` [Xen-devel] " SeongJae Park
2019-12-17 16:07 ` [PATCH v11 1/6] xenbus/backend: Add " SeongJae Park
2019-12-17 16:07 ` [Xen-devel] " SeongJae Park
2019-12-17 16:07 ` [PATCH v11 2/6] xenbus/backend: Protect xenbus callback with lock SeongJae Park
2019-12-17 16:07 ` [Xen-devel] " SeongJae Park
2019-12-17 16:13 ` Jürgen Groß
2019-12-17 16:13 ` [Xen-devel] " Jürgen Groß
2019-12-17 16:24 ` SeongJae Park
2019-12-17 16:24 ` SeongJae Park
2019-12-17 17:10 ` Jürgen Groß
2019-12-17 17:10 ` Jürgen Groß
2019-12-17 17:27 ` SeongJae Park
2019-12-17 17:27 ` SeongJae Park
2019-12-17 16:07 ` [PATCH v11 3/6] xen/blkback: Squeeze page pools if a memory pressure is detected SeongJae Park
2019-12-17 16:07 ` [Xen-devel] " SeongJae Park
2019-12-17 16:07 ` [PATCH v11 4/6] xen/blkback: Protect 'reclaim_memory()' with 'reclaim_lock' SeongJae Park
2019-12-17 16:07 ` [Xen-devel] " SeongJae Park
2019-12-17 16:15 ` Jürgen Groß
2019-12-17 16:15 ` [Xen-devel] " Jürgen Groß
2019-12-17 16:31 ` [PATCH 1/3] xen/blkback: Squeeze page pools if a memory pressure is detected SeongJae Park
2019-12-17 16:31 ` [Xen-devel] " SeongJae Park
2019-12-17 16:10 ` [PATCH v11 5/6] xen/blkback: Remove unnecessary static variable name prefixes SeongJae Park
2019-12-17 16:10 ` [Xen-devel] " SeongJae Park
2019-12-17 16:10 ` SeongJae Park [this message]
2019-12-17 16:10 ` [Xen-devel] [PATCH v11 6/6] xen/blkback: Consistently insert one empty line between functions SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217161041.1433-1-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=axboe@kernel.dk \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdurrant@amazon.com \
--cc=roger.pau@citrix.com \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.