All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Arnd Bergmann <arnd@arndb.de>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, sre@kernel.org, nekit1000@gmail.com,
	mpartap@gmx.net, merlijn@wizzup.org, martin_rysavy@centrum.cz,
	Sekhar Nori <nsekhar@ti.com>,
	stable@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	David Lechner <david@lechnology.com>
Subject: Re: TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
Date: Tue, 17 Dec 2019 08:46:40 -0800	[thread overview]
Message-ID: <20191217164640.GX35479@atomide.com> (raw)
In-Reply-To: <20191217104520.GA6812@amd>

* Pavel Machek <pavel@ucw.cz> [191217 10:46]:
> Hi!
> 
> > Selecting RESET_CONTROLLER is actually required, otherwise we
> > can get a link failure in the clock driver:
> > 
> > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > psc-da850.c:(.text+0x24): undefined reference to
> > `reset_controller_add_lookup'
> 
> Does omap need similar handing in 5.5-rc1?
> 
>   LD      .tmp_vmlinux1
>   drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
>   omap_prm.c:(.text+0x4d0): undefined reference to
>   `devm_reset_controller_register'
>   /data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
>   make[1]: *** [vmlinux] Error 1
> 
> Enabling reset controller seems to help::
> 
> Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
>   TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)

Yes see the patch Arnd recently posted to do that.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: mpartap@gmx.net, Arnd Bergmann <arnd@arndb.de>,
	Sekhar Nori <nsekhar@ti.com>,
	merlijn@wizzup.org, martin_rysavy@centrum.cz,
	kernel list <linux-kernel@vger.kernel.org>,
	stable@vger.kernel.org, sre@kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	nekit1000@gmail.com, Philipp Zabel <p.zabel@pengutronix.de>,
	linux-omap@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	David Lechner <david@lechnology.com>
Subject: Re: TI omap compile problem in 5.5-rc1? was Re: [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER
Date: Tue, 17 Dec 2019 08:46:40 -0800	[thread overview]
Message-ID: <20191217164640.GX35479@atomide.com> (raw)
In-Reply-To: <20191217104520.GA6812@amd>

* Pavel Machek <pavel@ucw.cz> [191217 10:46]:
> Hi!
> 
> > Selecting RESET_CONTROLLER is actually required, otherwise we
> > can get a link failure in the clock driver:
> > 
> > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > psc-da850.c:(.text+0x24): undefined reference to
> > `reset_controller_add_lookup'
> 
> Does omap need similar handing in 5.5-rc1?
> 
>   LD      .tmp_vmlinux1
>   drivers/soc/ti/omap_prm.o: In function `omap_prm_probe':
>   omap_prm.c:(.text+0x4d0): undefined reference to
>   `devm_reset_controller_register'
>   /data/fast/l/k/Makefile:1077: recipe for target 'vmlinux' failed
>   make[1]: *** [vmlinux] Error 1
> 
> Enabling reset controller seems to help::
> 
> Reset Controller Support (RESET_CONTROLLER) [Y/n/?] (NEW)
>   TI SYSCON Reset Driver (RESET_TI_SYSCON) [N/m/y/?] (NEW)

Yes see the patch Arnd recently posted to do that.

Regards,

Tony



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-17 16:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 19:51 [PATCH] ARM: davinci: select CONFIG_RESET_CONTROLLER Arnd Bergmann
2019-12-10 19:51 ` Arnd Bergmann
2019-12-11  9:14 ` Bartosz Golaszewski
2019-12-11  9:14   ` Bartosz Golaszewski
2019-12-11 10:00   ` Philipp Zabel
2019-12-11 10:00     ` Philipp Zabel
2019-12-11 10:12 ` Sekhar Nori
2019-12-11 10:12   ` Sekhar Nori
2020-01-13 12:02   ` Sekhar Nori
2020-01-13 12:02     ` Sekhar Nori
2020-01-16 18:34     ` Olof Johansson
2020-01-16 18:34       ` Olof Johansson
2019-12-17 10:45 ` TI omap compile problem in 5.5-rc1? was " Pavel Machek
2019-12-17 10:45   ` Pavel Machek
2019-12-17 10:45   ` Pavel Machek
2019-12-17 16:46   ` Tony Lindgren [this message]
2019-12-17 16:46     ` Tony Lindgren
2019-12-21 16:20     ` Pavel Machek
2019-12-21 16:20       ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217164640.GX35479@atomide.com \
    --to=tony@atomide.com \
    --cc=arnd@arndb.de \
    --cc=bgolaszewski@baylibre.com \
    --cc=david@lechnology.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=martin_rysavy@centrum.cz \
    --cc=merlijn@wizzup.org \
    --cc=mpartap@gmx.net \
    --cc=nekit1000@gmail.com \
    --cc=nsekhar@ti.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.