From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: "Pablo Neira Ayuso" <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, "Máté Eckl" <ecklm94@gmail.com>
Subject: Re: [nf PATCH] netfilter: nft_tproxy: Fix port selector on Big Endian
Date: Wed, 18 Dec 2019 01:03:15 +0100 [thread overview]
Message-ID: <20191218000315.GY795@breakpoint.cc> (raw)
In-Reply-To: <20191217235929.32555-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> On Big Endian architectures, u16 port value was extracted from the wrong
> parts of u32 sreg_port, just like commit 10596608c4d62 ("netfilter:
> nf_tables: fix mismatch in big-endian system") describes.
I was about to debug this today, thanks for debugging/fixing this.
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2019-12-18 0:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 23:59 [nf PATCH] netfilter: nft_tproxy: Fix port selector on Big Endian Phil Sutter
2019-12-18 0:03 ` Florian Westphal [this message]
2019-12-18 0:24 ` Phil Sutter
2019-12-18 0:36 ` Florian Westphal
2019-12-18 14:12 ` Pablo Neira Ayuso
2019-12-19 12:47 ` Máté Eckl
2019-12-20 1:11 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218000315.GY795@breakpoint.cc \
--to=fw@strlen.de \
--cc=ecklm94@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.