All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Jolly Shah <jolly.shah@xilinx.com>
Cc: keescook@chromium.org, ard.biesheuvel@linaro.org,
	matt@codeblueprint.co.uk, gregkh@linuxfoundation.org,
	dmitry.torokhov@gmail.com, michal.simek@xilinx.com,
	linux-kernel@vger.kernel.org, rajanv@xilinx.com,
	Sudeep Holla <sudeep.holla@arm.com>,
	mingo@kernel.org, linux-arm-kernel@lists.infradead.org,
	hkallweit1@gmail.com
Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface
Date: Wed, 18 Dec 2019 14:45:55 +0000	[thread overview]
Message-ID: <20191218144555.GA12525@bogus> (raw)
In-Reply-To: <1575502159-11327-1-git-send-email-jolly.shah@xilinx.com>

On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote:
> This patch series adds xilinx specific sysfs interface for below
> purposes:
> - Register access
> - Set shutdown scope
> - Set boot health status bit

This series defeats the whole abstraction EEMI provides. By providing
direct register accesses, you are allowing user-space to do whatever it
wants. I had NACKed this idea before. Has anything changed ?

If you need it for testing firmware, better put them in debugfs which is
off on production builds.

--
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: Jolly Shah <jolly.shah@xilinx.com>
Cc: ard.biesheuvel@linaro.org, mingo@kernel.org,
	gregkh@linuxfoundation.org, matt@codeblueprint.co.uk,
	hkallweit1@gmail.com, keescook@chromium.org,
	dmitry.torokhov@gmail.com, michal.simek@xilinx.com,
	rajanv@xilinx.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface
Date: Wed, 18 Dec 2019 14:45:55 +0000	[thread overview]
Message-ID: <20191218144555.GA12525@bogus> (raw)
In-Reply-To: <1575502159-11327-1-git-send-email-jolly.shah@xilinx.com>

On Wed, Dec 04, 2019 at 03:29:14PM -0800, Jolly Shah wrote:
> This patch series adds xilinx specific sysfs interface for below
> purposes:
> - Register access
> - Set shutdown scope
> - Set boot health status bit

This series defeats the whole abstraction EEMI provides. By providing
direct register accesses, you are allowing user-space to do whatever it
wants. I had NACKed this idea before. Has anything changed ?

If you need it for testing firmware, better put them in debugfs which is
off on production builds.

--
Regards,
Sudeep

  parent reply	other threads:[~2019-12-18 14:46 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 23:29 [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface Jolly Shah
2019-12-04 23:29 ` Jolly Shah
2019-12-04 23:29 ` [PATCH 1/5] firmware: xilinx: Adds new eemi call for reg access Jolly Shah
2019-12-04 23:29   ` Jolly Shah
2019-12-18 14:10   ` Michal Simek
2019-12-18 14:10     ` Michal Simek
2019-12-18 14:16     ` Michal Simek
2019-12-18 14:16       ` Michal Simek
2019-12-18 14:55   ` Sudeep Holla
2019-12-18 14:55     ` Sudeep Holla
2019-12-04 23:29 ` [PATCH 2/5] firmware: xilinx: Add sysfs interface Jolly Shah
2019-12-04 23:29   ` Jolly Shah
2019-12-18 14:21   ` Michal Simek
2019-12-18 14:21     ` Michal Simek
2019-12-04 23:29 ` [PATCH 3/5] firmware: xilinx: Add system shutdown API interface Jolly Shah
2019-12-04 23:29   ` Jolly Shah
2019-12-18 14:24   ` Michal Simek
2019-12-18 14:24     ` Michal Simek
2019-12-04 23:29 ` [PATCH 4/5] firmware: xilinx: Add sysfs to set shutdown scope Jolly Shah
2019-12-04 23:29   ` Jolly Shah
2019-12-18 14:25   ` Michal Simek
2019-12-18 14:25     ` Michal Simek
2019-12-04 23:29 ` [PATCH 5/5] firmware: xilinx: Add sysfs and IOCTL to set boot health status Jolly Shah
2019-12-04 23:29   ` Jolly Shah
2019-12-18 14:28   ` Michal Simek
2019-12-18 14:28     ` Michal Simek
2019-12-18 14:45 ` Sudeep Holla [this message]
2019-12-18 14:45   ` [PATCH 0/5] firmware: xilinx: Add xilinx specific sysfs interface Sudeep Holla
2020-01-02 21:01   ` Jolly Shah
2020-01-02 21:01     ` Jolly Shah
2020-01-03 11:31     ` Sudeep Holla
2020-01-03 11:31       ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218144555.GA12525@bogus \
    --to=sudeep.holla@arm.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hkallweit1@gmail.com \
    --cc=jolly.shah@xilinx.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeblueprint.co.uk \
    --cc=michal.simek@xilinx.com \
    --cc=mingo@kernel.org \
    --cc=rajanv@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.