From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
Ganesh Sesetti <gseset@codeaurora.org>,
Karthikeyan Periyasamy <periyasa@codeaurora.org>,
John Crispin <john@phrozen.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ath11k: fix uninitialized variable radioup
Date: Wed, 18 Dec 2019 17:53:14 +0000 [thread overview]
Message-ID: <20191218175314.21F8AC433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20191212191044.107544-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> The variable radioup is not uninitalized so it may contain a garbage
> value and hence the detection of a radio that is not up is buggy.
> Fix this by initializing it to zero.
>
> Addresses-Coverity: ("Uninitalized scalar variable")
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
08cc0f44f5ed ath11k: fix uninitialized variable radioup
--
https://patchwork.kernel.org/patch/11289309/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Colin King <colin.king@canonical.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
Ganesh Sesetti <gseset@codeaurora.org>,
Karthikeyan Periyasamy <periyasa@codeaurora.org>,
John Crispin <john@phrozen.org>,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ath11k: fix uninitialized variable radioup
Date: Wed, 18 Dec 2019 17:53:14 +0000 (UTC) [thread overview]
Message-ID: <20191218175314.21F8AC433CB@smtp.codeaurora.org> (raw)
In-Reply-To: <20191212191044.107544-1-colin.king@canonical.com>
Colin King <colin.king@canonical.com> wrote:
> The variable radioup is not uninitalized so it may contain a garbage
> value and hence the detection of a radio that is not up is buggy.
> Fix this by initializing it to zero.
>
> Addresses-Coverity: ("Uninitalized scalar variable")
> Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
08cc0f44f5ed ath11k: fix uninitialized variable radioup
--
https://patchwork.kernel.org/patch/11289309/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-12-18 17:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 19:10 [PATCH][next] ath11k: fix uninitialized variable radioup Colin King
2019-12-12 19:10 ` Colin King
2019-12-18 17:53 ` Kalle Valo [this message]
2019-12-18 17:53 ` Kalle Valo
2019-12-18 17:53 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218175314.21F8AC433CB@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=gseset@codeaurora.org \
--cc=john@phrozen.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=periyasa@codeaurora.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.