All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Andrey Smirnov" <andrew.smirnov@gmail.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-arm@nongnu.org, "Peter Chubb" <peter.chubb@nicta.com.au>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment
Date: Wed, 18 Dec 2019 20:25:26 +0100	[thread overview]
Message-ID: <20191218192526.13845-7-philmd@redhat.com> (raw)
In-Reply-To: <20191218192526.13845-1-philmd@redhat.com>

We don't need to explicit this obvious switch fall through.
Stay consistent with the rest of the codebase.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Cc: Peter Chubb <peter.chubb@nicta.com.au>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: qemu-arm@nongnu.org
---
 hw/pci-host/designware.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c
index 71e9b0d9b5..dd245516dd 100644
--- a/hw/pci-host/designware.c
+++ b/hw/pci-host/designware.c
@@ -182,7 +182,7 @@ designware_pcie_root_config_read(PCIDevice *d, uint32_t address, int len)
         break;
 
     case DESIGNWARE_PCIE_ATU_CR1:
-    case DESIGNWARE_PCIE_ATU_CR2:          /* FALLTHROUGH */
+    case DESIGNWARE_PCIE_ATU_CR2:
         val = viewport->cr[(address - DESIGNWARE_PCIE_ATU_CR1) /
                            sizeof(uint32_t)];
         break;
-- 
2.21.0


  parent reply	other threads:[~2019-12-18 19:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 19:25 [PATCH v2 0/6] Fix more GCC9 -O3 warnings Philippe Mathieu-Daudé
2019-12-18 19:25 ` [PATCH v2 1/6] audio/audio: Add missing fall through comment Philippe Mathieu-Daudé
2019-12-18 19:36   ` Aleksandar Markovic
2020-01-07  7:22   ` Gerd Hoffmann
2019-12-18 19:25 ` [PATCH v2 2/6] hw/display/tcx: Add missing fall through comments Philippe Mathieu-Daudé
2019-12-18 19:36   ` Aleksandar Markovic
2019-12-22 11:12   ` Mark Cave-Ayland
2019-12-18 19:25 ` [PATCH v2 3/6] hw/timer/aspeed_timer: Add a fall through comment Philippe Mathieu-Daudé
2019-12-18 19:25 ` [PATCH v2 4/6] hw/net/imx_fec: Rewrite fall through comments Philippe Mathieu-Daudé
2019-12-18 19:36   ` Thomas Huth
2019-12-18 19:25 ` [RFC PATCH v2 5/6] hw/net/imx_fec: Remove unuseful FALLTHROUGH comments Philippe Mathieu-Daudé
2019-12-18 19:28   ` Thomas Huth
2019-12-18 19:35   ` Aleksandar Markovic
2019-12-18 20:30   ` Richard Henderson
2019-12-18 19:25 ` Philippe Mathieu-Daudé [this message]
2019-12-18 19:32   ` [RFC PATCH v2 6/6] hw/pci-host/designware: Remove unuseful FALLTHROUGH comment Thomas Huth
2019-12-18 19:35   ` Aleksandar Markovic
2019-12-18 20:31   ` Richard Henderson
2019-12-18 21:28   ` Aleksandar Markovic
2020-01-17 16:55 ` [PATCH v2 0/6] Fix more GCC9 -O3 warnings Philippe Mathieu-Daudé
2020-01-17 16:55   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218192526.13845-7-philmd@redhat.com \
    --to=philmd@redhat.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=armbru@redhat.com \
    --cc=peter.chubb@nicta.com.au \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.