* [PATCH bpf-next] libbpf: Add missing newline in opts validation macro
@ 2019-12-19 12:07 Toke Høiland-Jørgensen
2019-12-19 15:10 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Toke Høiland-Jørgensen @ 2019-12-19 12:07 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann
Cc: Toke Høiland-Jørgensen, netdev, bpf
The error log output in the opts validation macro was missing a newline.
Fixes: 2ce8450ef5a3 ("libbpf: add bpf_object__open_{file, mem} w/ extensible opts")
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
tools/lib/bpf/libbpf_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/libbpf_internal.h b/tools/lib/bpf/libbpf_internal.h
index 7d71621bb7e8..8c3afbd97747 100644
--- a/tools/lib/bpf/libbpf_internal.h
+++ b/tools/lib/bpf/libbpf_internal.h
@@ -76,7 +76,7 @@ static inline bool libbpf_validate_opts(const char *opts,
for (i = opts_sz; i < user_sz; i++) {
if (opts[i]) {
- pr_warn("%s has non-zero extra bytes",
+ pr_warn("%s has non-zero extra bytes\n",
type_name);
return false;
}
--
2.24.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf-next] libbpf: Add missing newline in opts validation macro
2019-12-19 12:07 [PATCH bpf-next] libbpf: Add missing newline in opts validation macro Toke Høiland-Jørgensen
@ 2019-12-19 15:10 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2019-12-19 15:10 UTC (permalink / raw)
To: Toke Høiland-Jørgensen; +Cc: Alexei Starovoitov, netdev, bpf
On Thu, Dec 19, 2019 at 01:07:14PM +0100, Toke Høiland-Jørgensen wrote:
> The error log output in the opts validation macro was missing a newline.
>
> Fixes: 2ce8450ef5a3 ("libbpf: add bpf_object__open_{file, mem} w/ extensible opts")
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-19 15:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-19 12:07 [PATCH bpf-next] libbpf: Add missing newline in opts validation macro Toke Høiland-Jørgensen
2019-12-19 15:10 ` Daniel Borkmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.