Re: [PATCH] drm/todo: Updating logging todo

[Sam Ravnborg <sam@ravnborg.org>]

Hi Daniel.

On Thu, Dec 19, 2019 at 05:17:22PM +0100, Daniel Vetter wrote:
> Jani has merged a new set of logging functions, which we hope to be
> the One True solution now, pinky promises:
> 
> commit fb6c7ab8718eb2543695d77ad8302ff81e8e1e32
> Author: Jani Nikula <jani.nikula@intel.com>
> Date:   Tue Dec 10 14:30:43 2019 +0200
> 
>     drm/print: introduce new struct drm_device based logging macros
> 
> Update the todo entry to match the new preference.
> 
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Wambui Karuga <wambui.karugax@gmail.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  Documentation/gpu/todo.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst
> index 2d85f37284a1..017f3090f8a1 100644
> --- a/Documentation/gpu/todo.rst
> +++ b/Documentation/gpu/todo.rst
> @@ -142,13 +142,13 @@ Contact: Daniel Vetter, respective driver maintainers
>  
>  Level: Advanced
>  
> -Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent
> -----------------------------------------------------------------------------
> +Convert logging to drm_* functions with drm_device paramater
> +------------------------------------------------------------
>  
>  For drivers which could have multiple instances, it is necessary to
>  differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR
>  don't do this, drivers used dev_info/warn/err to make this differentiation. We
> -now have DRM_DEV_* variants of the drm print macros, so we can start to convert
> +now have drm_* variants of the drm print functions, so we can start to convert
>  those drivers back to using drm-formwatted specific log messages.
s/drm-formwatted/drm-formatted/?

Acked-by: Sam Ravnborg <sam@ravnborg.org>

drm_print.h could use a rework so it is obvious what is legacy and what
is the right way to do things.
I will add that to my personal todo list for now.

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel