* [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings
@ 2019-12-22 9:57 Yann E. MORIN
2019-12-22 10:23 ` Giulio Benetti
2019-12-23 22:14 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Yann E. MORIN @ 2019-12-22 9:57 UTC (permalink / raw)
To: buildroot
commit: https://git.buildroot.net/buildroot/commit/?id=f7e750e8f514f84bf2f4fc99976dd11f19c8ecbc
branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
KF5_KCOREADDONS_CONF_OPTS is set both outside and inside the
conditional block, so the value set outside would be lost if
the condition were to be true.
Use append-assignement in this case, as reported by check-package.
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
index 5b3e9acd90..76be8876cc 100644
--- a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
+++ b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
@@ -23,7 +23,7 @@ KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_CXX_FLAGS="$(KF5_KCOREADDONS_CXXFLAGS)"
ifeq ($(BR2_microblaze),y)
# Microblaze ld emits warnings, make warnings not to be treated as errors
-KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
+KF5_KCOREADDONS_CONF_OPTS += -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
endif
$(eval $(cmake-package))
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings
2019-12-22 9:57 [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings Yann E. MORIN
@ 2019-12-22 10:23 ` Giulio Benetti
2019-12-22 10:37 ` Yann E. MORIN
2019-12-23 22:14 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Giulio Benetti @ 2019-12-22 10:23 UTC (permalink / raw)
To: buildroot
Hi Yann,
On 12/22/19 10:57 AM, Yann E. MORIN wrote:
> commit: https://git.buildroot.net/buildroot/commit/?id=f7e750e8f514f84bf2f4fc99976dd11f19c8ecbc
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>
> KF5_KCOREADDONS_CONF_OPTS is set both outside and inside the
> conditional block, so the value set outside would be lost if
> the condition were to be true.
>
> Use append-assignement in this case, as reported by check-package.
>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Best regards
--
Giulio Benetti
Benetti Engineering sas
> ---
> package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
> index 5b3e9acd90..76be8876cc 100644
> --- a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
> +++ b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
> @@ -23,7 +23,7 @@ KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_CXX_FLAGS="$(KF5_KCOREADDONS_CXXFLAGS)"
>
> ifeq ($(BR2_microblaze),y)
> # Microblaze ld emits warnings, make warnings not to be treated as errors
> -KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
> +KF5_KCOREADDONS_CONF_OPTS += -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
> endif
>
> $(eval $(cmake-package))
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings
2019-12-22 10:23 ` Giulio Benetti
@ 2019-12-22 10:37 ` Yann E. MORIN
2019-12-22 11:58 ` Giulio Benetti
0 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2019-12-22 10:37 UTC (permalink / raw)
To: buildroot
Giulio, All,
On 2019-12-22 11:23 +0100, Giulio Benetti spake thusly:
> On 12/22/19 10:57 AM, Yann E. MORIN wrote:
> >commit: https://git.buildroot.net/buildroot/commit/?id=f7e750e8f514f84bf2f4fc99976dd11f19c8ecbc
> >branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> >
> >KF5_KCOREADDONS_CONF_OPTS is set both outside and inside the
> >conditional block, so the value set outside would be lost if
> >the condition were to be true.
> >
> >Use append-assignement in this case, as reported by check-package.
> >
> >Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>
> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Thanks, but that was a commit, so your reviewed-by tag won't be
stored... :-/
Regards,
Yann E. MORIN.
> Best regards
> --
> Giulio Benetti
> Benetti Engineering sas
>
> >---
> > package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
> >index 5b3e9acd90..76be8876cc 100644
> >--- a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
> >+++ b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
> >@@ -23,7 +23,7 @@ KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_CXX_FLAGS="$(KF5_KCOREADDONS_CXXFLAGS)"
> > ifeq ($(BR2_microblaze),y)
> > # Microblaze ld emits warnings, make warnings not to be treated as errors
> >-KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
> >+KF5_KCOREADDONS_CONF_OPTS += -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
> > endif
> > $(eval $(cmake-package))
> >_______________________________________________
> >buildroot mailing list
> >buildroot at busybox.net
> >http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings
2019-12-22 10:37 ` Yann E. MORIN
@ 2019-12-22 11:58 ` Giulio Benetti
0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2019-12-22 11:58 UTC (permalink / raw)
To: buildroot
On 12/22/19 11:37 AM, Yann E. MORIN wrote:
> Giulio, All,
>
> On 2019-12-22 11:23 +0100, Giulio Benetti spake thusly:
>> On 12/22/19 10:57 AM, Yann E. MORIN wrote:
>>> commit: https://git.buildroot.net/buildroot/commit/?id=f7e750e8f514f84bf2f4fc99976dd11f19c8ecbc
>>> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
>>>
>>> KF5_KCOREADDONS_CONF_OPTS is set both outside and inside the
>>> conditional block, so the value set outside would be lost if
>>> the condition were to be true.
>>>
>>> Use append-assignement in this case, as reported by check-package.
>>>
>>> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
>>
>> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>
> Thanks, but that was a commit, so your reviewed-by tag won't be
> stored... :-/
Oops, right.
Thanks for fixing
Best regards
--
Giulio Benetti
Benetti Engineering sas
> Regards,
> Yann E. MORIN.
>
>> Best regards
>> --
>> Giulio Benetti
>> Benetti Engineering sas
>>
>>> ---
>>> package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
>>> index 5b3e9acd90..76be8876cc 100644
>>> --- a/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
>>> +++ b/package/kf5/kf5-kcoreaddons/kf5-kcoreaddons.mk
>>> @@ -23,7 +23,7 @@ KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_CXX_FLAGS="$(KF5_KCOREADDONS_CXXFLAGS)"
>>> ifeq ($(BR2_microblaze),y)
>>> # Microblaze ld emits warnings, make warnings not to be treated as errors
>>> -KF5_KCOREADDONS_CONF_OPTS = -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
>>> +KF5_KCOREADDONS_CONF_OPTS += -DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-fatal-warnings"
>>> endif
>>> $(eval $(cmake-package))
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot at busybox.net
>>> http://lists.busybox.net/mailman/listinfo/buildroot
>>>
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings
2019-12-22 9:57 [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings Yann E. MORIN
2019-12-22 10:23 ` Giulio Benetti
@ 2019-12-23 22:14 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-12-23 22:14 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> commit: https://git.buildroot.net/buildroot/commit/?id=f7e750e8f514f84bf2f4fc99976dd11f19c8ecbc
> branch: https://git.buildroot.net/buildroot/commit/?id=refs/heads/master
> KF5_KCOREADDONS_CONF_OPTS is set both outside and inside the
> conditional block, so the value set outside would be lost if
> the condition were to be true.
> Use append-assignement in this case, as reported by check-package.
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Committed to 2019.02.x and 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-23 22:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-22 9:57 [Buildroot] [git commit] package/kf5-kcoreaddons: fix check-package warnings Yann E. MORIN
2019-12-22 10:23 ` Giulio Benetti
2019-12-22 10:37 ` Yann E. MORIN
2019-12-22 11:58 ` Giulio Benetti
2019-12-23 22:14 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.