[Buildroot] [PATCH 1/1] package/python-pathlib2: select python-scandir

[Buildroot] [PATCH 1/1] package/python-pathlib2: select python-scandir

[Asaf Kahlon]

scandir is a runtime dependency of pathlib2.

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 package/python-pathlib2/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/python-pathlib2/Config.in b/package/python-pathlib2/Config.in
index e28de4c12e..ca948c271f 100644
--- a/package/python-pathlib2/Config.in
+++ b/package/python-pathlib2/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_PYTHON_PATHLIB2
 	bool "python-pathlib2"
 	depends on BR2_PACKAGE_PYTHON
+	select BR2_PACKAGE_PYTHON_SCANDIR # runtime
 	select BR2_PACKAGE_PYTHON_SIX # runtime
 	help
 	  Object-oriented filesystem paths.
-- 
2.20.1

[Buildroot] [PATCH 1/1] package/python-pathlib2: select python-scandir

[Thomas Petazzoni]

On Mon, 16 Dec 2019 21:48:15 +0200
Asaf Kahlon <asafka7@gmail.com> wrote:

> scandir is a runtime dependency of pathlib2.
> 
> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  package/python-pathlib2/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-pathlib2/Config.in b/package/python-pathlib2/Config.in
> index e28de4c12e..ca948c271f 100644
> --- a/package/python-pathlib2/Config.in
> +++ b/package/python-pathlib2/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_PYTHON_PATHLIB2
>  	bool "python-pathlib2"
>  	depends on BR2_PACKAGE_PYTHON
> +	select BR2_PACKAGE_PYTHON_SCANDIR # runtime

I see this in the setup.py:

    extras_require={
        ':python_version<"3.5"': ['scandir'],
        },

Doesn't that mean that it is needed only if the Python version is < 3.5 ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/python-pathlib2: select python-scandir

[Asaf Kahlon]

Hello,

On Sun, Dec 22, 2019 at 3:42 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Mon, 16 Dec 2019 21:48:15 +0200
> Asaf Kahlon <asafka7@gmail.com> wrote:
>
> > scandir is a runtime dependency of pathlib2.
> >
> > Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> > ---
> >  package/python-pathlib2/Config.in | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/package/python-pathlib2/Config.in b/package/python-pathlib2/Config.in
> > index e28de4c12e..ca948c271f 100644
> > --- a/package/python-pathlib2/Config.in
> > +++ b/package/python-pathlib2/Config.in
> > @@ -1,6 +1,7 @@
> >  config BR2_PACKAGE_PYTHON_PATHLIB2
> >       bool "python-pathlib2"
> >       depends on BR2_PACKAGE_PYTHON
> > +     select BR2_PACKAGE_PYTHON_SCANDIR # runtime
>
> I see this in the setup.py:
>
>     extras_require={
>         ':python_version<"3.5"': ['scandir'],
>         },
>
> Doesn't that mean that it is needed only if the Python version is < 3.5 ?

Yeah that's true, but pathlib2 can be chosen only for python 2,
so we can say for sure it's needed.

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Regards,
Asaf.

[Buildroot] [PATCH 1/1] package/python-pathlib2: select python-scandir

[Conrad Ratschan]

Asaf, All,

On Sun, Dec 22, 2019 at 11:39 AM Asaf Kahlon <asafka7@gmail.com> wrote:
>
> Yeah that's true, but pathlib2 can be chosen only for python 2,
> so we can say for sure it's needed.

I can confirm that pathlib2 will crash on first invocation when using
python2 if BR2_PACKAGE_PYTHON_SCANDIR is not enabled.

Thanks,

Conrad
-- 
Conrad Ratschan | Software Engineer | Commercial Avionics
COLLINS AEROSPACE
400 Collins Road NE, Cedar Rapids, IA 52498, USA
conrad.ratschan at collins.com | collinsaerospace.com

CONFIDENTIALITY WARNING: This message may contain proprietary and/or
privileged information of Collins Aerospace and its affiliated
companies. If you are not the intended recipient, please 1) Do not
disclose, copy, distribute or use this message or its contents. 2)
Advise the sender by return email. 3) Delete all copies (including all
attachments) from your computer. Your cooperation is greatly
appreciated.